Update Improve Digital adapter for Prebid 1.0#1728
Merged
dbemiller merged 4 commits intoprebid:masterfrom Oct 26, 2017
Merged
Conversation
dbemiller
suggested changes
Oct 24, 2017
Contributor
dbemiller
left a comment
dbemiller
left a comment
There was a problem hiding this comment.
Looks overall fine... just one small comment from me
modules/improvedigitalBidAdapter.js
Outdated
| } | ||
| bid.ad = `${nurl}<script>${bidObject.adm}</script>`; | ||
| bid.adId = bidObject.id; | ||
| bid.bidderCode = spec.code; |
Contributor
There was a problem hiding this comment.
Our docs are being updated now, but... you don't need to set this property. In fact if you do, it'll break adapter aliasing.
dbemiller
approved these changes
Oct 24, 2017
jaiminpanchal27
requested changes
Oct 24, 2017
| if (bidObject.nurl && bidObject.nurl.length > 0) { | ||
| nurl = `<img src="${bidObject.nurl}" width="0" height="0" style="display:none">`; | ||
| } | ||
| bid.ad = `${nurl}<script>${bidObject.adm}</script>`; |
Collaborator
There was a problem hiding this comment.
Please add required param creativeId to bid response. http://prebid.org/dev-docs/bidder-adapter-1.html
dbemiller
suggested changes
Oct 24, 2017
Contributor
dbemiller
left a comment
dbemiller
left a comment
There was a problem hiding this comment.
Actually... one more change, because #1742 got merged.
The first argument to interpretResponse now looks like this:
{
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}
You'll have to update the spec so that it looks through that object as well now.
Contributor
Author
|
All requested changes done |
jaiminpanchal27
approved these changes
Oct 25, 2017
dbemiller
approved these changes
Oct 26, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 31, 2017
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Improve Digital adapter changes for Prebid 1.0.