Update Conversant adapter to Prebid 1.0#1711
Conversation
modules/conversantBidAdapter.js
Outdated
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| aliases: ['conversant'], // short code |
There was a problem hiding this comment.
Aliases should be different than BIDDER_CODE. Short code should be 3-4 characters i believe.
modules/conversantBidAdapter.js
Outdated
| } catch (e) { | ||
| script.text = code; | ||
| document.getElementsByTagName('head')[0].appendChild(script); | ||
| if (!bid.params.site_id || !utils.isStr(bid.params.site_id)) { |
There was a problem hiding this comment.
First check isn't required
modules/conversantBidAdapter.js
Outdated
| }); | ||
| }); | ||
| } | ||
| const conversantImps = utils._map(validBidRequests, function(bid) { |
There was a problem hiding this comment.
nit: you can use Array.map directly now.
modules/conversantBidAdapter.js
Outdated
|
|
||
| const bid = { | ||
| requestId: conversantBid.impid, | ||
| bidderCode: BIDDER_CODE, |
There was a problem hiding this comment.
We made a change after the docs were released - can you please remove the bidderCode property here? Thanks
|
@pycnvr |
|
@mkendall07 That sounds strange. I'll check it out. Thanks. |
|
@mkendall07 Changes uploaded. |
| const bidResponses = []; | ||
| const requestMap = {}; | ||
| const currency = serverResponse.cur || 'USD'; | ||
| serverResponse = serverResponse.body; |
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
3 participants
Type of change
Description of change
Update Conversant adapter to Prebid 1.0
Other information