AdOcean Adpater for Prebid 1.0#1735
Conversation
matthewlane
left a comment
There was a problem hiding this comment.
Thanks for the new adapter. A few changes requested below
modules/adoceanBidAdapter.js
Outdated
There was a problem hiding this comment.
If your adapter doesn't need user syncing, this function can be removed
There was a problem hiding this comment.
Looks like use is imported but not used in the test, can be removed
modules/adoceanBidAdapter.js
Outdated
There was a problem hiding this comment.
creativeId, netRevenue, and ttl should also be in this object as well. See the table in http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response for information about these fields
modules/adoceanBidAdapter.js
Outdated
There was a problem hiding this comment.
bidderCode can be dropped as well, it'll be set automatically by bidderFactory. Docs are being updated now, sorry for the confusion prebid/prebid.github.io#411
modules/adoceanBidAdapter.js
Outdated
There was a problem hiding this comment.
One more change with #1748 now merged to master:
The first argument to interpretResponse has been changed, and now looks like this:
{
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}So to retain the same functionality as before, doing something like
serverResponse = serverResponse.body;just below this line (or however you'd prefer) , and in tests as needed, should help
Could you rebase off of master and update that?
|
Fixed and rebased to master. |
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits) Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) ...
Type of change
Description of change
new bidder adapter .