Jira Integration: fix for handling jira api v3 with ADF#4756
Merged
SuperQ merged 1 commit intoprometheus:mainfrom Jan 30, 2026
Merged
Jira Integration: fix for handling jira api v3 with ADF#4756SuperQ merged 1 commit intoprometheus:mainfrom
SuperQ merged 1 commit intoprometheus:mainfrom
Conversation
cead6d8 to
7a1fbc4
Compare
ultrotter
approved these changes
Nov 22, 2025
Signed-off-by: Holger Waschke <waschkester@gmail.com>
bd2c5dd to
c03adf8
Compare
|
Thank you for the work on this pull request. From a user perspective, this bug fix would be very valuable. |
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 2, 2026
* [ENHANCEMENT] docs(opsgenie): Fix description of `api_url` field. #4908 * [ENHANCEMENT] docs(slack): Document missing app configs. #4871 * [ENHANCEMENT] docs: Fix `max-silence-size-bytes`. #4805 * [ENHANCEMENT] docs: Update expr for `AlertmanagerClusterFailedToSendAlerts` to exclude value 0. #4872 * [ENHANCEMENT] docs: Use matchers for inhibit rules examples. #4131 * [ENHANCEMENT] docs: add notification integrations. #4901 * [ENHANCEMENT] docs: update `slack_config` attachments documentation links. #4802 * [ENHANCEMENT] docs: update description of filter query params in openapi doc. #4810 * [ENHANCEMENT] provider: Reduce lock contention. #4809 * [FEATURE] slack: Add support for top-level text field in slack notification. #4867 * [FEATURE] smtp: Add support for authsecret from file. #3087 * [FEATURE] smtp: Customize the ssl/tls port support (#4757). #4818 * [FEATURE] smtp: Enhance email notifier configuration validation. #4826 * [FEATURE] telegram: Add `chat_id_file` configuration parameter. #4909 * [FEATURE] telegram: Support global bot token. #4823 * [FEATURE] webhook: Support templating in url fields. #4798 * [FEATURE] wechat: Add config directive to pass api secret via file. #4734 * [FEATURE] provider: Implement per alert limits. #4819 * [BUGFIX] Allow empty `group_by` to override parent route. #4825 * [BUGFIX] Set `spellcheck=false` attribute on silence filter input. #4811 * [BUGFIX] jira: Fix for handling api v3 with ADF. #4756 * [BUGFIX] jira: Prevent hostname corruption in cloud api url replacement. #4892 --------- Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this resolves #4585
Description has to be of type any in the struct to be able to parse it as string (for api v2) or as rawJSON (for api v3)
It´s not enough to parse it as a JSON in a string and then do the JSON Encoding. This results in incorrect encoding:
wrong:
"{\"fields\":{\"description\":\"\\n{\\n \\\"version\\\": 1,\\n \\\"type\\\": \\\"doc\\\",\\n \\\"content\\\": [\\n {\\n \\\"type\\\": \\\"paragraph\\\",\\n \\\"content\\\": [\\n {\\n \\\"type\\\": \\\"text\\\",\\n \\\"text\\\": \\\"Hello \\\"\\n },\\n {\\n \\\"type\\\": \\\"text\\\",\\n \\\"text\\\": \\\"world\\\",\\n \\\"marks\\\": [\\n {\\n \\\"type\\\": \\\"strong\\\"\\n }\\n ]\\n }\\n ]\\n }\\n ]\\n}\",\"issuetype\":{\"name\":\"Alarm\"},\"labels\":[\"ALERT{d95eb188699ae81ab...+133 more"Correctly encoded with rawjson:
"{\"fields\":{\"description\":{\"version\":1,\"type\":\"doc\",\"content\":[{\"type\":\"paragraph\",\"content\":[{\"type\":\"text\",\"text\":\"Hello \"},{\"type\":\"text\",\"text\":\"world\",\"marks\":[{\"type\":\"strong\"}]}]}]},\"issuetype\":{\"name\":\"Alarm\"},\"labels\":[\"ALERT{2e7c5964e80dc3b92649fe2211e1f0f55704739f6f819c606ae0176296f0c91a}\"],\"project\":{\"key\":\"ASPMIG\"},\"summary\":\"[ABNAHME][FIRING:1]newsystem_test_aler0t \"}}\n"tested both ways. rendered trough a template
or direct in the config
both work.
ToDo:
Provide a description v3 template which all labels included.