Set spellcheck=false attribute on silence filter <input>#4811
Merged
SuperQ merged 2 commits intoprometheus:mainfrom Jan 30, 2026
Merged
Set spellcheck=false attribute on silence filter <input>#4811SuperQ merged 2 commits intoprometheus:mainfrom
SuperQ merged 2 commits intoprometheus:mainfrom
Conversation
Contributor
|
LGTM, but I can't really verify the result due to lack of apple devices. |
Contributor
Author
|
The red squiggly lines also happen on Linux, which is why I deem this worth merging. @SuperQ Can you merge this ? |
Contributor
Author
|
Reproduced on Mac as well now. From my test, smart quoting appears to be a user-defined setting, which was turned on my notebook. The fix those what it should. |
This hints to iOS Safari and other browsers that they shouldn't use spellcheck, but, more importantly, shouldn't use smart quotes (like “this” instead of "this"). This matters here because Alertmanager requires quotes for a filter but won't accept smart quotes, making it tedious since the default input keyboard will normally use them automatically. Signed-off-by: David Symonds <dsymonds@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Closes: prometheus#3529 Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
SuperQ
approved these changes
Jan 30, 2026
Member
|
lol, oof, smartquotes. |
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 2, 2026
* [ENHANCEMENT] docs(opsgenie): Fix description of `api_url` field. #4908 * [ENHANCEMENT] docs(slack): Document missing app configs. #4871 * [ENHANCEMENT] docs: Fix `max-silence-size-bytes`. #4805 * [ENHANCEMENT] docs: Update expr for `AlertmanagerClusterFailedToSendAlerts` to exclude value 0. #4872 * [ENHANCEMENT] docs: Use matchers for inhibit rules examples. #4131 * [ENHANCEMENT] docs: add notification integrations. #4901 * [ENHANCEMENT] docs: update `slack_config` attachments documentation links. #4802 * [ENHANCEMENT] docs: update description of filter query params in openapi doc. #4810 * [ENHANCEMENT] provider: Reduce lock contention. #4809 * [FEATURE] slack: Add support for top-level text field in slack notification. #4867 * [FEATURE] smtp: Add support for authsecret from file. #3087 * [FEATURE] smtp: Customize the ssl/tls port support (#4757). #4818 * [FEATURE] smtp: Enhance email notifier configuration validation. #4826 * [FEATURE] telegram: Add `chat_id_file` configuration parameter. #4909 * [FEATURE] telegram: Support global bot token. #4823 * [FEATURE] webhook: Support templating in url fields. #4798 * [FEATURE] wechat: Add config directive to pass api secret via file. #4734 * [FEATURE] provider: Implement per alert limits. #4819 * [BUGFIX] Allow empty `group_by` to override parent route. #4825 * [BUGFIX] Set `spellcheck=false` attribute on silence filter input. #4811 * [BUGFIX] jira: Fix for handling api v3 with ADF. #4756 * [BUGFIX] jira: Prevent hostname corruption in cloud api url replacement. #4892 --------- Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simply tidies up an existing change: #3529
It fixes the red underlining of labels:
Original PR: