update expr for AlertmanagerClusterFailedToSendAlerts to exclude value 0#4872
Merged
jan--f merged 4 commits intoprometheus:mainfrom Jan 26, 2026
Merged
Conversation
ultrotter
approved these changes
Jan 9, 2026
…4888) Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.30.0 to 0.32.0. - [Commits](golang/mod@v0.30.0...v0.32.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.32.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Junqi Zhao <juzhao@redhat.com> Signed-off-by: juzhao <juzhao@redhat.com>
Signed-off-by: Junqi Zhao <juzhao@redhat.com> Signed-off-by: juzhao <juzhao@redhat.com>
juzhao
force-pushed
the
update_AlertmanagerClusterFailedToSendAlerts
branch
from
58066ee to
43a89f4
Compare
TheMeier
approved these changes
Jan 16, 2026
Contributor
Author
|
needs approval from a maintainer in: https://github.com/prometheus/alertmanager/blob/main/MAINTAINERS.md to run the workflows |
Contributor
Author
|
@simonpasquier can you help to review and approve it? |
jan--f
approved these changes
Jan 22, 2026
Contributor
|
@juzhao can you please rebase you PR? |
Contributor
Author
done |
jan--f
approved these changes
Jan 26, 2026
Contributor
jan--f
left a comment
jan--f
left a comment
There was a problem hiding this comment.
Thanks for the thorough description.
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 2, 2026
* [ENHANCEMENT] docs(opsgenie): Fix description of `api_url` field. #4908 * [ENHANCEMENT] docs(slack): Document missing app configs. #4871 * [ENHANCEMENT] docs: Fix `max-silence-size-bytes`. #4805 * [ENHANCEMENT] docs: Update expr for `AlertmanagerClusterFailedToSendAlerts` to exclude value 0. #4872 * [ENHANCEMENT] docs: Use matchers for inhibit rules examples. #4131 * [ENHANCEMENT] docs: add notification integrations. #4901 * [ENHANCEMENT] docs: update `slack_config` attachments documentation links. #4802 * [ENHANCEMENT] docs: update description of filter query params in openapi doc. #4810 * [ENHANCEMENT] provider: Reduce lock contention. #4809 * [FEATURE] slack: Add support for top-level text field in slack notification. #4867 * [FEATURE] smtp: Add support for authsecret from file. #3087 * [FEATURE] smtp: Customize the ssl/tls port support (#4757). #4818 * [FEATURE] smtp: Enhance email notifier configuration validation. #4826 * [FEATURE] telegram: Add `chat_id_file` configuration parameter. #4909 * [FEATURE] telegram: Support global bot token. #4823 * [FEATURE] webhook: Support templating in url fields. #4798 * [FEATURE] wechat: Add config directive to pass api secret via file. #4734 * [FEATURE] provider: Implement per alert limits. #4819 * [BUGFIX] Allow empty `group_by` to override parent route. #4825 * [BUGFIX] Set `spellcheck=false` attribute on silence filter input. #4811 * [BUGFIX] jira: Fix for handling api v3 with ADF. #4756 * [BUGFIX] jira: Prevent hostname corruption in cloud api url replacement. #4892 --------- Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AlertmanagerClusterFailedToSendAlerts critical alert is defined in
https://github.com/prometheus/alertmanager/blob/release-0.29/doc/alertmanager-mixin/alerts.libsonnet#L61-L78
configured wrong smtp port for email_configs
saw the erorrs in alertmanager logs
expected the AlertmanagerClusterFailedToSendAlerts to be fired, but not, checked locally, the
reasonlabel has several possible values and some of them report 0 so min(...) is always 0, exclude the value 0 can trigger the alertsame for the AlertmanagerClusterFailedToSendAlerts warning alert