Support templating in webhook url fields#4798
Merged
SuperQ merged 9 commits intoprometheus:mainfrom Jan 5, 2026
Merged
Conversation
Signed-off-by: Walther Lee <walthere.lee@gmail.com>
SoloJacobs
reviewed
Dec 5, 2025
Contributor
SoloJacobs
left a comment
SoloJacobs
left a comment
There was a problem hiding this comment.
From what I understand:
- We don't expose
MarshallYAML, so the new implementation is backwards compatible. I.e, all old configurations are accepted by the newUnmarshallYAMLimplementation. Here are two configurations, which are only accepted by the new implementation.
- name: 'empty-url'
webhook_configs:
- url: ''
url_file: 'url.txt'
- name: 'not-a-url'
webhook_configs:
- url: 'ssh://ab'For the not-a-url config the new behaviour is rather unfortunate. Did you consider validating URLs, which don't have a template?
- Could we maybe get some tests for the new templating in
notify/webhook/webhook.go? - There are also some other configurations, which could be handled in a similar manor I think:
SlackConfigMSTeamsConfigMSTeamsV2ConfigMattermostConfigDiscordConfig
I guess that is out-off-scope for this PR, though.
Member
Author
|
Sure, I can add the change for those too and some tests. Thanks Solomon |
Signed-off-by: Walther Lee <walthere.lee@gmail.com>
Signed-off-by: Walther Lee <walthere.lee@gmail.com>
Member
Author
|
The change from I added tests for templated urls in webhook but won't change the other URL fields from other configs in this PR to keep it small. I'll send a second one with just the switch to |
Signed-off-by: Walther Lee <walthere.lee@gmail.com>
SoloJacobs
approved these changes
Dec 8, 2025
Contributor
SoloJacobs
left a comment
SoloJacobs
left a comment
There was a problem hiding this comment.
Alright, very extensive tests, nice 👍 I also like the new SecretTemplURL, LGTM.
Spaceman1701
reviewed
Dec 9, 2025
Signed-off-by: Walther Lee <walthere.lee@gmail.com>
TheMeier
approved these changes
Dec 11, 2025
Spaceman1701
approved these changes
Dec 12, 2025
SuperQ
approved these changes
Jan 5, 2026
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 2, 2026
* [ENHANCEMENT] docs(opsgenie): Fix description of `api_url` field. #4908 * [ENHANCEMENT] docs(slack): Document missing app configs. #4871 * [ENHANCEMENT] docs: Fix `max-silence-size-bytes`. #4805 * [ENHANCEMENT] docs: Update expr for `AlertmanagerClusterFailedToSendAlerts` to exclude value 0. #4872 * [ENHANCEMENT] docs: Use matchers for inhibit rules examples. #4131 * [ENHANCEMENT] docs: add notification integrations. #4901 * [ENHANCEMENT] docs: update `slack_config` attachments documentation links. #4802 * [ENHANCEMENT] docs: update description of filter query params in openapi doc. #4810 * [ENHANCEMENT] provider: Reduce lock contention. #4809 * [FEATURE] slack: Add support for top-level text field in slack notification. #4867 * [FEATURE] smtp: Add support for authsecret from file. #3087 * [FEATURE] smtp: Customize the ssl/tls port support (#4757). #4818 * [FEATURE] smtp: Enhance email notifier configuration validation. #4826 * [FEATURE] telegram: Add `chat_id_file` configuration parameter. #4909 * [FEATURE] telegram: Support global bot token. #4823 * [FEATURE] webhook: Support templating in url fields. #4798 * [FEATURE] wechat: Add config directive to pass api secret via file. #4734 * [FEATURE] provider: Implement per alert limits. #4819 * [BUGFIX] Allow empty `group_by` to override parent route. #4825 * [BUGFIX] Set `spellcheck=false` attribute on silence filter input. #4811 * [BUGFIX] jira: Fix for handling api v3 with ADF. #4756 * [BUGFIX] jira: Prevent hostname corruption in cloud api url replacement. #4892 --------- Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an old thread, but there's been some discussion here about supporting templating in webhook url fields: #684
The issue was closed in 2017 because the alertmanager didn't support templating for any http/url fields, but there're some examples where it does support it now, for example SlackAction.URL and PushoverConfig.URL, so I think we can re-evaluate adding support for this.
There's some good use cases described by others in the thread since it was closed.
This change adds templating to the fields. Existing tests already check that secret URL is still not exposed.