Fix: Allow empty group_by to override parent route#4825
Merged
SuperQ merged 5 commits intoprometheus:mainfrom Jan 30, 2026
Merged
Fix: Allow empty group_by to override parent route#4825SuperQ merged 5 commits intoprometheus:mainfrom
SuperQ merged 5 commits intoprometheus:mainfrom
Conversation
Signed-off-by: ADITYATIWARI342005 <142050150+ADITYATIWARI342005@users.noreply.github.com>
SoloJacobs
requested changes
Dec 23, 2025
Contributor
SoloJacobs
left a comment
SoloJacobs
left a comment
There was a problem hiding this comment.
Did you check that this fix resolves the issue completely, e.g., by creating a small test setup?
Signed-off-by: Aditya Tiwari <adityatiwari342005@gmail.com>
Contributor
Author
|
Hi @SoloJacobs
I tested for the unit test and go tests for build and gofmt etc. However I did not create a dedicated test setup/script, but since you mentioned it, I did that too validation script confirms:
The fix correctly resolves #4221 by initializing I've also simplify the test config as suggested (removing unnecessary match/receiver fields). |
SoloJacobs
approved these changes
Dec 24, 2025
Contributor
SoloJacobs
left a comment
SoloJacobs
left a comment
There was a problem hiding this comment.
Very nice, well done 🙂 Just a reminder, due to the current time constraints of maintainers, all changes take some time to be merged.
TheMeier
approved these changes
Jan 7, 2026
Signed-off-by: Aditya Tiwari <adityatiwari342005@gmail.com>
Signed-off-by: Aditya Tiwari <adityatiwari342005@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 2, 2026
* [ENHANCEMENT] docs(opsgenie): Fix description of `api_url` field. #4908 * [ENHANCEMENT] docs(slack): Document missing app configs. #4871 * [ENHANCEMENT] docs: Fix `max-silence-size-bytes`. #4805 * [ENHANCEMENT] docs: Update expr for `AlertmanagerClusterFailedToSendAlerts` to exclude value 0. #4872 * [ENHANCEMENT] docs: Use matchers for inhibit rules examples. #4131 * [ENHANCEMENT] docs: add notification integrations. #4901 * [ENHANCEMENT] docs: update `slack_config` attachments documentation links. #4802 * [ENHANCEMENT] docs: update description of filter query params in openapi doc. #4810 * [ENHANCEMENT] provider: Reduce lock contention. #4809 * [FEATURE] slack: Add support for top-level text field in slack notification. #4867 * [FEATURE] smtp: Add support for authsecret from file. #3087 * [FEATURE] smtp: Customize the ssl/tls port support (#4757). #4818 * [FEATURE] smtp: Enhance email notifier configuration validation. #4826 * [FEATURE] telegram: Add `chat_id_file` configuration parameter. #4909 * [FEATURE] telegram: Support global bot token. #4823 * [FEATURE] webhook: Support templating in url fields. #4798 * [FEATURE] wechat: Add config directive to pass api secret via file. #4734 * [FEATURE] provider: Implement per alert limits. #4819 * [BUGFIX] Allow empty `group_by` to override parent route. #4825 * [BUGFIX] Set `spellcheck=false` attribute on silence filter input. #4811 * [BUGFIX] jira: Fix for handling api v3 with ADF. #4756 * [BUGFIX] jira: Prevent hostname corruption in cloud api url replacement. #4892 --------- Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4221
Child routes with
group_by: []were incorrectly inheriting parent route'sgroup_by configuration instead of overriding it. This fix initializes
GroupByas an empty slice when
GroupByStris explicitly set to empty, allowing childroutes to properly disable grouping.