fix: preserve blocklist on media deletion & optimise watchlist-sync

[fallenbagel]

Description

When a user blocklists media and then removes it from Sonarr/Radarr via the Seerr interface, the Media entity and its associated Blocklist record were both destroyed due to the cascade delete on the relationship. On the next watchlist sync cycle, no record existed to check against, so a fresh request was created and auto-approved, completely bypassing the blocklist.

This PR fixes the media delete endpoint to detect blocklisted status and preserve the entity by nulling out service-related fields rather than removing the row entirely. It also improves the watchlist sync filtering to exclude blocklisted media as a safety net and to skip items where the user already has an existing auto-request, eliminating the repeated unnecessary api calls and database lookups that were happening every sync cycle just to throw a duplicate request error.

• Fixes Media from watchlist with auto-approve isn't respected in blocklist #2475

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Watchlist sync now excludes items the user has already auto-requested, reducing duplicate requests.
  • Deleting a blocklisted media item now preserves the record while clearing external/service identifiers instead of removing it.
  • Watchlist sync still respects user permissions and settings; existing error handling for request creation remains unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

Adds filtering in watchlist sync to skip items the user has already auto-requested by querying existing MediaRequest records; adds Media.resetServiceData() to clear service-related fields; changes DELETE /:id to call resetServiceData() and save when media.status is BLOCKLISTED instead of deleting the record.

Changes

Cohort / File(s)	Summary
Watchlist Sync Auto-Request Filtering server/lib/watchlistsync.ts	Collects watchlist TMDB IDs, queries MediaRequest for the current user's matching TMDB IDs to build a "mediaType:tmdbId" set, and filters watchlist items to exclude those already auto-requested before attempting request creation.
Media Deletion / Blocklist Preservation server/routes/media.ts	Modifies DELETE /:id handler to, when media.status is BLOCKLISTED, call resetServiceData() and save the entity instead of removing the row; for other statuses, proceeds with removal.
Media Entity Service Data Reset server/entity/Media.ts	Adds public resetServiceData(): void method that nulls service-related fields (serviceId*, externalServiceId*, externalServiceSlug*, ratingKey*, jellyfinMediaId*, ratingKey*, etc.) to allow preserving blocklisted records without external identifiers.

Sequence Diagram(s)

sequenceDiagram
    participant Plex as Plex Watchlist API
    participant Job as Watchlist Sync Job
    participant DB as Database
    participant Creator as MediaRequest Creator

    Plex->>Job: return watchlist items (tmdbId, mediaType)
    Job->>DB: query MediaRequest where userId = X and tmdbId IN (watchlistTmdbIds)
    DB-->>Job: existing auto-request set (mediaType:tmdbId)
    Job->>Job: filter watchlist items excluding existing set and blocked/unavailable
    Job->>Creator: create media request for each remaining item
    Creator-->>DB: persist new MediaRequest (if created)
    Creator-->>Job: return result (success/failure)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐇 I hopped through watchlists, sniffed each seed,
Skipped the echoes of requests already freed.
For blocklisted hares I left no external trace,
Cleared service prints, kept the record in place.
🥕

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the two main changes: preserving blocklist on media deletion and optimizing watchlist-sync filtering.
Linked Issues check	✅ Passed	The PR implements both key requirements from #2475: preserving blocklisted media by nulling service fields instead of deletion, and optimizing watchlist-sync to skip already auto-requested items.
Out of Scope Changes check	✅ Passed	All changes directly address the blocklist preservation and watchlist-sync optimization objectives described in issue #2475, with no unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/lib/watchlistsync.ts`:
- Around line 73-84: existingAutoRequests mapping assumes every MediaRequest has
a loaded media relation and accessing r.media.tmdbId can throw; update the
mapping that builds autoRequestedTmdbIds to guard against missing media by
filtering or null-checking each request first (e.g., use
existingAutoRequests.filter(r => r.media).map(r => r.media.tmdbId) or
conditional access) so only valid tmdbId values are added; modify the logic
around requestRepository, existingAutoRequests, and autoRequestedTmdbIds to
safely handle requests with null/undefined media.

[Copilot]

Pull request overview

Fixes a watchlist-sync + media deletion edge case where deleting a Media row could cascade-delete its Blocklist entry, allowing future watchlist sync cycles to recreate and auto-approve requests that should remain blocked.

Changes:

• Updates the media delete endpoint to preserve blocklisted media by nulling service-related fields instead of deleting the row.
• Hardens watchlist sync filtering to skip blocklisted items and avoid repeated duplicate auto-request attempts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
server/routes/media.ts	Preserves blocklisted media on deletion by clearing service identifiers instead of removing the entity.
server/lib/watchlistsync.ts	Adds pre-filtering to skip blocklisted media and items with existing auto-requests before attempting request creation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gauthier-th]

LGTM