chore(eslint): add react/self-closing-comp by caillou · Pull Request #2563 · seerr-team/seerr

caillou · 2026-02-23T16:49:57Z

Description

It might make sense to implement our project specific coding guidelines in eslint as much as possible, in order to avoid for our reviewers to have to comment on these guidelines.

This is an example from a recent PR

This PR configures the auto-fixable react/self-closing-comp and fixes the remaining issues.

Feel free to close this PR, if this is considered too much.

Checklist:

I have read and followed the contribution guidelines.
Disclosed any use of AI (see our policy)
I have updated the documentation accordingly.
All new and existing tests passed.
Successful build pnpm build
Translation keys pnpm i18n:extract
Database migration (if required)

gauthier-th

LGTM

Copilot

Pull request overview

This PR enforces the React self-closing-comp ESLint rule to automatically ensure components without children use self-closing syntax, reducing manual code review burden. This aligns with the project's coding guidelines to improve consistency.

Changes:

Added react/self-closing-comp ESLint rule as an error in the configuration
Converted all non-self-closing empty tags to self-closing syntax across 14 files

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`.eslintrc.js`	Added `react` plugin and `react/self-closing-comp` rule to TypeScript React file overrides
`src/pages/_app.tsx`	Fixed meta tag to use self-closing syntax
`src/components/UserProfile/ProfileHeader/index.tsx`	Fixed span element to use self-closing syntax
`src/components/UserList/PlexImportModal.tsx`	Fixed toggle switch span elements to use self-closing syntax
`src/components/UserList/JellyfinImportModal.tsx`	Fixed toggle switch span elements to use self-closing syntax
`src/components/Settings/SettingsLogs/index.tsx`	Fixed empty Table.TH element to use self-closing syntax
`src/components/Settings/SettingsJobsCache/index.tsx`	Fixed multiple empty Table.TH elements to use self-closing syntax
`src/components/RequestModal/TvRequestModal.tsx`	Fixed toggle switch span elements to use self-closing syntax
`src/components/RequestModal/CollectionRequestModal.tsx`	Fixed toggle switch span elements to use self-closing syntax
`src/components/Login/index.tsx`	Fixed divider div elements to use self-closing syntax
`src/components/Login/LocalLogin.tsx`	Fixed flex-grow div element to use self-closing syntax
`src/components/Login/JellyfinLogin.tsx`	Fixed flex-grow div element to use self-closing syntax
`src/components/Layout/Sidebar/index.tsx`	Fixed backdrop div element to use self-closing syntax
`src/components/GenreCard/index.tsx`	Fixed placeholder div element to use self-closing syntax
`src/components/Discover/CreateSlider/index.tsx`	Fixed flex-1 div element to use self-closing syntax
`src/components/Common/SlideCheckbox/index.tsx`	Fixed toggle switch span elements to use self-closing syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fallenbagel

LGTM

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/seerr-team/seerr](https://github.com/seerr-team/seerr) | minor | `v3.0.1` → `v3.1.0` | | [seerr-team/seerr](https://github.com/seerr-team/seerr) | minor | `v3.0.1` → `v3.1.0` | --- ### Release Notes <details> <summary>seerr-team/seerr (ghcr.io/seerr-team/seerr)</summary> ### [`v3.1.0`](https://github.com/seerr-team/seerr/releases/tag/v3.1.0) [Compare Source](seerr-team/seerr@v3.0.1...v3.1.0) ##### 🛡️ Security - Patch [CVE-2026-27707](GHSA-rc4w-7m3r-c2f7) - Unauthenticated account registration on Plex-configured Seerr instances via Jellyfin authentication endpoint - ([4ae2068](seerr-team/seerr@4ae2068)) - Patch [CVE-2026-27793](GHSA-f7xw-jcqr-57hp) - Broken Object-Level Authorization in User Profile Endpoint Exposes Third-Party Notification Credentials - ([4f089b2](seerr-team/seerr@4f089b2)) - Patch [CVE-2026-27792](GHSA-gx3h-3jg5-q65f) - Missing authentication on pushSubscription endpoints - ([946bdecec](seerr-team/seerr@946bdec)) ##### 🚀 Features - *(helm)* Use an existing PVC as config volume ([#2447](seerr-team/seerr#2447)) - ([8f0c904](seerr-team/seerr@8f0c904)) - *(servarr-api)* Make Servarr API request timeout configurable ([#2556](seerr-team/seerr#2556)) - ([3bcb4da](seerr-team/seerr@3bcb4da)) - Self-host font for better privacy ([#2540](seerr-team/seerr#2540)) - ([10ea21b](seerr-team/seerr@10ea21b)) ##### 🐛 Bug Fixes - *(helm)* Add "v" as prefix for appVersion tag ([#2445](seerr-team/seerr#2445)) - ([04b9d87](seerr-team/seerr@04b9d87)) - *(jellyfin-scanner)* Include unmatched seasons in processable seasons ([#2538](seerr-team/seerr#2538)) - ([68f56d2](seerr-team/seerr@68f56d2)) - *(link-account)* Fix error-message override ([#2547](seerr-team/seerr#2547)) - ([b843be0](seerr-team/seerr@b843be0)) - *(plex-scanner)* Add TVDb to TMDB fallback in plex scanner ([#2537](seerr-team/seerr#2537)) - ([7c60a5c](seerr-team/seerr@7c60a5c)) - *(radarr)* Trigger search for existing monitored movies without files ([#2391](seerr-team/seerr#2391)) - ([55776ea](seerr-team/seerr@55776ea)) - *(servarr)* Increase default API timeout from 5000ms to 10000ms ([#2442](seerr-team/seerr#2442)) - ([b499976](seerr-team/seerr@b499976)) - *(sonarr)* Use configured metadata provider for season filtering ([#2516](seerr-team/seerr#2516)) - ([5013d1d](seerr-team/seerr@5013d1d)) - *(watch-data)* Use sentinel values to avoid invalid SQL syntax ([#2552](seerr-team/seerr#2552)) - ([947f70c](seerr-team/seerr@947f70c)) - *(watchlist-sync)* Correct permission typo for TV auto requests ([#2488](seerr-team/seerr#2488)) - ([e0e4b6f](seerr-team/seerr@e0e4b6f)) - Preserve blocklist on media deletion & optimise watchlist-sync ([#2478](seerr-team/seerr#2478)) - ([9da8bb6](seerr-team/seerr@9da8bb6)) ##### 🚜 Refactor - *(tailwind)* Replace deprecated tailwind utilities ([#2542](seerr-team/seerr#2542)) - ([f42a4ec](seerr-team/seerr@f42a4ec)) ##### 📖 Documentation - *(synology)* Add installation guide via SynoCommunity ([#2503](seerr-team/seerr#2503)) - ([0e636a3](seerr-team/seerr@0e636a3)) - *(truenas)* Update install/migration guide ([#2491](seerr-team/seerr#2491)) - ([dc1734d](seerr-team/seerr@dc1734d)) - *(unraid)* Improve unraid migration guide ([#2470](seerr-team/seerr#2470)) - ([5e64d49](seerr-team/seerr@5e64d49)) - Update Unraid install and migration guides with dual permission methods ([#2532](seerr-team/seerr#2532)) - ([a0d0eb1](seerr-team/seerr@a0d0eb1)) - Add a warning in migration-guide for third party installation ([#2527](seerr-team/seerr#2527)) - ([7e9dff3](seerr-team/seerr@7e9dff3)) - Remove double quotes (") from DB\_HOST environment variable ([#2514](seerr-team/seerr#2514)) - ([fa905be](seerr-team/seerr@fa905be)) - Add Unraid installation and migration guide ([#2440](seerr-team/seerr#2440)) - ([b6a9132](seerr-team/seerr@b6a9132)) - Fix migration guide title ([#2425](seerr-team/seerr#2425)) - ([39ae32f](seerr-team/seerr@39ae32f)) ##### ⚡ Performance - Add missing indexes on all foreign key columns ([#2461](seerr-team/seerr#2461)) - ([c6bcfe0](seerr-team/seerr@c6bcfe0)) ##### ⚙️ Miscellaneous Tasks - *(changelog)* Fix changelog template ([#2431](seerr-team/seerr#2431)) - ([c2977f6](seerr-team/seerr@c2977f6)) - *(eslint)* Add react/self-closing-comp ([#2563](seerr-team/seerr#2563)) - ([cd8b386](seerr-team/seerr@cd8b386)) - *(github)* Add docs and maintenance issue templates ([#2467](seerr-team/seerr#2467)) - ([cf4883a](seerr-team/seerr@cf4883a)) - *(helm)* Add GatewayAPI route support to helm chart ([#2544](seerr-team/seerr#2544)) - ([3a42f59](seerr-team/seerr@3a42f59)) - *(helm)* Update ghcr.io/seerr-team/seerr ( 3.0.0 → 3.0.1 ) \[skip-ci] ([#2441](seerr-team/seerr#2441)) - ([87fb0df](seerr-team/seerr@87fb0df)) - *(husky)* Fixed husky commit message from bash/zsh syntax to sh syntax ([#2572](seerr-team/seerr#2572)) - ([a00c9e5](seerr-team/seerr@a00c9e5)) - *(release)* Prepare ${TAG\_VERSION} - ([94a70bb](seerr-team/seerr@94a70bb)) - Updated the Contributing and Security guides to reflect our current practices ([#2579](seerr-team/seerr#2579)) - ([0d40a42](seerr-team/seerr@0d40a42)) - Disable nextjs telemetry ([#2517](seerr-team/seerr#2517)) - ([cecdd63](seerr-team/seerr@cecdd63)) - Update contributing guide regarding Automated AI Agent ([#2518](seerr-team/seerr#2518)) - ([880fbc9](seerr-team/seerr@880fbc9)) - Remove discord notification from release ([#2501](seerr-team/seerr#2501)) - ([fba20c1](seerr-team/seerr@fba20c1)) - Add create-tag workflow to streamline release process ([#2493](seerr-team/seerr#2493)) - ([06e5eb0](seerr-team/seerr@06e5eb0)) - Update concurrency logic ([#2481](seerr-team/seerr#2481)) - ([4939f13](seerr-team/seerr@4939f13)) - Add semantic-pr workflow to enforce conventional commits ([#2472](seerr-team/seerr#2472)) - ([5e57fdc](seerr-team/seerr@5e57fdc)) ##### New Contributors ❤️ - [@caillou](https://github.com/caillou) made their first contribution - [@Kenshin9977](https://github.com/Kenshin9977) made their first contribution - [@MagicLegend](https://github.com/MagicLegend) made their first contribution - [@wiiaam](https://github.com/wiiaam) made their first contribution - [@mjonkus](https://github.com/mjonkus) made their first contribution - [@nova-api](https://github.com/nova-api) made their first contribution - [@mreid-tt](https://github.com/mreid-tt) made their first contribution - [@DataBitz](https://github.com/DataBitz) made their first contribution - [@Hyperion2220](https://github.com/Hyperion2220) made their first contribution - [@blassley](https://github.com/blassley) made their first contribution - [@JanKleine](https://github.com/JanKleine) made their first contribution - [@koiralasandesh](https://github.com/koiralasandesh) made their first contribution </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4284 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

caillou added 2 commits February 23, 2026 17:41

chore(eslint): add react/self-closing-comp

26305f7

chore(eslint): autofix files after lint rule update

e920629

caillou requested a review from a team as a code owner February 23, 2026 16:49

fallenbagel requested a review from Copilot February 23, 2026 21:51

gauthier-th approved these changes Feb 23, 2026

View reviewed changes

Copilot started reviewing on behalf of fallenbagel February 23, 2026 21:52 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

fallenbagel approved these changes Feb 23, 2026

View reviewed changes

gauthier-th merged commit cd8b386 into seerr-team:develop Feb 23, 2026
14 checks passed

caillou deleted the eslint-self-closing branch February 24, 2026 01:28

gwlsn pushed a commit to gwlsn/seerr that referenced this pull request Mar 21, 2026

chore(eslint): add react/self-closing-comp (seerr-team#2563)

2595d36

lucianchauvin pushed a commit to lucianchauvin/jellyseerr that referenced this pull request Apr 20, 2026

chore(eslint): add react/self-closing-comp (seerr-team#2563)

7d49a92

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(eslint): add react/self-closing-comp#2563

chore(eslint): add react/self-closing-comp#2563
gauthier-th merged 2 commits intoseerr-team:developfrom
caillou:eslint-self-closing

caillou commented Feb 23, 2026

Uh oh!

gauthier-th left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

fallenbagel left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

caillou commented Feb 23, 2026

Description

Checklist:

Uh oh!

gauthier-th left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

fallenbagel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants