fix(link-account): fix error-message override

[caillou]

Description

This is a bug that was identified by coderabbitai on a separate PR.

This was the report:

src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/index.tsx (1)
102-111: ⚠️ Potential issue | 🔴 Critical

Critical: Duplicate setError call masks specific error messages.

Line 110 unconditionally overwrites all error messages with the generic "errorUnknown" message, preventing users from seeing the helpful error messages for unauthorized (401) or duplicate account (422) scenarios. This defeats the purpose of the specific error handling above it.

How Has This Been Tested?

I tested by trying to link an account and then closing the pop-up. This generates an unknown error.

Unfortunately, I don't know how to generate a 401 or a 422 error.

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Refactor
  • Improved error handling code structure in user account settings to enhance maintainability and code clarity.

[coderabbitai]

📝 Walkthrough

Walkthrough

Error handling logic in a user linked accounts settings component is refactored from sequential if-else conditions into a switch statement structure, consolidating status code checks (401, 422) with consistent behavior maintained throughout.

Changes

Cohort / File(s)	Summary
Error Handling Refactor src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/index.tsx	Consolidates error handling from if-else chain to switch statement for status codes 401, 422, and default case with no behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through tangled code,
Where if-and-else block the road,
With switch in hand, she clears the way—
Same logic flows, but cleaner today! 🐰✨

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title refers to fixing an error-message override issue in the link-account functionality, which matches the core bug fix in the changeset where duplicate setError calls were consolidated.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/index.tsx (1)

102-113: Good fix - switch statement prevents the error message override bug.

The refactor correctly ensures only one setError call executes per error path. However, e is typed as unknown in TypeScript catch blocks, and accessing e?.response?.status without type narrowing is not type-safe.

Consider using axios's built-in type guard for proper type safety:

,

♻️ Suggested improvement using axios type guard

+import { isAxiosError } from 'axios';

     } catch (e) {
-      switch (e?.response?.status) {
-        case 401:
-          setError(intl.formatMessage(messages.plexErrorUnauthorized));
-          break;
-        case 422:
-          setError(intl.formatMessage(messages.plexErrorExists));
-          break;
-        default:
-          setError(intl.formatMessage(messages.errorUnknown));
+      if (isAxiosError(e)) {
+        switch (e.response?.status) {
+          case 401:
+            setError(intl.formatMessage(messages.plexErrorUnauthorized));
+            break;
+          case 422:
+            setError(intl.formatMessage(messages.plexErrorExists));
+            break;
+          default:
+            setError(intl.formatMessage(messages.errorUnknown));
+        }
+      } else {
+        setError(intl.formatMessage(messages.errorUnknown));
       }
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/index.tsx`
around lines 102 - 113, The catch block uses an untyped catch variable `e` and
directly accesses `e?.response?.status`; change the catch to narrow the error
using axios' type guard (axios.isAxiosError) or a custom type guard before
reading `response.status`, e.g., in the catch implement `if
(axios.isAxiosError(e) && e.response) { switch (e.response.status) { ...
setError(intl.formatMessage(messages.plexErrorUnauthorized)) ... } } else {
setError(intl.formatMessage(messages.errorUnknown)) }`, and add the axios import
if missing; keep the existing switch and
`setError`/`intl.formatMessage(messages.*)` calls intact.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/index.tsx`:
- Around line 102-113: The catch block uses an untyped catch variable `e` and
directly accesses `e?.response?.status`; change the catch to narrow the error
using axios' type guard (axios.isAxiosError) or a custom type guard before
reading `response.status`, e.g., in the catch implement `if
(axios.isAxiosError(e) && e.response) { switch (e.response.status) { ...
setError(intl.formatMessage(messages.plexErrorUnauthorized)) ... } } else {
setError(intl.formatMessage(messages.errorUnknown)) }`, and add the axios import
if missing; keep the existing switch and
`setError`/`intl.formatMessage(messages.*)` calls intact.

[Copilot]

Pull request overview

This PR fixes a critical bug where a duplicate setError() call was unconditionally overwriting specific HTTP error messages with a generic "unknown error" message. The fix refactors the error handling from an if-else chain to a switch statement and removes the duplicate call that was masking error details for 401 (unauthorized) and 422 (duplicate account) responses.

Changes:

• Removed duplicate setError() call that was masking specific error messages
• Refactored error handling from if-else chain to switch statement

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[0xSysR3ll]

Nice fix ! Thanks !

[fallenbagel]

Nice fix ! Thanks !

Success!