fix(watch-data): use sentinel values to avoid invalid SQL syntax

[0xSysR3ll]

Description

When Tautulli returns no watchers, the query used IN (), which is invalid.
This PR fixes this by pushing sentinel values so the list is never empty and no real rows match.

• Fixes #XXXX

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Refactor
  • Improved database query reliability for user information lookups to ensure consistent handling across all data retrieval scenarios.

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactored database query patterns in Plex user lookups across two route handlers. Precomputed plexIds and plexEmails arrays replace inline query mapping. Added sentinel values to prevent empty IN clauses in SQL queries.

Changes

Cohort / File(s)	Summary
Tautulli Watch User Lookups server/routes/media.ts	Precomputed plexIds array from watchUsers.user_id with sentinel value (-1) appended when empty; replaced inline mapping in both standard and 4K watch data query paths.
Plex User Workflow server/routes/settings/index.ts	Precomputed plexIds (from plexUser.id) and plexEmails (normalized to lowercase) arrays with sentinel values ('-1' for ids, '@' for emails) when empty; refactored both user lookup and existingUsers queries to use precomputed arrays via IN conditions instead of inline mapping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Array-bound queries, precomputed with care,
Sentinel sentries guard the IN clause's fair,
No more inline maps, just arrays so clean,
Empty or full, robust routines!
A rabbit hops on, the code runs with glee! ✨

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: using sentinel values to prevent invalid SQL syntax in watch-data queries.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR prevents invalid SQL (IN ()) when building TypeORM IN (:...ids) queries with potentially-empty arrays (e.g., when Tautulli returns no watchers), by ensuring query parameter arrays are never empty.

Changes:

• Add sentinel values to Plex/Tautulli ID/email arrays so IN (:...param) never receives an empty list.
• Refactor query parameter construction to reuse precomputed plexIds / plexEmails arrays.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
server/routes/settings/index.ts	Ensures the /settings/plex/users existing-user lookup doesn’t generate IN () when Plex returns no eligible users.
server/routes/media.ts	Ensures the /:id/watch_data user lookup doesn’t generate IN () when Tautulli returns no watchers (both SDR and 4K paths).

Comments suppressed due to low confidence (2)

server/routes/settings/index.ts:501

• user.plexId is stored as an integer (number | null), but here plexIds is built from Plex's string IDs and the sentinel is pushed as a string. Consider normalizing plexIds to number[] up-front (e.g., parseInt once) and using a numeric sentinel (e.g., -1) to keep parameter types aligned with the DB column and avoid relying on implicit casting.

      const plexIds = plexUsers.map((plexUser) => plexUser.id);
      const plexEmails = plexUsers.map((plexUser) =>
        plexUser.email.toLowerCase()
      );
      if (!plexIds.length) plexIds.push('-1');

server/routes/settings/index.ts:506

• PR title/description focuses on watch_data, but this hunk also changes the /settings/plex/users query behavior. Please either update the PR description/title to mention this additional fix, or split it into a separate PR so the scope matches what reviewers expect.

      const existingUsers = await qb
        .where('user.plexId IN (:...plexIds)', { plexIds })
        .orWhere('user.email IN (:...plexEmails)', { plexEmails })

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[fallenbagel]

Success!