Skip to content

chore: updated the Contributing and Security guides to reflect our current practices#2579

Merged
0xSysR3ll merged 2 commits intodevelopfrom
fix/security.md
Feb 27, 2026
Merged

chore: updated the Contributing and Security guides to reflect our current practices#2579
0xSysR3ll merged 2 commits intodevelopfrom
fix/security.md

Conversation

@M0NsTeRRR
Copy link
Copy Markdown
Member

@M0NsTeRRR M0NsTeRRR commented Feb 25, 2026

Description

chore: updated the Contributing and Security guides to reflect our cu…

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

  • Documentation
    • Refined contribution guidelines: updated Git workflow to use switch-based commands, clarified rebasing guidance, and shifted Conventional Commits enforcement to PR titles.
    • Added an AI assistance notice to security guidance: mandatory disclosure for AI-assisted contributions, examples of acceptable disclosures, and review expectations for such contributions.

…rrent practices

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
@M0NsTeRRR M0NsTeRRR requested a review from a team as a code owner February 25, 2026 22:35
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 25, 2026

📝 Walkthrough

Walkthrough

Updates to CONTRIBUTING.md replace git checkout with git switch, shift Conventional Commits enforcement from individual commits to PR titles, and clarify rebase guidance. SECURITY.md adds an "AI Assistance Notice" section requiring disclosure and review expectations for AI-assisted contributions.

Changes

Cohort / File(s) Summary
Git workflow & contribution guidance
CONTRIBUTING.md
Replaces git checkout examples with git switch, changes Conventional Commits requirement to apply to PR titles (non-compliant PRs won't be merged), and updates rebase phrasing to "rebase your branch to the latest develop". Minor wording and example updates.
AI assistance policy addition
SECURITY.md
Adds an "AI Assistance Notice" section detailing mandatory disclosure of AI-generated contributions, examples of acceptable disclosures, and review/quality expectations for maintainers and contributors.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • gauthier-th
  • fallenbagel
  • sudo-kraken

Poem

🐰 I hopped through lines of docs with care,
Swapped checkouts for switches in the air,
I whispered of AI, "Please tell us true,"
Rebasing branches, tidy and new,
A tiny carrot for reviewers too. 🥕

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updates to CONTRIBUTING.md and SECURITY.md to reflect current practices, which aligns with the actual file modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
CONTRIBUTING.md (1)

45-46: ⚠️ Potential issue | 🟡 Minor

Typo: missing apostrophe in "maintainers job".

Same issue as in SECURITY.md — "maintainers" should be "maintainer's".

✏️ Proposed fix
-It isn't a maintainers job to review a PR so broken that it requires
+It isn't a maintainer's job to review a PR so broken that it requires
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CONTRIBUTING.md` around lines 45 - 46, Replace the typo "maintainers job" in
CONTRIBUTING.md with the possessive "maintainer's job"; locate the sentence
containing "isn't a maintainers job to review a PR so broken that it requires
significant rework to be acceptable." and change it to "isn't a maintainer's job
to review a PR so broken that it requires significant rework to be acceptable."
to match the fix applied in SECURITY.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CONTRIBUTING.md`:
- Around line 182-185: Replace the grammatically incorrect phrase "Switch the
`develop` branch" with "Switch to the `develop` branch" in the CONTRIBUTING.md
sentence that begins with "3. Switch the `develop` branch and create the
original database..." so the instruction reads "Switch to the `develop` branch
and create the original database..." ensuring consistency with the `git switch`
wording used elsewhere.
- Around line 133-134: Replace the wording "rebase your commit" with "rebase
your branch" and update the second sentence to refer to "your branch" as well
(e.g., "It is your responsibility to keep your branch up-to-date. Your work will
not be merged unless it is rebased off the latest `develop` branch.") so both
lines in CONTRIBUTING.md consistently reference rebasing the branch rather than
a singular commit.

In `@SECURITY.md`:
- Around line 51-52: Fix the typo in SECURITY.md by changing "maintainers job"
to "maintainer's job"—locate the phrase "maintainers job" in the SECURITY.md
content and insert the missing apostrophe so it reads "maintainer's job".
- Around line 11-54: Remove the duplicated AI disclosure prose under the "AI
Assistance Notice" section in SECURITY.md (the long paragraph block after the
callout) and replace it with a single sentence cross-reference to
CONTRIBUTING.md pointing readers there for the full AI disclosure and PR
guidance; keep the existing callout block titled "AI Assistance Notice" (the
short summary/callout at the top) for awareness, and ensure the new sentence
clearly directs readers to CONTRIBUTING.md for contributor-facing AI-disclosure
rules and examples.

---

Outside diff comments:
In `@CONTRIBUTING.md`:
- Around line 45-46: Replace the typo "maintainers job" in CONTRIBUTING.md with
the possessive "maintainer's job"; locate the sentence containing "isn't a
maintainers job to review a PR so broken that it requires significant rework to
be acceptable." and change it to "isn't a maintainer's job to review a PR so
broken that it requires significant rework to be acceptable." to match the fix
applied in SECURITY.md.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55776ea and 2cbedda.

📒 Files selected for processing (2)
  • CONTRIBUTING.md
  • SECURITY.md

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread SECURITY.md
Comment thread SECURITY.md
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
CONTRIBUTING.md (1)

133-133: Nit: prefer "onto" over "to" for idiomatic git rebase wording.

"Rebase … onto" is the standard phrasing (matching git rebase --onto and official Git documentation), whereas "rebase … to" is non-standard.

✏️ Proposed fix
-- Always rebase your branch to the latest `develop` branch.
+- Always rebase your branch onto the latest `develop` branch.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CONTRIBUTING.md` at line 133, Change the phrasing "Always rebase your branch
to the latest `develop` branch." to use idiomatic Git wording: "Always rebase
your branch onto the latest `develop` branch." Update the sentence in the
CONTRIBUTING guideline so it matches standard Git documentation and the `git
rebase --onto` terminology.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@CONTRIBUTING.md`:
- Line 133: Change the phrasing "Always rebase your branch to the latest
`develop` branch." to use idiomatic Git wording: "Always rebase your branch onto
the latest `develop` branch." Update the sentence in the CONTRIBUTING guideline
so it matches standard Git documentation and the `git rebase --onto`
terminology.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cbedda and 5c2c871.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

@M0NsTeRRR M0NsTeRRR changed the title chore: updated the Contributing and Security guides to reflect our cu… chore: updated the Contributing and Security guides to reflect our current practices Feb 26, 2026
@0xSysR3ll 0xSysR3ll merged commit 0d40a42 into develop Feb 27, 2026
11 of 12 checks passed
@0xSysR3ll 0xSysR3ll deleted the fix/security.md branch February 27, 2026 14:23
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Feb 27, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/seerr-team/seerr](https://github.com/seerr-team/seerr) | minor | `v3.0.1` → `v3.1.0` |
| [seerr-team/seerr](https://github.com/seerr-team/seerr) | minor | `v3.0.1` → `v3.1.0` |

---

### Release Notes

<details>
<summary>seerr-team/seerr (ghcr.io/seerr-team/seerr)</summary>

### [`v3.1.0`](https://github.com/seerr-team/seerr/releases/tag/v3.1.0)

[Compare Source](seerr-team/seerr@v3.0.1...v3.1.0)

##### 🛡️ Security

- Patch [CVE-2026-27707](GHSA-rc4w-7m3r-c2f7)  - Unauthenticated account registration on Plex-configured Seerr instances via Jellyfin authentication endpoint  - ([4ae2068](seerr-team/seerr@4ae2068))
- Patch [CVE-2026-27793](GHSA-f7xw-jcqr-57hp) - Broken Object-Level Authorization in User Profile Endpoint Exposes Third-Party Notification Credentials - ([4f089b2](seerr-team/seerr@4f089b2))
- Patch [CVE-2026-27792](GHSA-gx3h-3jg5-q65f)  - Missing authentication on pushSubscription endpoints  - ([946bdecec](seerr-team/seerr@946bdec))

##### 🚀 Features

- *(helm)* Use an existing PVC as config volume ([#&#8203;2447](seerr-team/seerr#2447)) - ([8f0c904](seerr-team/seerr@8f0c904))
- *(servarr-api)* Make Servarr API request timeout configurable ([#&#8203;2556](seerr-team/seerr#2556)) - ([3bcb4da](seerr-team/seerr@3bcb4da))
- Self-host font for better privacy ([#&#8203;2540](seerr-team/seerr#2540)) - ([10ea21b](seerr-team/seerr@10ea21b))

##### 🐛 Bug Fixes

- *(helm)* Add "v" as prefix for appVersion tag ([#&#8203;2445](seerr-team/seerr#2445)) - ([04b9d87](seerr-team/seerr@04b9d87))
- *(jellyfin-scanner)* Include unmatched seasons in processable seasons ([#&#8203;2538](seerr-team/seerr#2538)) - ([68f56d2](seerr-team/seerr@68f56d2))
- *(link-account)* Fix error-message override ([#&#8203;2547](seerr-team/seerr#2547)) - ([b843be0](seerr-team/seerr@b843be0))
- *(plex-scanner)* Add TVDb to TMDB fallback in plex scanner ([#&#8203;2537](seerr-team/seerr#2537)) - ([7c60a5c](seerr-team/seerr@7c60a5c))
- *(radarr)* Trigger search for existing monitored movies without files ([#&#8203;2391](seerr-team/seerr#2391)) - ([55776ea](seerr-team/seerr@55776ea))
- *(servarr)* Increase default API timeout from 5000ms to 10000ms ([#&#8203;2442](seerr-team/seerr#2442)) - ([b499976](seerr-team/seerr@b499976))
- *(sonarr)* Use configured metadata provider for season filtering ([#&#8203;2516](seerr-team/seerr#2516)) - ([5013d1d](seerr-team/seerr@5013d1d))
- *(watch-data)* Use sentinel values to avoid invalid SQL syntax ([#&#8203;2552](seerr-team/seerr#2552)) - ([947f70c](seerr-team/seerr@947f70c))
- *(watchlist-sync)* Correct permission typo for TV auto requests ([#&#8203;2488](seerr-team/seerr#2488)) - ([e0e4b6f](seerr-team/seerr@e0e4b6f))
- Preserve blocklist on media deletion & optimise watchlist-sync ([#&#8203;2478](seerr-team/seerr#2478)) - ([9da8bb6](seerr-team/seerr@9da8bb6))

##### 🚜 Refactor

- *(tailwind)* Replace deprecated tailwind utilities ([#&#8203;2542](seerr-team/seerr#2542)) - ([f42a4ec](seerr-team/seerr@f42a4ec))

##### 📖 Documentation

- *(synology)* Add installation guide via SynoCommunity ([#&#8203;2503](seerr-team/seerr#2503)) - ([0e636a3](seerr-team/seerr@0e636a3))
- *(truenas)* Update install/migration guide ([#&#8203;2491](seerr-team/seerr#2491)) - ([dc1734d](seerr-team/seerr@dc1734d))
- *(unraid)* Improve unraid migration guide  ([#&#8203;2470](seerr-team/seerr#2470)) - ([5e64d49](seerr-team/seerr@5e64d49))
- Update Unraid install and migration guides with dual permission methods ([#&#8203;2532](seerr-team/seerr#2532)) - ([a0d0eb1](seerr-team/seerr@a0d0eb1))
- Add a warning in migration-guide for third party installation ([#&#8203;2527](seerr-team/seerr#2527)) - ([7e9dff3](seerr-team/seerr@7e9dff3))
- Remove double quotes (") from DB\_HOST environment variable ([#&#8203;2514](seerr-team/seerr#2514)) - ([fa905be](seerr-team/seerr@fa905be))
- Add Unraid installation and migration guide ([#&#8203;2440](seerr-team/seerr#2440)) - ([b6a9132](seerr-team/seerr@b6a9132))
- Fix migration guide title ([#&#8203;2425](seerr-team/seerr#2425)) - ([39ae32f](seerr-team/seerr@39ae32f))

##### ⚡ Performance

- Add missing indexes on all foreign key columns ([#&#8203;2461](seerr-team/seerr#2461)) - ([c6bcfe0](seerr-team/seerr@c6bcfe0))

##### ⚙️ Miscellaneous Tasks

- *(changelog)* Fix changelog template ([#&#8203;2431](seerr-team/seerr#2431)) - ([c2977f6](seerr-team/seerr@c2977f6))
- *(eslint)* Add react/self-closing-comp ([#&#8203;2563](seerr-team/seerr#2563)) - ([cd8b386](seerr-team/seerr@cd8b386))
- *(github)* Add docs and maintenance issue templates ([#&#8203;2467](seerr-team/seerr#2467)) - ([cf4883a](seerr-team/seerr@cf4883a))
- *(helm)* Add GatewayAPI route support to helm chart ([#&#8203;2544](seerr-team/seerr#2544)) - ([3a42f59](seerr-team/seerr@3a42f59))
- *(helm)* Update ghcr.io/seerr-team/seerr ( 3.0.0 → 3.0.1 ) \[skip-ci] ([#&#8203;2441](seerr-team/seerr#2441)) - ([87fb0df](seerr-team/seerr@87fb0df))
- *(husky)* Fixed husky commit message from bash/zsh syntax to sh syntax ([#&#8203;2572](seerr-team/seerr#2572)) - ([a00c9e5](seerr-team/seerr@a00c9e5))
- *(release)* Prepare ${TAG\_VERSION} - ([94a70bb](seerr-team/seerr@94a70bb))
- Updated the Contributing and Security guides to reflect our current practices ([#&#8203;2579](seerr-team/seerr#2579)) - ([0d40a42](seerr-team/seerr@0d40a42))
- Disable nextjs telemetry ([#&#8203;2517](seerr-team/seerr#2517)) - ([cecdd63](seerr-team/seerr@cecdd63))
- Update contributing guide regarding Automated AI Agent ([#&#8203;2518](seerr-team/seerr#2518)) - ([880fbc9](seerr-team/seerr@880fbc9))
- Remove discord notification from release ([#&#8203;2501](seerr-team/seerr#2501)) - ([fba20c1](seerr-team/seerr@fba20c1))
- Add create-tag workflow to streamline release process ([#&#8203;2493](seerr-team/seerr#2493)) - ([06e5eb0](seerr-team/seerr@06e5eb0))
- Update concurrency logic ([#&#8203;2481](seerr-team/seerr#2481)) - ([4939f13](seerr-team/seerr@4939f13))
- Add semantic-pr workflow to enforce conventional commits ([#&#8203;2472](seerr-team/seerr#2472)) - ([5e57fdc](seerr-team/seerr@5e57fdc))

##### New Contributors ❤️

- [@&#8203;caillou](https://github.com/caillou) made their first contribution
- [@&#8203;Kenshin9977](https://github.com/Kenshin9977) made their first contribution
- [@&#8203;MagicLegend](https://github.com/MagicLegend) made their first contribution
- [@&#8203;wiiaam](https://github.com/wiiaam) made their first contribution
- [@&#8203;mjonkus](https://github.com/mjonkus) made their first contribution
- [@&#8203;nova-api](https://github.com/nova-api) made their first contribution
- [@&#8203;mreid-tt](https://github.com/mreid-tt) made their first contribution
- [@&#8203;DataBitz](https://github.com/DataBitz) made their first contribution
- [@&#8203;Hyperion2220](https://github.com/Hyperion2220) made their first contribution
- [@&#8203;blassley](https://github.com/blassley) made their first contribution
- [@&#8203;JanKleine](https://github.com/JanKleine) made their first contribution
- [@&#8203;koiralasandesh](https://github.com/koiralasandesh) made their first contribution<!-- generated by git-cliff -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNS43IiwidXBkYXRlZEluVmVyIjoiNDMuMjUuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiaW1hZ2UiXX0=-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4284
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
gwlsn pushed a commit to gwlsn/seerr that referenced this pull request Mar 21, 2026
lucianchauvin pushed a commit to lucianchauvin/jellyseerr that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants