Skip to content

[accesscontrol] Add dependency dag#258

Merged
udpatil merged 8 commits into2.0.0betafrom
dependency-dag
Sep 27, 2022
Merged

[accesscontrol] Add dependency dag#258
udpatil merged 8 commits into2.0.0betafrom
dependency-dag

Conversation

@udpatil
Copy link
Collaborator

@udpatil udpatil commented Sep 23, 2022

No description provided.

Base automatically changed from bweng-acl-module-keepers to 2.0.0beta September 23, 2022 16:57
@udpatil udpatil marked this pull request as ready for review September 24, 2022 19:59
BrandonWeng
BrandonWeng reviewed Sep 25, 2022
View reviewed changes
Copy link
Contributor

@BrandonWeng BrandonWeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change, just have some questions

go.mod Outdated

replace (
github.com/cosmos/cosmos-sdk => github.com/sei-protocol/sei-cosmos v0.1.66
github.com/cosmos/cosmos-sdk => ../sei-cosmos // github.com/sei-protocol/sei-cosmos v0.1.20
Copy link
Contributor

@BrandonWeng BrandonWeng Sep 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to revert this before merging

app/graph.go Outdated
}
}
}
case acltypes.AccessType_WRITE:
Copy link
Contributor

@BrandonWeng BrandonWeng Sep 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's also AccessType_ANY, though I think that might be similar to Accesstype_WRITE since it should just block on previous reads and writes

Copy link
Collaborator Author

@udpatil udpatil Sep 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll modify it to handle this as well, I was initially assuming the 0 proto values were being treated as basically invalid but this is a more graceful way of handling it.

Copy link
Collaborator Author

@udpatil udpatil Sep 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait I double checked and it has access type UNKNOWN. Do we want to handle it as if it's ANY (and/or refactor to ANY?)

Copy link
Contributor

@BrandonWeng BrandonWeng Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think they should be the same thing. If you feel that ANY is more clear then I can make a PR to change it

codchen
codchen reviewed Sep 26, 2022
View reviewed changes
@BrandonWeng BrandonWeng mentioned this pull request Sep 26, 2022
Merged
BrandonWeng
BrandonWeng approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@BrandonWeng BrandonWeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the change

@udpatil udpatil merged commit e573b4a into 2.0.0beta Sep 27, 2022
@udpatil udpatil deleted the dependency-dag branch September 27, 2022 16:09
philipsu522 pushed a commit that referenced this pull request Oct 17, 2022
@udpatil @philipsu522
[accesscontrol] Add dependency dag (#258)
d3a00c1 
* [accesscontrol] Add dependency dag

* Add basic test for dependency dag

* lint

* refactor graph edge and completion signals

* process seq for any dag errors

* fmt

* mod tidy

* update sei-cosmos
udpatil added a commit that referenced this pull request Oct 27, 2022
@udpatil
[accesscontrol] Add dependency dag (#258)
9af1818 
* [accesscontrol] Add dependency dag

* Add basic test for dependency dag

* lint

* refactor graph edge and completion signals

* process seq for any dag errors

* fmt

* mod tidy

* update sei-cosmos
udpatil added a commit that referenced this pull request Oct 27, 2022
@udpatil
[accesscontrol] Add dependency dag (#258)
2adb16b 
* [accesscontrol] Add dependency dag

* Add basic test for dependency dag

* lint

* refactor graph edge and completion signals

* process seq for any dag errors

* fmt

* mod tidy

* update sei-cosmos
udpatil added a commit that referenced this pull request Oct 28, 2022
@udpatil
[accesscontrol] Add dependency dag (#258)
eea3e69 
* [accesscontrol] Add dependency dag

* Add basic test for dependency dag

* lint

* refactor graph edge and completion signals

* process seq for any dag errors

* fmt

* mod tidy

* update sei-cosmos
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
[accesscontrol] Add dependency dag (#258)
27056e5 
* [accesscontrol] Add dependency dag

* Add basic test for dependency dag

* lint

* refactor graph edge and completion signals

* process seq for any dag errors

* fmt

* mod tidy

* update sei-cosmos
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
[accesscontrol] Add dependency dag (#258)
6721845 
* [accesscontrol] Add dependency dag

* Add basic test for dependency dag

* lint

* refactor graph edge and completion signals

* process seq for any dag errors

* fmt

* mod tidy

* update sei-cosmos
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
Revert "[accesscontrol] Add dependency dag (#258)"
2167370 
This reverts commit 6721845.
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
Revert "Rebase 2.0.0beta Parallelization onto master" (#357)
977c1d1 
* Revert "Update Antehandler resource depedencies  (#354)"

This reverts commit 6c672fb.

* Revert "update staking validation identifier (#353)"

This reverts commit 8a17c26.

* Revert "Update Oracle Parallel Tx Resource Identifiers  (#351)"

This reverts commit c9229ab.

* Revert "Update IdentifierTemplate for TokenFactory  (#350)"

This reverts commit e81fc93.

* Revert "[loadtest] Loadtest fixes"

This reverts commit 68bfab5.

* Revert "fix unit tests"

This reverts commit 49eb809.

* Revert "Fix Bank Send Unit Tests  (#348)"

This reverts commit 9c11837.

* Revert "integrate with sei-cosmos changes (#347)"

This reverts commit e1b1790.

* Revert "Validate Concurrent Messages + Update BankSend  (#345)"

This reverts commit e4d3176.

* Revert "Add concurrency for BurnMsg and MintMsg (#331)"

This reverts commit 4a5cff0.

* Revert "Ezhu/granularize staking resources (#343)"

This reverts commit 90e288c.

* Revert "Oracle parallel (#334)"

This reverts commit 67c0db3.

* Revert "Ezhu/staking dep gen mappings v2 rebase (#338)"

This reverts commit 1324183.

* Revert "Refactor Loadtest script (#336)"

This reverts commit c8b83c7.

* Revert "Optimize genesis account creation script (#320)"

This reverts commit a0c0306.

* Revert "Wasm gov (#316)"

This reverts commit c3b421b.

* Revert "Lazy Deposit All Module Accounts During EndBlock (#313)"

This reverts commit 5ad4d9b.

* Revert "Wasm signal (#305)"

This reverts commit 206f2bb.

* Revert "Add dependencies for ante handlers that read/write accounts (#314)"

This reverts commit 5d39f90.

* Revert "Add Gasless decorator back and remove CountTxDecorator  (#311)"

This reverts commit 93fa4bd.

* Revert "Branch another cache for all transactions (#309)"

This reverts commit c2ce1ed.

* Revert "Add msg send dynamic access ops (#303)"

This reverts commit 2c5f14e.

* Revert "[ante] Add ante dep generator default behavior (#294)"

This reverts commit 0ada1db.

* Revert "Add more parallel TX metrics (#296)"

This reverts commit 567ffd9.

* Revert "Add aclmapping options and mapping folder (#287)"

This reverts commit c9522a5.

* Revert "Bump sei-cosmos and sei-tendermint for 2.0.0beta (#293)"

This reverts commit d9254b6.

* Revert "Cherry-pick loadtesting changes and make a fix for parallel tx (#288)"

This reverts commit 255fec9.

* Revert "[app] refactored graph into acl module (#286)"

This reverts commit 9b2d204.

* Revert "Add gov proposal handler for acl (#277)"

This reverts commit bbb5a50.

* Revert "Fix for DAG building switch cases (#282)"

This reverts commit 9eebc8e.

* Revert "Optimize signals (#280)"

This reverts commit fd9a3b6.

* Revert "[app] Add behavior to process blocks with gov txs sync (#276)"

This reverts commit ea2a906.

* Revert "[graph] Move metric to dag builder helper (#275)"

This reverts commit c530c02.

* Revert "Fixes for parallel TX and metrics (#272)"

This reverts commit 30207e7.

* Revert "[graph] Add resource hierarchy to dependency graph (#268)"

This reverts commit da7c070.

* Revert "Revert "Parallel TX Synchrnous Testing""

This reverts commit f343740.

* Revert "Parallel TX Synchrnous Testing"

This reverts commit b95b44c.

* Revert "Dag optimization (#263)"

This reverts commit ac3fdbf.

* Revert "Create Channels from DAG (#261)"

This reverts commit 35b9cf4.

* Revert "[accesscontrol] Add dependency dag (#258)"

This reverts commit 6721845.

* Revert "Register accesscontrol module (#257)"

This reverts commit 3e34d34.
masih pushed a commit that referenced this pull request Sep 29, 2025
Add checkTx parsedLogs (#258)
13bd23c 
## Describe your changes and provide context
This PR parses broadcastTx log so that it can be correctly shown in the
response.log:

w/ this PR:
```
(base) ➜  sei-chain git:(master) ✗ seid tx bank send admin sei1txqs5kqjx5g33syy6mhtgq7z77wp2kf8r72qf6 100000sei -b block -y --chain-id sei-chain --fees=1000000usei --gas=500000 --sequence 10
code: 32
codespace: sdk
data: ""
events: []
gas_used: "0"
gas_wanted: "0"
height: "0"
info: ""
logs:
- events: []
  log: 'account sequence mismatch, expected 1, got 10: incorrect account sequence'
  msg_index: 0
raw_log: ""
timestamp: ""
tx: null
txhash: E71A5A9C34B5E09BE4116C77C0AA7FA63722FAA17A20FE229A8579E36BC5A318
```

w/o this PR:
```
...
logs: ""
raw_log: ""
...
```

## Testing performed to validate your change
- unit tests
- e2e test

---------

Co-authored-by: Cyson <cyson@Cysons-MBP.attlocal.net>
masih pushed a commit that referenced this pull request Sep 30, 2025
@masih
Add checkTx parsedLogs (#258)
1e19aa0 
## Describe your changes and provide context
This PR parses broadcastTx log so that it can be correctly shown in the
response.log:

w/ this PR:
```
(base) ➜  sei-chain git:(master) ✗ seid tx bank send admin sei1txqs5kqjx5g33syy6mhtgq7z77wp2kf8r72qf6 100000sei -b block -y --chain-id sei-chain --fees=1000000usei --gas=500000 --sequence 10
code: 32
codespace: sdk
data: ""
events: []
gas_used: "0"
gas_wanted: "0"
height: "0"
info: ""
logs:
- events: []
  log: 'account sequence mismatch, expected 1, got 10: incorrect account sequence'
  msg_index: 0
raw_log: ""
timestamp: ""
tx: null
txhash: E71A5A9C34B5E09BE4116C77C0AA7FA63722FAA17A20FE229A8579E36BC5A318
```

w/o this PR:
```
...
logs: ""
raw_log: ""
...
```

## Testing performed to validate your change
- unit tests
- e2e test

---------

Co-authored-by: Cyson <cyson@Cysons-MBP.attlocal.net>
masih pushed a commit that referenced this pull request Oct 1, 2025
@codchen
Add utils to get RequestBeginBlock (#258)
950e14c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codchen codchen Awaiting requested review from codchen

1 more reviewer

@BrandonWeng BrandonWeng BrandonWeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@udpatil @codchen @BrandonWeng