Skip to content

Add dependencies for ante handlers that read/write accounts#314

Merged
codchen merged 1 commit into2.0.0betafrom
tony-chen-ante-acc-deps
Oct 18, 2022
Merged

Add dependencies for ante handlers that read/write accounts#314
codchen merged 1 commit into2.0.0betafrom
tony-chen-ante-acc-deps

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Oct 18, 2022

Describe your changes and provide context

The following ante handlers access individual account KV states:

  • ConsumeGasForTxSizeDecorator -> read only
  • SetPubKeyDecorator -> read/write
  • SigGasConsumeDecorator -> read only
  • SigVerificationDecorator -> read only
  • IncrementSequenceDecorator -> read/write
    Since handlers above are applicable to all message types, it could potentially cause race condition for even bank send type (whose loadtest was only run with one msg per account per block). This PR adds dependencies on accounts for these handlers.

Testing performed to validate your change

ran sei locally

BrandonWeng
BrandonWeng approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@BrandonWeng BrandonWeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codchen codchen merged commit ec0c368 into 2.0.0beta Oct 18, 2022
udpatil pushed a commit that referenced this pull request Oct 27, 2022
@codchen @udpatil
Add dependencies for ante handlers that read/write accounts (#314)
9b0a1fc
udpatil pushed a commit that referenced this pull request Oct 27, 2022
@codchen @udpatil
Add dependencies for ante handlers that read/write accounts (#314)
1da6157
udpatil pushed a commit that referenced this pull request Oct 28, 2022
@codchen @udpatil
Add dependencies for ante handlers that read/write accounts (#314)
e164942
udpatil pushed a commit that referenced this pull request Nov 1, 2022
@codchen @udpatil
Add dependencies for ante handlers that read/write accounts (#314)
18d8859
udpatil pushed a commit that referenced this pull request Nov 1, 2022
@codchen @udpatil
Add dependencies for ante handlers that read/write accounts (#314)
5d39f90
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
Revert "Add dependencies for ante handlers that read/write accounts (#…
91dca96 
…314)"

This reverts commit 5d39f90.
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
Revert "Rebase 2.0.0beta Parallelization onto master" (#357)
977c1d1 
* Revert "Update Antehandler resource depedencies  (#354)"

This reverts commit 6c672fb.

* Revert "update staking validation identifier (#353)"

This reverts commit 8a17c26.

* Revert "Update Oracle Parallel Tx Resource Identifiers  (#351)"

This reverts commit c9229ab.

* Revert "Update IdentifierTemplate for TokenFactory  (#350)"

This reverts commit e81fc93.

* Revert "[loadtest] Loadtest fixes"

This reverts commit 68bfab5.

* Revert "fix unit tests"

This reverts commit 49eb809.

* Revert "Fix Bank Send Unit Tests  (#348)"

This reverts commit 9c11837.

* Revert "integrate with sei-cosmos changes (#347)"

This reverts commit e1b1790.

* Revert "Validate Concurrent Messages + Update BankSend  (#345)"

This reverts commit e4d3176.

* Revert "Add concurrency for BurnMsg and MintMsg (#331)"

This reverts commit 4a5cff0.

* Revert "Ezhu/granularize staking resources (#343)"

This reverts commit 90e288c.

* Revert "Oracle parallel (#334)"

This reverts commit 67c0db3.

* Revert "Ezhu/staking dep gen mappings v2 rebase (#338)"

This reverts commit 1324183.

* Revert "Refactor Loadtest script (#336)"

This reverts commit c8b83c7.

* Revert "Optimize genesis account creation script (#320)"

This reverts commit a0c0306.

* Revert "Wasm gov (#316)"

This reverts commit c3b421b.

* Revert "Lazy Deposit All Module Accounts During EndBlock (#313)"

This reverts commit 5ad4d9b.

* Revert "Wasm signal (#305)"

This reverts commit 206f2bb.

* Revert "Add dependencies for ante handlers that read/write accounts (#314)"

This reverts commit 5d39f90.

* Revert "Add Gasless decorator back and remove CountTxDecorator  (#311)"

This reverts commit 93fa4bd.

* Revert "Branch another cache for all transactions (#309)"

This reverts commit c2ce1ed.

* Revert "Add msg send dynamic access ops (#303)"

This reverts commit 2c5f14e.

* Revert "[ante] Add ante dep generator default behavior (#294)"

This reverts commit 0ada1db.

* Revert "Add more parallel TX metrics (#296)"

This reverts commit 567ffd9.

* Revert "Add aclmapping options and mapping folder (#287)"

This reverts commit c9522a5.

* Revert "Bump sei-cosmos and sei-tendermint for 2.0.0beta (#293)"

This reverts commit d9254b6.

* Revert "Cherry-pick loadtesting changes and make a fix for parallel tx (#288)"

This reverts commit 255fec9.

* Revert "[app] refactored graph into acl module (#286)"

This reverts commit 9b2d204.

* Revert "Add gov proposal handler for acl (#277)"

This reverts commit bbb5a50.

* Revert "Fix for DAG building switch cases (#282)"

This reverts commit 9eebc8e.

* Revert "Optimize signals (#280)"

This reverts commit fd9a3b6.

* Revert "[app] Add behavior to process blocks with gov txs sync (#276)"

This reverts commit ea2a906.

* Revert "[graph] Move metric to dag builder helper (#275)"

This reverts commit c530c02.

* Revert "Fixes for parallel TX and metrics (#272)"

This reverts commit 30207e7.

* Revert "[graph] Add resource hierarchy to dependency graph (#268)"

This reverts commit da7c070.

* Revert "Revert "Parallel TX Synchrnous Testing""

This reverts commit f343740.

* Revert "Parallel TX Synchrnous Testing"

This reverts commit b95b44c.

* Revert "Dag optimization (#263)"

This reverts commit ac3fdbf.

* Revert "Create Channels from DAG (#261)"

This reverts commit 35b9cf4.

* Revert "[accesscontrol] Add dependency dag (#258)"

This reverts commit 6721845.

* Revert "Register accesscontrol module (#257)"

This reverts commit 3e34d34.
masih pushed a commit that referenced this pull request Sep 29, 2025
@philipsu522
Allow manual trigger of buf.build protos (#314)
47756ee 
## Describe your changes and provide context

## Testing performed to validate your change
masih pushed a commit that referenced this pull request Sep 30, 2025
@philipsu522 @masih
Allow manual trigger of buf.build protos (#314)
2d4540f 
## Describe your changes and provide context

## Testing performed to validate your change
masih pushed a commit that referenced this pull request Oct 1, 2025
@jewei1997
Estimate Gas Fix (#314)
4209f85 
* add estimate gas fix

* update use 21k as min

* add test

* minor fix

* pull more txs after large gas high pri txs

* Revert "pull more txs after large gas high pri txs"

This reverts commit 60447cc318a036c5d948b2a33a787d207d1c683d.

* change to MinTxToPeek

* minor fix
@masih masih deleted the tony-chen-ante-acc-deps branch October 31, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipsu522 philipsu522 Awaiting requested review from philipsu522

@udpatil udpatil Awaiting requested review from udpatil

1 more reviewer

@BrandonWeng BrandonWeng BrandonWeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codchen @BrandonWeng