Validate Concurrent Messages + Update BankSend by BrandonWeng · Pull Request #345 · sei-protocol/sei-chain

BrandonWeng · 2022-10-27T13:53:43Z

Describe your changes and provide context

Updates the banksend acl mapping to use the prefix/storekeys as the identifiers rather than arbitrary ones
Adds logic for handling failovers in the case when concurrent executions fail
Adds metric to count failed TX counts, we should add alerting on this in the future

Will need to update the mapping for all the other modules

Testing performed to validate your change

Unit tests

Deployed to load test cluster and was able to run bank sends e2e and verified that the height increases

Also manually forced failure scenario

BrandonWeng · 2022-10-27T14:27:21Z

aclmapping/bank/mapping_test.go

+	}
+}
+
+func TestGeneratorInvalidMessageTypes(t *testing.T) {


This is the leaf node unit test, decided to just add it in this PR too

eric-zhu-uw · 2022-10-28T02:47:59Z

aclmapping/bank/mappings.go

+
+		// Gets Account Info for the sender
+		{
+			AccessType:         sdkacltypes.AccessType_READ,


for the ToAddress, there is a write access but for the FromAddress there is no write access, only read. Just want to make sure it wasn't missed.

Yeee, I believe it has to exist already based (If it doesn't exist then there's no money to be sent) on the logic we only create accounts for the receiver if it doesn't exist

## Describe your changes and provide context * CacheKv Stores emit an access operation event used to track accesses to resources during runTx, we only need to add it to cacheKv because we branch before runMsgs and ante handlers * Adds validation logic Will also need to add validation for ante handlers ## Testing performed to validate your change Testing part of this PR: sei-protocol/sei-chain#345

* Slowly checkout changes * Run from latest sei-cosmos * Use Auth Type * Event Emitting * Validate but dont fail + branch cache * pass validation and add failover logic * return err on validation * metrics * lint * Hard coded prefix mapping * most test passing * fix * lint * testing start * tidy

This reverts commit e4d3176.

* Revert "Update Antehandler resource depedencies (#354)" This reverts commit 6c672fb. * Revert "update staking validation identifier (#353)" This reverts commit 8a17c26. * Revert "Update Oracle Parallel Tx Resource Identifiers (#351)" This reverts commit c9229ab. * Revert "Update IdentifierTemplate for TokenFactory (#350)" This reverts commit e81fc93. * Revert "[loadtest] Loadtest fixes" This reverts commit 68bfab5. * Revert "fix unit tests" This reverts commit 49eb809. * Revert "Fix Bank Send Unit Tests (#348)" This reverts commit 9c11837. * Revert "integrate with sei-cosmos changes (#347)" This reverts commit e1b1790. * Revert "Validate Concurrent Messages + Update BankSend (#345)" This reverts commit e4d3176. * Revert "Add concurrency for BurnMsg and MintMsg (#331)" This reverts commit 4a5cff0. * Revert "Ezhu/granularize staking resources (#343)" This reverts commit 90e288c. * Revert "Oracle parallel (#334)" This reverts commit 67c0db3. * Revert "Ezhu/staking dep gen mappings v2 rebase (#338)" This reverts commit 1324183. * Revert "Refactor Loadtest script (#336)" This reverts commit c8b83c7. * Revert "Optimize genesis account creation script (#320)" This reverts commit a0c0306. * Revert "Wasm gov (#316)" This reverts commit c3b421b. * Revert "Lazy Deposit All Module Accounts During EndBlock (#313)" This reverts commit 5ad4d9b. * Revert "Wasm signal (#305)" This reverts commit 206f2bb. * Revert "Add dependencies for ante handlers that read/write accounts (#314)" This reverts commit 5d39f90. * Revert "Add Gasless decorator back and remove CountTxDecorator (#311)" This reverts commit 93fa4bd. * Revert "Branch another cache for all transactions (#309)" This reverts commit c2ce1ed. * Revert "Add msg send dynamic access ops (#303)" This reverts commit 2c5f14e. * Revert "[ante] Add ante dep generator default behavior (#294)" This reverts commit 0ada1db. * Revert "Add more parallel TX metrics (#296)" This reverts commit 567ffd9. * Revert "Add aclmapping options and mapping folder (#287)" This reverts commit c9522a5. * Revert "Bump sei-cosmos and sei-tendermint for 2.0.0beta (#293)" This reverts commit d9254b6. * Revert "Cherry-pick loadtesting changes and make a fix for parallel tx (#288)" This reverts commit 255fec9. * Revert "[app] refactored graph into acl module (#286)" This reverts commit 9b2d204. * Revert "Add gov proposal handler for acl (#277)" This reverts commit bbb5a50. * Revert "Fix for DAG building switch cases (#282)" This reverts commit 9eebc8e. * Revert "Optimize signals (#280)" This reverts commit fd9a3b6. * Revert "[app] Add behavior to process blocks with gov txs sync (#276)" This reverts commit ea2a906. * Revert "[graph] Move metric to dag builder helper (#275)" This reverts commit c530c02. * Revert "Fixes for parallel TX and metrics (#272)" This reverts commit 30207e7. * Revert "[graph] Add resource hierarchy to dependency graph (#268)" This reverts commit da7c070. * Revert "Revert "Parallel TX Synchrnous Testing"" This reverts commit f343740. * Revert "Parallel TX Synchrnous Testing" This reverts commit b95b44c. * Revert "Dag optimization (#263)" This reverts commit ac3fdbf. * Revert "Create Channels from DAG (#261)" This reverts commit 35b9cf4. * Revert "[accesscontrol] Add dependency dag (#258)" This reverts commit 6721845. * Revert "Register accesscontrol module (#257)" This reverts commit 3e34d34.

## Describe your changes and provide context * CacheKv Stores emit an access operation event used to track accesses to resources during runTx, we only need to add it to cacheKv because we branch before runMsgs and ante handlers * Adds validation logic Will also need to add validation for ante handlers ## Testing performed to validate your change Testing part of this PR: #345

## Describe your changes and provide context This is necessary to make signing EVM messages from `sei-chain` utility possible ## Testing performed to validate your change local chain

## Describe your changes and provide context * CacheKv Stores emit an access operation event used to track accesses to resources during runTx, we only need to add it to cacheKv because we branch before runMsgs and ante handlers * Adds validation logic Will also need to add validation for ante handlers ## Testing performed to validate your change Testing part of this PR: #345

## Describe your changes and provide context This is necessary to make signing EVM messages from `sei-chain` utility possible ## Testing performed to validate your change local chain

BrandonWeng added 7 commits October 27, 2022 08:14

Slowly checkout changes

97b4c7b

Run from latest sei-cosmos

69f49fd

Use Auth Type

1637692

Event Emitting

d7ef111

Validate but dont fail + branch cache

47bc126

pass validation and add failover logic

be271f8

return err on validation

785af58

BrandonWeng requested review from codchen, eric-zhu-uw and udpatil October 27, 2022 13:53

BrandonWeng assigned codchen, udpatil and eric-zhu-uw Oct 27, 2022

metrics

e141a8e

BrandonWeng mentioned this pull request Oct 27, 2022

Validate Concurrent Messages + Update BankSend sei-protocol/sei-cosmos#76

Merged

lint

08ef036

BrandonWeng commented Oct 27, 2022

View reviewed changes

codchen approved these changes Oct 27, 2022

View reviewed changes

BrandonWeng added 2 commits October 27, 2022 19:12

Hard coded prefix mapping

e3dbe8d

most test passing

222ba84

BrandonWeng requested a review from philipsu522 October 27, 2022 23:48

fix

0b48333

BrandonWeng force-pushed the bweng-tx-validation-testing branch from e1278e4 to 0b48333 Compare October 27, 2022 23:50

BrandonWeng added 3 commits October 27, 2022 19:54

lint

95fb890

testing start

a6118cb

tidy

66ee21a

eric-zhu-uw approved these changes Oct 28, 2022

View reviewed changes

BrandonWeng merged commit f550f30 into 2.0.0beta Oct 28, 2022

BrandonWeng deleted the bweng-tx-validation-testing branch October 28, 2022 13:09

udpatil added a commit that referenced this pull request Nov 1, 2022

Revert "Validate Concurrent Messages + Update BankSend (#345)"

843e8eb

This reverts commit e4d3176.

masih pushed a commit that referenced this pull request Sep 29, 2025

Make Localinfo public (#345)

adfc650

## Describe your changes and provide context This is necessary to make signing EVM messages from `sei-chain` utility possible ## Testing performed to validate your change local chain

masih pushed a commit that referenced this pull request Sep 30, 2025

Make Localinfo public (#345)

3c0147a

## Describe your changes and provide context This is necessary to make signing EVM messages from `sei-chain` utility possible ## Testing performed to validate your change local chain

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate Concurrent Messages + Update BankSend #345

Validate Concurrent Messages + Update BankSend #345
BrandonWeng merged 15 commits into2.0.0betafrom
bweng-tx-validation-testing

BrandonWeng commented Oct 27, 2022 •

edited

Loading

Uh oh!

BrandonWeng Oct 27, 2022

Uh oh!

eric-zhu-uw Oct 28, 2022

Uh oh!

BrandonWeng Oct 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

BrandonWeng commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes and provide context

Testing performed to validate your change

Uh oh!

BrandonWeng Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

eric-zhu-uw Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

BrandonWeng Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BrandonWeng commented Oct 27, 2022 •

edited

Loading