Skip to content

Fixes for parallel TX and metrics#272

Merged
BrandonWeng merged 8 commits into2.0.0betafrom
bweng-2.0.0-loadtest-fixes
Oct 3, 2022
Merged

Fixes for parallel TX and metrics#272
BrandonWeng merged 8 commits into2.0.0betafrom
bweng-2.0.0-loadtest-fixes

Conversation

@BrandonWeng
Copy link
Contributor

@BrandonWeng BrandonWeng commented Oct 2, 2022

Fix for waitGroup and adding metrics to record the number of concurrent TXs processed vs synchronous

Ran load test script -- see that number of total txs reported == concurrent txs processed
image

BrandonWeng
BrandonWeng commented Oct 2, 2022
View reviewed changes
loadtest/contracts/deploy_ten_contracts.sh
--mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target \
--mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \
cosmwasm/rust-optimizer:0.12.5
cosmwasm/rust-optimizer:0.12.6
Copy link
Contributor Author

@BrandonWeng BrandonWeng Oct 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

votex README says to use 0.12.6

BrandonWeng
BrandonWeng commented Oct 2, 2022
View reviewed changes
x/dex/keeper/epoch.go
b := store.Get([]byte(EpochKey))
lastEpoch := binary.BigEndian.Uint64(b)
currentEpoch := k.EpochKeeper.GetEpoch(ctx).CurrentEpoch
ctx.Logger().Info(fmt.Sprintf("Current epoch %d", currentEpoch))
Copy link
Contributor Author

@BrandonWeng BrandonWeng Oct 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super noisy since it gets called once for each settlement check
image

@BrandonWeng BrandonWeng force-pushed the bweng-2.0.0-loadtest-fixes branch from 7a41462 to 444ec74 Compare October 3, 2022 05:36
philipsu522
philipsu522 reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@philipsu522 philipsu522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also have a metric on how long it takes to build the DAG?

BrandonWeng
BrandonWeng commented Oct 3, 2022
View reviewed changes
app/graph.go
//
// It will also register the new node with AccessOpsMap so that future nodes that amy be dependent on this one can properly identify the dependency.
func (dag *Dag) AddNodeBuildDependency(messageIndex int, txIndex int, accessOp acltypes.AccessOperation) {
defer metrics.MeasureBuildDagDuration(time.Now(), "AddNodeBuildDependency")
Copy link
Contributor Author

@BrandonWeng BrandonWeng Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding it to the two high level calls that are not constant time cc @philipsu522

BrandonWeng
BrandonWeng commented Oct 3, 2022
View reviewed changes
app/graph.go
completionSignalingMap map[int]MessageCompletionSignalMapping,
blockingSignalsMap map[int]MessageCompletionSignalMapping,
) {
defer metrics.MeasureBuildDagDuration(time.Now(), "BuildCompletionSignalMaps")
Copy link
Contributor Author

@BrandonWeng BrandonWeng Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the slowest call called once per block

@BrandonWeng BrandonWeng merged commit 1da840f into 2.0.0beta Oct 3, 2022
@BrandonWeng BrandonWeng deleted the bweng-2.0.0-loadtest-fixes branch October 3, 2022 16:19
udpatil pushed a commit that referenced this pull request Oct 27, 2022
@BrandonWeng @udpatil
Fixes for parallel TX and metrics (#272)
2d7a014 
* Fixes for parallel TX and metrics

* newline

* Update epoch.go

* bump

* fixo

* lint

* add dag metrics

* lint
udpatil pushed a commit that referenced this pull request Oct 27, 2022
@BrandonWeng @udpatil
Fixes for parallel TX and metrics (#272)
de26576 
* Fixes for parallel TX and metrics

* newline

* Update epoch.go

* bump

* fixo

* lint

* add dag metrics

* lint
udpatil pushed a commit that referenced this pull request Oct 27, 2022
@BrandonWeng @udpatil
Fixes for parallel TX and metrics (#272)
06e2c35 
* Fixes for parallel TX and metrics

* newline

* Update epoch.go

* bump

* fixo

* lint

* add dag metrics

* lint
udpatil pushed a commit that referenced this pull request Oct 28, 2022
@BrandonWeng @udpatil
Fixes for parallel TX and metrics (#272)
af47447 
* Fixes for parallel TX and metrics

* newline

* Update epoch.go

* bump

* fixo

* lint

* add dag metrics

* lint
udpatil pushed a commit that referenced this pull request Nov 1, 2022
@BrandonWeng @udpatil
Fixes for parallel TX and metrics (#272)
15b181c 
* Fixes for parallel TX and metrics

* newline

* Update epoch.go

* bump

* fixo

* lint

* add dag metrics

* lint
udpatil pushed a commit that referenced this pull request Nov 1, 2022
@BrandonWeng @udpatil
Fixes for parallel TX and metrics (#272)
30207e7 
* Fixes for parallel TX and metrics

* newline

* Update epoch.go

* bump

* fixo

* lint

* add dag metrics

* lint
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
Revert "Fixes for parallel TX and metrics (#272)"
f294cc1 
This reverts commit 30207e7.
udpatil added a commit that referenced this pull request Nov 1, 2022
@udpatil
Revert "Rebase 2.0.0beta Parallelization onto master" (#357)
977c1d1 
* Revert "Update Antehandler resource depedencies  (#354)"

This reverts commit 6c672fb.

* Revert "update staking validation identifier (#353)"

This reverts commit 8a17c26.

* Revert "Update Oracle Parallel Tx Resource Identifiers  (#351)"

This reverts commit c9229ab.

* Revert "Update IdentifierTemplate for TokenFactory  (#350)"

This reverts commit e81fc93.

* Revert "[loadtest] Loadtest fixes"

This reverts commit 68bfab5.

* Revert "fix unit tests"

This reverts commit 49eb809.

* Revert "Fix Bank Send Unit Tests  (#348)"

This reverts commit 9c11837.

* Revert "integrate with sei-cosmos changes (#347)"

This reverts commit e1b1790.

* Revert "Validate Concurrent Messages + Update BankSend  (#345)"

This reverts commit e4d3176.

* Revert "Add concurrency for BurnMsg and MintMsg (#331)"

This reverts commit 4a5cff0.

* Revert "Ezhu/granularize staking resources (#343)"

This reverts commit 90e288c.

* Revert "Oracle parallel (#334)"

This reverts commit 67c0db3.

* Revert "Ezhu/staking dep gen mappings v2 rebase (#338)"

This reverts commit 1324183.

* Revert "Refactor Loadtest script (#336)"

This reverts commit c8b83c7.

* Revert "Optimize genesis account creation script (#320)"

This reverts commit a0c0306.

* Revert "Wasm gov (#316)"

This reverts commit c3b421b.

* Revert "Lazy Deposit All Module Accounts During EndBlock (#313)"

This reverts commit 5ad4d9b.

* Revert "Wasm signal (#305)"

This reverts commit 206f2bb.

* Revert "Add dependencies for ante handlers that read/write accounts (#314)"

This reverts commit 5d39f90.

* Revert "Add Gasless decorator back and remove CountTxDecorator  (#311)"

This reverts commit 93fa4bd.

* Revert "Branch another cache for all transactions (#309)"

This reverts commit c2ce1ed.

* Revert "Add msg send dynamic access ops (#303)"

This reverts commit 2c5f14e.

* Revert "[ante] Add ante dep generator default behavior (#294)"

This reverts commit 0ada1db.

* Revert "Add more parallel TX metrics (#296)"

This reverts commit 567ffd9.

* Revert "Add aclmapping options and mapping folder (#287)"

This reverts commit c9522a5.

* Revert "Bump sei-cosmos and sei-tendermint for 2.0.0beta (#293)"

This reverts commit d9254b6.

* Revert "Cherry-pick loadtesting changes and make a fix for parallel tx (#288)"

This reverts commit 255fec9.

* Revert "[app] refactored graph into acl module (#286)"

This reverts commit 9b2d204.

* Revert "Add gov proposal handler for acl (#277)"

This reverts commit bbb5a50.

* Revert "Fix for DAG building switch cases (#282)"

This reverts commit 9eebc8e.

* Revert "Optimize signals (#280)"

This reverts commit fd9a3b6.

* Revert "[app] Add behavior to process blocks with gov txs sync (#276)"

This reverts commit ea2a906.

* Revert "[graph] Move metric to dag builder helper (#275)"

This reverts commit c530c02.

* Revert "Fixes for parallel TX and metrics (#272)"

This reverts commit 30207e7.

* Revert "[graph] Add resource hierarchy to dependency graph (#268)"

This reverts commit da7c070.

* Revert "Revert "Parallel TX Synchrnous Testing""

This reverts commit f343740.

* Revert "Parallel TX Synchrnous Testing"

This reverts commit b95b44c.

* Revert "Dag optimization (#263)"

This reverts commit ac3fdbf.

* Revert "Create Channels from DAG (#261)"

This reverts commit 35b9cf4.

* Revert "[accesscontrol] Add dependency dag (#258)"

This reverts commit 6721845.

* Revert "Register accesscontrol module (#257)"

This reverts commit 3e34d34.
masih pushed a commit that referenced this pull request Sep 29, 2025
@philipsu522
[Certik Audit] Remove duplicate function (#272)
0cc8362 
## Describe your changes and provide context
This function is a duplicate of the one above. Remove the Legacy version
## Testing performed to validate your change
Unit tests
masih pushed a commit that referenced this pull request Sep 30, 2025
@philipsu522 @masih
[Certik Audit] Remove duplicate function (#272)
3dbc6ab 
## Describe your changes and provide context
This function is a duplicate of the one above. Remove the Legacy version
## Testing performed to validate your change
Unit tests
masih pushed a commit that referenced this pull request Oct 1, 2025
@cordt-sei
Fix description of 'unconditional peer' behavior (#272)
5b30def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipsu522 philipsu522 philipsu522 approved these changes

@udpatil udpatil udpatil approved these changes

Assignees

@philipsu522 philipsu522

@udpatil udpatil

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrandonWeng @philipsu522 @udpatil