Skip to content

Refactor Loadtest script#336

Merged
BrandonWeng merged 6 commits into2.0.0betafrom
bweng-optimize-account-creation
Oct 24, 2022
Merged

Refactor Loadtest script#336
BrandonWeng merged 6 commits into2.0.0betafrom
bweng-optimize-account-creation

Conversation

@BrandonWeng
Copy link
Contributor

@BrandonWeng BrandonWeng commented Oct 24, 2022

Describe your changes and provide context

Concurrency didn't seem to be the bottleneck.

  • Refactored the script
  • Made a cache for the signer/account seqno responses
    • Instead of querying for each Seq No, we will just manage it locally
  • For opening test account files, it will be the same, and read it from memory instead of from file each time

Testing performed to validate your change

Went from ~5 minutes -> 2 minutes

The first two rounds take the longest (active/inactive accounts fetching live info) then the remaining 3 rounds are super fast since it's just reading from the cache.
image

Without this change:
image

@BrandonWeng BrandonWeng changed the title Bweng optimize account creation Refactor Loadtest script Oct 24, 2022
@BrandonWeng BrandonWeng requested review from codchen and removed request for udpatil October 24, 2022 14:33
loadtest/main.go Outdated
defer client.Close()

if config.TxsPerBlock < config.MsgsPerTx {
panic("Must have more orders per block than batch size")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - update comment to "txs"

privKey := algo.Generate()(derivedPriv)

// Cache this so we don't need to regenerate it
sc.CachedAccountKey.Store(accountIdx, privKey)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - didn't know this was a bottleneck

@BrandonWeng BrandonWeng merged commit d387d49 into 2.0.0beta Oct 24, 2022
@BrandonWeng BrandonWeng deleted the bweng-optimize-account-creation branch October 24, 2022 17:56
udpatil pushed a commit that referenced this pull request Oct 28, 2022
* Refactored

* Refactor loadtest client

* ido

* undo old

* lint

* Update main.go
udpatil pushed a commit that referenced this pull request Oct 28, 2022
* Refactored

* Refactor loadtest client

* ido

* undo old

* lint

* Update main.go
udpatil pushed a commit that referenced this pull request Nov 1, 2022
* Refactored

* Refactor loadtest client

* ido

* undo old

* lint

* Update main.go
udpatil pushed a commit that referenced this pull request Nov 1, 2022
* Refactored

* Refactor loadtest client

* ido

* undo old

* lint

* Update main.go
udpatil added a commit that referenced this pull request Nov 1, 2022
udpatil added a commit that referenced this pull request Nov 1, 2022
* Revert "Update Antehandler resource depedencies  (#354)"

This reverts commit 6c672fb.

* Revert "update staking validation identifier (#353)"

This reverts commit 8a17c26.

* Revert "Update Oracle Parallel Tx Resource Identifiers  (#351)"

This reverts commit c9229ab.

* Revert "Update IdentifierTemplate for TokenFactory  (#350)"

This reverts commit e81fc93.

* Revert "[loadtest] Loadtest fixes"

This reverts commit 68bfab5.

* Revert "fix unit tests"

This reverts commit 49eb809.

* Revert "Fix Bank Send Unit Tests  (#348)"

This reverts commit 9c11837.

* Revert "integrate with sei-cosmos changes (#347)"

This reverts commit e1b1790.

* Revert "Validate Concurrent Messages + Update BankSend  (#345)"

This reverts commit e4d3176.

* Revert "Add concurrency for BurnMsg and MintMsg (#331)"

This reverts commit 4a5cff0.

* Revert "Ezhu/granularize staking resources (#343)"

This reverts commit 90e288c.

* Revert "Oracle parallel (#334)"

This reverts commit 67c0db3.

* Revert "Ezhu/staking dep gen mappings v2 rebase (#338)"

This reverts commit 1324183.

* Revert "Refactor Loadtest script (#336)"

This reverts commit c8b83c7.

* Revert "Optimize genesis account creation script (#320)"

This reverts commit a0c0306.

* Revert "Wasm gov (#316)"

This reverts commit c3b421b.

* Revert "Lazy Deposit All Module Accounts During EndBlock (#313)"

This reverts commit 5ad4d9b.

* Revert "Wasm signal (#305)"

This reverts commit 206f2bb.

* Revert "Add dependencies for ante handlers that read/write accounts (#314)"

This reverts commit 5d39f90.

* Revert "Add Gasless decorator back and remove CountTxDecorator  (#311)"

This reverts commit 93fa4bd.

* Revert "Branch another cache for all transactions (#309)"

This reverts commit c2ce1ed.

* Revert "Add msg send dynamic access ops (#303)"

This reverts commit 2c5f14e.

* Revert "[ante] Add ante dep generator default behavior (#294)"

This reverts commit 0ada1db.

* Revert "Add more parallel TX metrics (#296)"

This reverts commit 567ffd9.

* Revert "Add aclmapping options and mapping folder (#287)"

This reverts commit c9522a5.

* Revert "Bump sei-cosmos and sei-tendermint for 2.0.0beta (#293)"

This reverts commit d9254b6.

* Revert "Cherry-pick loadtesting changes and make a fix for parallel tx (#288)"

This reverts commit 255fec9.

* Revert "[app] refactored graph into acl module (#286)"

This reverts commit 9b2d204.

* Revert "Add gov proposal handler for acl (#277)"

This reverts commit bbb5a50.

* Revert "Fix for DAG building switch cases (#282)"

This reverts commit 9eebc8e.

* Revert "Optimize signals (#280)"

This reverts commit fd9a3b6.

* Revert "[app] Add behavior to process blocks with gov txs sync (#276)"

This reverts commit ea2a906.

* Revert "[graph] Move metric to dag builder helper (#275)"

This reverts commit c530c02.

* Revert "Fixes for parallel TX and metrics (#272)"

This reverts commit 30207e7.

* Revert "[graph] Add resource hierarchy to dependency graph (#268)"

This reverts commit da7c070.

* Revert "Revert "Parallel TX Synchrnous Testing""

This reverts commit f343740.

* Revert "Parallel TX Synchrnous Testing"

This reverts commit b95b44c.

* Revert "Dag optimization (#263)"

This reverts commit ac3fdbf.

* Revert "Create Channels from DAG (#261)"

This reverts commit 35b9cf4.

* Revert "[accesscontrol] Add dependency dag (#258)"

This reverts commit 6721845.

* Revert "Register accesscontrol module (#257)"

This reverts commit 3e34d34.
masih pushed a commit that referenced this pull request Sep 29, 2025
- This was copied from #332 which became unwieldy due to commit history
(merges/rebases)
- Adds scheduler logic for validation
- In this initial version it completes all executions then performs
validations (which feed retries)
- Once we start benchmarking we can make performance improvements to
this
- Retries tasks that fail validation and have no dependencies

- Scheduler Test verifies multi-worker with conflicts
masih pushed a commit that referenced this pull request Sep 30, 2025
- This was copied from #332 which became unwieldy due to commit history
(merges/rebases)
- Adds scheduler logic for validation
- In this initial version it completes all executions then performs
validations (which feed retries)
- Once we start benchmarking we can make performance improvements to
this
- Retries tasks that fail validation and have no dependencies

- Scheduler Test verifies multi-worker with conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants