[upload] Fix for anonymous upload duplicate directory issue

[dwolstroRH]

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-4156
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[TurboTurtle]

It's not clear to me what the purported issue this is intended to fix is, or how it actually goes about fixing it. An actual commit message would go a long way here.

Additionally, you'll need to rebase your changed on current main, so that this branch doesn't attempt to pull in 50 other preceding commits again.

[pmoravec]

THIS is the key commit:

dwolstroRH@16b1431

but I agree, you need to rebase your branch.

Do I get it right that the 4003238 "Enable sos uploads of files bigger than 1Gb" has some side-effect or missing piece?

I miss the description of the error you aim to fix /o.

[pmoravec]

I do approve the code change (when SFTP-ing to Red Hat SFTP server under anonymous user, a randomly generated on-time username is used that does not have home. In that case, we cant upload to its home but to default dir).

Please squash the commits into one, or create a new branch based on current upstream, and apply there just the patch:

--- a/sos/upload/targets/redhat.py
+++ b/sos/upload/targets/redhat.py
@@ -184,6 +184,7 @@ class RHELUploadTarget(UploadTarget):
 
         url = self.RH_API_HOST + '/support/v2/sftp/token'
         ret = None
+        ftp_user_directory = None
         if self._device_token:
             headers = self._get_upload_https_auth()
             ret = requests.post(url, headers=headers, timeout=10)
@@ -200,6 +201,7 @@ class RHELUploadTarget(UploadTarget):
                     "Unable to retrieve Red Hat auth token using provided "
                     "credentials. Will try anonymous."
                 )
+            ftp_user_directory = _user
         else:
             adata = {"isAnonymous": True}
             anon = requests.post(url, data=json.dumps(adata), timeout=10)
@@ -218,7 +220,7 @@ class RHELUploadTarget(UploadTarget):
                 )
         if _user and _token:
             return super().upload_sftp(user=_user, password=_token,
-                                       user_dir=_user)
+                                       user_dir=ftp_user_directory)
         raise Exception("Could not retrieve valid or anonymous credentials")
 
     def check_file_too_big(self, archive):

[arif-ali]

This is still not squashed, and still has 55 commits; we ought to be seeing only 1 commit. Once that is done, this can be reviewed and work on