Skip to content

i18n(ko-KR): create translations.mdx#90

Merged
Adammatthiesen merged 1 commit into
withstudiocms:mainfrom
jsparkdev:trans
Apr 18, 2025
Merged

i18n(ko-KR): create translations.mdx#90
Adammatthiesen merged 1 commit into
withstudiocms:mainfrom
jsparkdev:trans

Conversation

@jsparkdev
Copy link
Copy Markdown
Contributor

@jsparkdev jsparkdev commented Apr 18, 2025

Description

  • create translations.mdx
  • update English document for fixing the invalid link.

Summary by CodeRabbit

  • Documentation
    • Corrected the filename reference for the English translation file in the English documentation.
    • Added a new Korean documentation page outlining how to contribute translations to StudioCMS, including guidance on translation processes, status tracking, and links to relevant resources.

@jsparkdev jsparkdev requested a review from a team as a code owner April 18, 2025 13:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2025

Walkthrough

The changes update the documentation related to translation contributions for StudioCMS. The English documentation was corrected to reference the proper translation file name. Additionally, a new Korean documentation page was introduced, providing guidance on how to contribute translations, describing the translation workflow, and offering relevant resources and links.

Changes

File(s) Change Summary
src/content/docs/en/contributing/translations.mdx Updated the filename reference for the English translation file from en-us.json to en.json.
src/content/docs/ko/contributing/translations.mdx Added a new Korean documentation page explaining translation contributions, workflow, and resource links.

Possibly related PRs

Suggested labels

i18n

Suggested reviewers

  • Adammatthiesen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@studiocms-no-reply
Copy link
Copy Markdown
Member

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/contributing/translations.mdx Source changed, localizations will be marked as outdated.
ko/contributing/translations.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/content/docs/en/contributing/translations.mdx (1)

24-24: Grammar refinement: Remove unnecessary "would".

Per static analysis and general style for conditional clauses, replace “If you would prefer to contribute translations directly to the repository…” with “If you prefer to contribute translations directly to the repository…”.

Suggested diff:

- If you would prefer to contribute translations directly to the repository, the translations are stored in the [`packages/studiocms/src/lib/i18n/translations`](https://github.com/withstudiocms/studiocms/tree/main/packages/studiocms/src/lib/i18n/translations/) directory. You can find the English translations in the [`en.json`](https://github.com/withstudiocms/studiocms/blob/main/packages/studiocms/src/lib/i18n/translations/en.json) file.
+ If you prefer to contribute translations directly to the repository, the translations are stored in the [`packages/studiocms/src/lib/i18n/translations`](https://github.com/withstudiocms/studiocms/tree/main/packages/studiocms/src/lib/i18n/translations/) directory. You can find the English translations in the [`en.json`](https://github.com/withstudiocms/studiocms/blob/main/packages/studiocms/src/lib/i18n/translations/en.json) file.
🧰 Tools
🪛 LanguageTool

[grammar] ~24-~24: Consider removing ‘would’. (Usually, ‘would’ does not occur in a conditional clause, unless to make a request or give a polite order.)
Context: ...an add it within the dashboard. If you would prefer to contribute translations directly to ...

(CONDITIONAL_CLAUSE)

src/content/docs/ko/contributing/translations.mdx (1)

20-20: Localize the image alt text for consistency.

The alt attribute for the translation status badge remains in English (“Translation status”). For the Korean page, translate it (e.g., alt="번역 상태") to improve accessibility and consistency.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bca23c3 and 8ecb171.

📒 Files selected for processing (2)
  • src/content/docs/en/contributing/translations.mdx (1 hunks)
  • src/content/docs/ko/contributing/translations.mdx (1 hunks)
🧰 Additional context used
🪛 LanguageTool
src/content/docs/en/contributing/translations.mdx

[grammar] ~24-~24: Consider removing ‘would’. (Usually, ‘would’ does not occur in a conditional clause, unless to make a request or give a polite order.)
Context: ...an add it within the dashboard. If you would prefer to contribute translations directly to ...

(CONDITIONAL_CLAUSE)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Run Starlight Link Check

@Adammatthiesen Adammatthiesen merged commit f18827c into withstudiocms:main Apr 18, 2025
8 checks passed
@jsparkdev jsparkdev deleted the trans branch April 18, 2025 13:49
Adammatthiesen pushed a commit that referenced this pull request Apr 18, 2025
ArmandPhilippot added a commit to ArmandPhilippot/studiocms-docs that referenced this pull request Apr 19, 2025
Adammatthiesen added a commit that referenced this pull request Apr 20, 2025
* start of beta.16 docs

* add updated label in sidebar

* add run to npm command

* add new guides

* update translations

* add upgrade docs

* link to self-hosted guide

* update links

* add skip2 to sidebar

* update landing page video

* add: translations mini guide

* fix link

* update file structure

* update badge

* add process info and notes

* update

* remove unused dep

* fix changelogs

* cleanup

* update

* add sort order

* collapse the version guides by default

* relocate files

* update

* update links

* disable edit url for release notes

* fix

* update to pre-released versions

* Update guides descriptions and guide index

* add badge

* update

* fix spelling

* update deps

* update

* fix cap

* update

* test

* latest guide system

* attempt fix

* update lunaria

* fix?

* add exclude rule

* add note with coolify gist

* fix file structure

* add note

* update link

* make more dynamic

* update url

* update submodule to main

* update

* fix knip

* update

* update to use new studiocms add command

* Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* cleanup

* update

* Update src/content/docs/en/how-it-works/cli.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/en/guides/contributing/translations.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* remove old link plugin

* fix

* fix wording

* feat: specify that Crowdin is used for packages

Co-authored-by: Adam Matthiesen <amatthiesen@outlook.com>

* Apply suggestions from code review

Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>

* Update src/content/docs/en/guides/contributing/translations.mdx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* i18n(ko-KR): create `how-it-works/index.mdx` (#88)

* i18n(ko-KR): create `sdk.mdx` (#89)

* i18n(ko-KR): create `translations.mdx` (#90)

* fix

* update packages to official release status

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
Co-authored-by: Junseong Park <39112954+jsparkdev@users.noreply.github.com>
Adammatthiesen pushed a commit that referenced this pull request Apr 20, 2025
* i18n(fr): update `contributing/translations.mdx`

See #90

* i18n(fr): update `guides/contributing/translations`

See #73 and #103

* fix badge

* fix imports...

* fix formatting (Prettier probably...)

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants