Gnosis Safe Multisig - Public Release v2.11.0

[nicosampler]

Changes

• Safe New layout (New layout #1201)
• Safe apps: Return safe tx hash (Safe apps: return safe tx hash #1245)
• Safe apps: Allow to remove a Safe-app added manually (Allow to remove a Safe-app added manually  #1260)

Bugfix

• Fix TX detail visualization (Long values break Transaction decoding UI #1281)
• Fix Etherscan link for addresses in Tx details "Actions" (Etherscan link broken #1255)
• Display abbreviated addresses as 0x1234…AbCd (Display abbreviated addresses as 0x1234…AbCd #1144)

Chore

• Fix desktop app build (Fix desktop app build #1254)
• Add Types for safe ((Feature) Types for safe #1274)

Remember NOT TO SQUASH this PR!

[ghost]

Travis automatic deployment:
https://pr1291--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1291--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1291--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1291--safereact.review.gnosisdev.com/app

[francovenica]

1 - When you submit a tx created from an app, the page remains on the app tab instead of going to the transaction tab for you to sign said transaction. This is a new behavior.
Is an issue because many apps won't clean their fields so you might think that the app submission didn't go off and you might submit again just to find 2 tx in the transaction tab.

[francovenica]

2 - When you have 2 tx pending and you sign and execute the one bellow, that one goes to the top of the table for a while. After a 20 or 30 secs the table is re rendered and the tx fixes themselves.

https://www.loom.com/share/e3ee1ae4c70f4a1f92d17297d72e1b2e

[lukasschor]

1. Staying in the Safe App is a new bahaviour introduced in Safe apps: return safe tx hash #1245

[francovenica]

1. Staying in the Safe App is a new bahaviour introduced in Safe apps: return safe tx hash #1245

If this is the case then should we clean the inputs in the apps? or is something that every app dev team should do on their own? Also, with that behavior it seems the app didn't do anything because nothing changes when you sign

[mmv08]

1. Staying in the Safe App is a new bahaviour introduced in Safe apps: return safe tx hash #1245

If this is the case then should we clean the inputs in the apps? or is something that every app dev team should do on their own? Also, with that behavior it seems the app didn't do anything because nothing changes when you sign

This is something safe apps devs have to do

[ghost]

Travis automatic deployment:
https://pr1291--safereact.review.gnosisdev.com/app

[mmv08]

@francovenica I made a quick ix for the issue 2. Could you please retest?

@fernandomg the problem is that in processTransaction.ts (this action is meant to be executed on an already existing tx) it doesn't use variables we already have like submissionDate, confirmations, etc when mocking a transaction. Probably we can do some refactor there, properly type the action while keeping in mind that we already have a transaction

[ghost]

Travis automatic deployment:
https://pr1291--safereact.review.gnosisdev.com/app

[francovenica]

1 - Ok, I see that the fields clear after using the app. Is fine

2 - For this one the tx mock doesn't jump to the top anymore which is fine, but we lost the "Pending" tag with the loading icon. Also sometimes happens when you sign 2 transactions that the second one, while the tx is being mined, the tag becomes "awaiting your confirmation" and you have the "Confirm" button next to your address instead of the "pending" tag.
https://www.loom.com/share/c083b4c0178e494b83cb40df70774310

[mmv08]

@lukasschor is this one good to go with issue 2)?

[lukasschor]

For me it's fine merging this PR and creating issue 2) as a bug ticket (with high priority)