Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

WA-238 - Withdraw ETH#21

Merged
apanizo merged 150 commits intodevelopmentfrom
feature/WA-238-withdraw-eth
Jun 6, 2018
Merged

WA-238 - Withdraw ETH#21
apanizo merged 150 commits intodevelopmentfrom
feature/WA-238-withdraw-eth

Conversation

@apanizo
Copy link
Contributor

@apanizo apanizo commented Apr 26, 2018 •
edited
Loading

This PR is going to be the main one where smaller ones will be merged. This PR has been divided into:

  • [PR - Merged] Refactor safe route layout component for giving extra space for user interaction
  • [PR - Merged] Add Daily Limit info on all routes related with Safe
  • [PR - Merged] Deploy safe using ProxyFactory and include DailyLimitExtension
  • [PR - Merged]: Add Withdrawn Form component and its execution's logic for withdrawns under dailyLimit (basic way)
  • [PR - Merged]: Include logic for handling dailyLimit in the user interface (showing max to spend, updating redux data without mocks....)
  • [PR - Merged]: PR updating contracts to the latest version, and loading safes by users (basically I need this refactor to allow owners who have not created the safe being able to log in)
  • [PR - Merged]: Safe multisig txs in localstorage mocking the future backend's webservice
  • [PR - Merged]: Created actions for connecting and transferring data from the mocked backend service into redux
  • [PR - Merged]: Create UI for adding (via form) and listing multisig transactions taking advantage of mocked endpoint and redux actions created before
  • [PR - Merged]: Implement logic for confirming and executing txs using mocked webservice. Adap the UI accordingly.
  • [PR - Merged]: Final PR reviewing and adjusting everything in order to fulfil ticket's requirements.
  • [PR - Merged]: Extra PR for checking the status of each transaction.

@apanizo
Copy link
Contributor Author

apanizo commented Apr 26, 2018

Travis automatic deployment:
https://staging-21-pr-94-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-21-pr-94-safe-react-gnosis.surge.sh

@apanizo apanizo requested a review from germartinez April 26, 2018 06:15
@apanizo
Copy link
Contributor Author

apanizo commented Apr 27, 2018

Travis automatic deployment:
https://staging-21-pr-479-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-21-pr-479-safe-react-gnosis.surge.sh

@apanizo apanizo added the WIP label Apr 27, 2018
@apanizo
Copy link
Contributor Author

apanizo commented May 31, 2018

Travis automatic deployment:
https://staging-21-pr-290-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-21-pr-290-safe-react-gnosis.surge.sh

@apanizo
Copy link
Contributor Author

apanizo commented May 31, 2018

Travis automatic deployment:
https://staging-21-pr-87-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-21-pr-87-safe-react-gnosis.surge.sh

apanizo added 17 commits May 31, 2018 14:57
@apanizo
WA-238 Removing old contracts
74f3758
@apanizo
WA-238 Bringing back safe-contracts
060a708
@apanizo
WA-238 Init contracts for test mode only used in travis
52203bc
@apanizo
Merge pull request #33 from gnosis/feature/WA-238-run-tests-in-travis
8da8071 
WA-238 Adding migrations folder and modifyin test script
@apanizo
WA-238 calculating gas and gasPrice when creating safe
a759328
@apanizo
WA-238 Silence tests' output
23f0af9
@apanizo
WA-238 Created DOM test for multisig tx on safe with 3 owners with 3 …
acfa2f4 
…as threshold
@apanizo
WA-238 Adding tests helper for checking multisig tx with safes with 1…
9c21fb8 
…+ owners
@apanizo
WA-238 Adding DOM test for 1 safe with 3 owners and 1 threshold
d31dc60
@apanizo
WA-238 Refactoring 3 owners 3 threshold DOM test
ddf43fc
@apanizo
Merge pull request #34 from gnosis/feature/WA-238-simulating-multisig…
b1177b1 
…-tx-of-safe-3-owners

WA-238 DOM Tests simulating multisig TXs of 3 owners safe
@apanizo
WA-238 Adding gasStation and pre calculation of costs to withdrawn txs
d7ff250
@apanizo
WA-238 disable Withdrawn button
e10828e
@apanizo
WA-238 increasing time in tests for updating UI after creating a safe
2018938
@apanizo
WA-238 Increasing time for rendering the Withdrawn component
504e078
@apanizo
WA-238 Give more time to safe to show the received balance in tests
9b582f6
@apanizo
Merge pull request #32 from gnosis/feature/WA-238-withdrawn-blockchai…
46a1737 
…n-requirements

WA-238 Blockchain requirements
@apanizo
Copy link
Contributor Author

apanizo commented Jun 4, 2018

Travis automatic deployment:
https://staging-21-pr-128-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-21-pr-128-safe-react-gnosis.surge.sh

@apanizo apanizo merged commit 5db96a8 into development Jun 6, 2018
@apanizo apanizo deleted the feature/WA-238-withdraw-eth branch June 6, 2018 08:50
@apanizo apanizo removed the WIP label Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@germartinez germartinez germartinez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apanizo @germartinez