Closed
Conversation
fixes audit issue 6
## fixes adit issue 8 Disallows re-using the same token symbol or name. Empty names and symbols are always allowed.
Fixes audit issue #10
### Fixes audit issue 7.
## fixes audit issue 11
## fixes audit issue 12
addresses audit issue 15
## fixes audit issue 13 Disallows manager changes after a pool has been moved to refunding or destroying.
rflechtner
commented
Mar 13, 2025
## fixes KILTProtocol/ticket#3813
Following recommendations by OAK, this adds another event to be emitted on calling `reset_team`. This is emitted in addition to the events emitted by the assets pallet itself.
## re/ KILTProtocol/ticket#3800 Addresses potential centralisation concerns around excessive manager permissions. If set to `false` the reset_team() transaction cannot be used on this pool, in which case the manager has much more limited privileges (locking/unlocking and initiating refunding). This flag can only be set on pool creation and not changed.
rflechtner
force-pushed
the
audit-issue-1
branch
from
e8beb99 to
982a12e
Compare
Contributor
|
@rflechtner I think we can close this? |
Contributor
Author
Oh, yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/3796
POC for restricting curve parameters on pool creation. Makes a dry run to check that a mint to max supply would not overflow.
Checklist:
array[3]useget(3), ...)