fix(chore): Support linting for cjs

[aswinashok44]

Summary

Enable linting for cjs files throughout the project

Details

Currently cjs files are ignored from linting or manual overrides are done, as part of gemini cli standalone binary feature a new cjs file will be added as the entry point for Node SEA binary, so going forward it would be better to have linting for cjs across the project.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @aswinashok44, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables comprehensive linting support for CommonJS (.cjs) files across the project. By modifying the ESLint configuration, it ensures that all .cjs files are now subject to linting rules, with specific adjustments made to accommodate CommonJS syntax and patterns. This change improves code quality and consistency for these files.

Highlights

• ESLint Configuration Update: The ESLint configuration has been updated to explicitly include .cjs files in the linting process, ensuring broader code quality checks.
• CJS-Specific Linting Rules: A new ESLint configuration block has been introduced specifically for **/*.cjs files, setting sourceType to commonjs and disabling certain rules (e.g., no-restricted-syntax, @typescript-eslint/no-require-imports) to properly accommodate CommonJS patterns.
• Removal of Inline ESLint Directives: Existing /* eslint-disable ... */ and /* eslint-env node */ comments in .cjs files have been removed, as the new global configuration now handles their linting appropriately.

Changelog

• .github/scripts/sync-maintainer-labels.cjs
  • Removed /* eslint-disable @typescript-eslint/no-require-imports */ and /* global process, console, require */ directives.
  • Added a standard license header.
• eslint.config.js
  • Removed packages/core/src/skills/builtin/skill-creator/scripts/*.cjs from the ignore list, allowing these files to be linted.
  • Extended the files array in the main configuration to include *.cjs files for general linting.
  • Updated the files array for node-specific settings to also include *.cjs files.
  • Added a new configuration block specifically for **/*.cjs files, setting sourceType to commonjs and applying specific rule overrides (e.g., disabling no-restricted-syntax, no-console, no-empty, no-redeclare, and @typescript-eslint/no-require-imports, and adjusting @typescript-eslint/no-unused-vars).
• packages/core/src/skills/builtin/skill-creator/scripts/init_skill.cjs
  • Removed /* eslint-env node */ directive.
  • Added a standard license header.
• packages/core/src/skills/builtin/skill-creator/scripts/package_skill.cjs
  • Removed /* eslint-env node */ directive.
  • Added a standard license header.
• packages/core/src/skills/builtin/skill-creator/scripts/validate_skill.cjs
  • Removed /* eslint-env node */ directive.
  • Added a standard license header.

Activity

• The pull request was created by aswinashok44 with the title "fix(chore): Support linting for cjs" and a summary indicating the goal to enable linting for cjs files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables ESLint for .cjs files across the project, which is a great improvement for code consistency. The changes correctly update the ESLint configuration to include these files and remove outdated eslint-disable comments. I've found one area for improvement in eslint.config.js where the configuration for .cjs files is split across two blocks, creating redundancy. I've left a suggestion to consolidate this for better maintainability.