Properly parse at-commands with narrow non-breaking spaces

[scidomino]

Summary

Properly parse at-commands with narrow non-breaking spaces.

Details

Mac default screenshots have default filenames that include a narrow non-breaking space.

Related Issues

For #17135

How to Validate

Drag and drop a default screenshot in macos.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of @ commands within the CLI, specifically addressing an issue where file paths containing narrow non-breaking spaces (NNBSP) were not correctly parsed or highlighted. By introducing a standardized regular expression for identifying @ command paths and applying it consistently across both the command processing and UI highlighting logic, the system now offers more robust and accurate recognition of file references, improving the overall user experience when dealing with diverse file naming conventions.

Highlights

• Improved @ command parsing: The logic for parsing @ commands has been refactored to use a more robust regular expression, AT_COMMAND_PATH_REGEX_SOURCE, which correctly identifies file paths containing Unicode characters like narrow non-breaking spaces (NNBSP).
• Consistent @ command highlighting: The UI highlighting mechanism for @ commands now utilizes the same AT_COMMAND_PATH_REGEX_SOURCE, ensuring that file paths with NNBSP are consistently recognized and highlighted in the user interface.
• Enhanced test coverage: New test cases have been added to verify that both the @ command processing and UI highlighting functions correctly handle file paths containing narrow non-breaking spaces.

Changelog

• packages/cli/src/ui/hooks/atCommandProcessor.test.ts
  • Added a new test case to validate the correct handling of file paths containing narrow non-breaking spaces (NNBSP) in @ commands.
• packages/cli/src/ui/hooks/atCommandProcessor.ts
  • Introduced AT_COMMAND_PATH_REGEX_SOURCE to define a consistent and robust regex for parsing @ command paths, allowing Unicode characters like NNBSP.
  • Refactored parseAllAtCommands to use the new AT_COMMAND_PATH_REGEX_SOURCE for more accurate and simplified parsing of @ commands.
• packages/cli/src/ui/utils/highlight.test.ts
  • Added a new test case to ensure that file paths with narrow non-breaking spaces (NNBSP) are correctly highlighted in the UI.
• packages/cli/src/ui/utils/highlight.ts
  • Updated HIGHLIGHT_REGEX to incorporate AT_COMMAND_PATH_REGEX_SOURCE, ensuring consistent highlighting of @ commands, including those with NNBSP in file paths.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses an issue with parsing @ commands that contain non-ASCII whitespace, such as the narrow non-breaking space. The refactoring from manual character-by-character parsing to a centralized, robust regular expression in atCommandProcessor.ts is a significant improvement in both correctness and maintainability. The included comment regarding a subtle pre-existing bug in handling escaped @ characters (e.g., \\@file.txt) is valid and addressing it would further improve the robustness of the at-command parsing.

[github-actions]

Size Change: -631 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.9 MB	-631 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[jacob314]

previous code was simple and straightforward to follow while new code is a cryptic regex. Can we apply the fix but avoid adding a regex

[scidomino]

We can't. Because we need to use the same logic in the highlight.ts regex to make sure we highlight precisely the same things that we recognize as an atCommand. Part of the bug was that the highlight regex was badly approximating the code that was in this function.

Also, personally, I find the regex easier to reason about than the previous code (even if the regex itself is a bit more opaque).

[jacob314]