fix(cli): suppress unhandled AbortError logs during request cancellation

[euxaristia]

Fixes #22613

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CLI's robustness and user experience by gracefully handling expected AbortError instances that occur during request cancellations. It also optimizes background cleanup operations to improve startup performance and ensure errors in these tasks are logged without interrupting the main process.

Highlights

• Suppress AbortError Logs: Implemented a mechanism to suppress unhandled AbortError logs, which are expected during user-initiated request cancellations (e.g., pressing ESC). This prevents these non-critical errors from cluttering logs and triggering debug consoles.
• Improved Background Task Handling: Refactored background cleanup tasks to run asynchronously without blocking startup, adding individual error handling to log any failures gracefully.
• New Test Case: Added a new test case to verify that AbortError instances are correctly suppressed and do not trigger error logging or debug console openings.

Changelog

• packages/cli/src/gemini.test.tsx
  • Added a new test case to ensure AbortError is suppressed and not logged as an error.
  • Verified that a specific log message indicating suppression is recorded when an AbortError occurs.
• packages/cli/src/gemini.tsx
  • Introduced a conditional check in the unhandledRejection handler to identify and suppress AbortError instances.
  • Logged a message indicating that an AbortError has been suppressed instead of treating it as a critical error.
  • Modified the main function to run background cleanup tasks (cleanupCheckpoints, cleanupToolOutputFiles, cleanupBackgroundLogs) individually without Promise.all.
  • Added .catch() blocks to each background cleanup function to log any errors encountered during their execution, preventing unhandled promise rejections.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly suppresses unhandled AbortError logs that can occur during user-initiated request cancellations, and adds a corresponding test to validate the fix. Additionally, it introduces a startup performance optimization by executing cleanup tasks in the background. While the optimization is beneficial, it is unrelated to the primary bug fix. I've added a comment suggesting that this optimization be moved to a separate pull request, aligning with repository guidelines and established rules for focused pull requests.

[gemini-cli]

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383).

We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'.

This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community!

[cocosheng-g]

@euxaristia, apologies for the bot closing this PR! We have reopened it. Please sync your branch to the latest main and we will have someone review it shortly.

[cocosheng-g]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the setupUnhandledRejectionHandler in the CLI to suppress AbortError exceptions, which are expected when a user cancels a request. Instead of triggering a critical error report, these rejections are now logged as debug information. A corresponding unit test was added to ensure AbortError is correctly handled and suppressed. I have no feedback to provide.