fix(core): preserve shell execution config fields on update

[jasonmatthewsuhari]

Fixes #25112

Summary

• preserve existing ShellExecutionConfig fields when updating interactive shell dimensions
• add a regression test covering sandboxConfig and backgroundCompletionBehavior

Why

Config.setShellExecutionConfig() was rebuilding the object from a stale subset of fields. In current main, the interactive UI updates shell dimensions during normal operation, so this could silently drop runtime shell fields like sandboxConfig and backgroundCompletionBehavior after startup.

Testing

• npm run test --workspace @google/gemini-cli-core -- src/config/config.test.ts

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where updating interactive shell dimensions would inadvertently overwrite other runtime shell configuration fields. By modifying the configuration update logic to preserve existing state, the system now maintains consistency for critical settings like sandbox configurations and background completion behaviors during runtime.

Highlights

• Configuration Persistence: Updated setShellExecutionConfig to use the spread operator, ensuring existing configuration fields are preserved during updates.
• Regression Testing: Added a new test case in config.test.ts to verify that sandboxConfig and backgroundCompletionBehavior remain intact after shell dimension updates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the setShellExecutionConfig method in the Config class to ensure that existing configuration fields are preserved when updating specific properties. This is achieved by spreading the current configuration object before applying new values. Additionally, a unit test has been added to verify that fields not targeted by the update remain unchanged. I have no feedback to provide.

[SH20RAJ]

One follow-up improvement: setShellExecutionConfig still accepts a full ShellExecutionConfig, but the code is really using it as a partial update. Consider changing the parameter to Partial<ShellExecutionConfig> or introducing a dedicated update type. That would make the API match the behavior and reduce the chance of future callers assuming every field must be supplied.