feat(cli): enable mouse clicking for cursor positioning in AskUser multi-line answers

[Adib234]

Summary

Enables users to position the cursor using mouse clicks within the multi-line TextInput component, specifically addressing the issue where clicking doesn't work in the AskUser tool when in alternate buffer mode.

Details

• Modified packages/cli/src/ui/components/shared/TextInput.tsx to include a container ref and the useMouseClick hook.
• Added logic to map screen coordinates to logical buffer positions via buffer.moveToVisualPosition.
• Updated unit tests in TextInput.test.tsx to support ConfigContext and mock mouse events.
• Refreshed snapshots for AskUserDialog.test.tsx to reflect visual layout changes.

Related Issues

Fixes #18910

How to Validate

1. Start the CLI in alternate buffer mode: npm run start -- --alternate-buffer
2. Trigger the ask_user tool with a text type question (e.g., "Ask me for a multi-line project description").
3. Type at least 3 lines of text.
4. Click on different lines/columns and verify the cursor jumps to the correct position.

Pre-Merge Checklist

• Added/updated tests
• Validated on required platforms/methods:
  • MacOS
    • npm run

[github-actions]

Size Change: +1.23 kB (0%)

Total Size: 34.1 MB

Filename	Size	Change
./bundle/chunk-5QH5OA4A.js	0 B	-3.54 MB (removed)	🏆
./bundle/chunk-IWJMJ65W.js	0 B	-3.8 kB (removed)	🏆
./bundle/chunk-O2CPKRMA.js	0 B	-14.9 MB (removed)	🏆
./bundle/core-767S4EZ2.js	0 B	-46.5 kB (removed)	🏆
./bundle/devtoolsService-FAPNKVYS.js	0 B	-28.4 kB (removed)	🏆
./bundle/gemini-RB6EBDCZ.js	0 B	-553 kB (removed)	🏆
./bundle/interactiveCli-74VRSG7V.js	0 B	-1.29 MB (removed)	🏆
./bundle/oauth2-provider-4YD5GUGR.js	0 B	-9.16 kB (removed)	🏆
./bundle/chunk-6EHLNT4K.js	3.55 MB	+3.55 MB (new file)	🆕
./bundle/chunk-7OZW5OU7.js	14.9 MB	+14.9 MB (new file)	🆕
./bundle/chunk-MHS6EN7N.js	3.8 kB	+3.8 kB (new file)	🆕
./bundle/core-WUPIDIFW.js	46.5 kB	+46.5 kB (new file)	🆕
./bundle/devtoolsService-FRJQK43E.js	28.4 kB	+28.4 kB (new file)	🆕
./bundle/gemini-336XQGIL.js	553 kB	+553 kB (new file)	🆕
./bundle/interactiveCli-DNYKE2J6.js	1.29 MB	+1.29 MB (new file)	🆕
./bundle/oauth2-provider-FU4ZVTIK.js	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
./bundle/bundled/third_party/index.js	8 MB	0 B
./bundle/chunk-34MYV7JD.js	2.45 kB	0 B
./bundle/chunk-5AUYMPVF.js	858 B	0 B
./bundle/chunk-5PS3AYFU.js	1.18 kB	0 B
./bundle/chunk-664ZODQF.js	124 kB	0 B
./bundle/chunk-DAHVX5MI.js	206 kB	0 B
./bundle/chunk-IUUIT4SU.js	56.5 kB	0 B
./bundle/chunk-QM5IP3NK.js	1.97 MB	0 B
./bundle/chunk-RJTRUG2J.js	39.8 kB	0 B
./bundle/cleanup-TA2H66X6.js	0 B	-932 B (removed)	🏆
./bundle/devtools-36NN55EP.js	696 kB	0 B
./bundle/dist-T73EYRDX.js	356 B	0 B
./bundle/events-XB7DADIJ.js	418 B	0 B
./bundle/gemini.js	4.97 kB	0 B
./bundle/getMachineId-bsd-TXG52NKR.js	1.55 kB	0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js	1.55 kB	0 B
./bundle/getMachineId-linux-SHIFKOOX.js	1.34 kB	0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js	1.06 kB	0 B
./bundle/getMachineId-win-6KLLGOI4.js	1.72 kB	0 B
./bundle/memoryDiscovery-MYQ3ZWKM.js	980 B	0 B
./bundle/multipart-parser-KPBZEGQU.js	11.7 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	222 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	229 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	13.4 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B
./bundle/src-QVCVGIUX.js	47 kB	0 B
./bundle/tree-sitter-7U6MW5PS.js	274 kB	0 B
./bundle/tree-sitter-bash-34ZGLXVX.js	1.84 MB	0 B
./bundle/cleanup-OJ5BTX6I.js	932 B	+932 B (new file)	🆕

_{compressed-size-action}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces mouse interaction capabilities to the multi-line TextInput component. By enabling users to click within the terminal interface to position the cursor, it significantly improves the usability of the AskUser tool when operating in alternate buffer mode. The changes include necessary hook integrations and comprehensive updates to the existing test suite to ensure stability and correct behavior.

Highlights

• Mouse Click Support: Enabled mouse clicking for cursor positioning within the multi-line TextInput component when in alternate buffer mode.
• Component Integration: Updated TextInput to include a container ref and the useMouseClick hook to map screen coordinates to logical buffer positions.
• Testing Improvements: Enhanced unit tests in TextInput.test.tsx to support ConfigContext and mock mouse events, and refreshed snapshots for AskUserDialog.test.tsx.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements mouse click functionality for the TextInput component, allowing users to position the cursor by clicking within the input field when it is focused and the terminal is in alternate buffer mode. The implementation involves adding a container reference to the TextInput's layout and utilizing the useMouseClick hook to trigger buffer cursor movement. Corresponding unit tests were updated to include a ConfigWrapper for context and a new test case verifying the registration of the mouse click handler, alongside necessary snapshot updates. I have no feedback to provide.

[jacob314]

Nitpick (from /review-frontend, reviewed by Jacob): In ChoiceQuestionView (AskUserDialog.tsx), the hasAll and numOptions calculations are clean, but you could extract the condition question.multiSelect && questionOptions.length > 1 to a single constant (e.g., const showAllOption = ...) to reuse it across the numbering width calculation and the actual list generation to ensure they never fall out of sync in the future.

[jacob314]

Having done be clickable immediately closing the dialog is a bit surprising

[jacob314]

Thanks for adding mouse support! This is a great usability improvement for alternate buffer mode. I have a few suggestions regarding the interaction design, performance, and our testing guidelines:

1. Mouse Listener Efficiency (BaseSelectionList)
Currently, useMouseClick is called inside SelectionListItemRow, which registers a separate mouse event listener for every visible row. It would be more efficient to register a single useMouseClick listener on the main BaseSelectionList container. You can then calculate which item was clicked by using the relativeY coordinate combined with the effectiveScrollOffset (similar to the row calculation approach you implemented in TextInput).

2. Interaction UX Suggestion: Two-Click to Submit
Regarding the immediate submission: clicking an item (like "Done" or a single-select option) and having it immediately close the dialog can be surprising UX. As an optional suggestion, consider requiring two clicks to submit: the first click would highlight the item (updating activeIndex), and a second click on the already-highlighted item would actually trigger the submission (onSelect). This gives users a chance to verify their selection before the dialog disappears.

3. Testing Guidelines: Missing act()
In packages/cli/src/ui/components/shared/BaseSelectionList.test.tsx, mouseClickHandler() is being invoked directly. According to our React testing guidelines, any test code that simulates UI events or triggers state updates must be wrapped in act(() => { ... }) from react. Even if the underlying state setters are currently mocked in the test, wrapping the handler execution ensures we don't introduce flaky tests or spurious React warnings.

Looking forward to the next iteration!

[Adib234]

Can improve mouse listener efficiency if needed but if we usually have less than 5 mouse listeners is this optimization necessary ?

[jacob314]

if the user clicks directly within the [ ] area of a checkbox we should still select it on the first click for the multi-select case.

[Adib234]

Updated to make sure that if the user directly clicks in the checkbox we select it on the first click

[jacob314]