This repository was archived by the owner on Apr 30, 2025. It is now read-only.
Merged
Conversation
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
Fix variable spelling error
…nality errors. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
…erval Set the default interval for promql to eval subqueries.
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
With us caching entries for 15mins only and doing client side validation after introducing permanent caching of older entries, this debug is expected to print for millions of keys. It's not a very useful line. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Remove a very spammy debug line
Hit this: ``` CGO_ENABLED=0 go build -ldflags "-extldflags \"-static\" -s -w" -tags netgo -o cmd/ruler/ruler ./cmd/ruler vendor/github.com/prometheus/prometheus/discovery/consul/consul.go:461:29: catalog.ServiceMultipleTags undefined (type *api.Catalog has no field or method ServiceMultipleTags) vendor/github.com/prometheus/prometheus/discovery/gce/gce.go:124:15: undefined: compute.NewService ``` So updated the GCE and Consul deps too Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Update prometheus
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
Signed-off-by: Bryan Boreham <bryan@weave.works>
By running the different test cases as the inner loop we can re-use the same store multiple times, saving a lot of CPU. Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
…change Put Distributor hash algorithm back the way it was before 922a3b9
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
…Common Update weaveworks common
…reuse-store Flip the ordering of schema, store and query so tests run faster
This is shorter, more efficient, and less surprising. Signed-off-by: Bryan Boreham <bryan@weave.works>
Combine `tableForBucket()` and `TableFor()` into one, and replace another line that did the same thing. Signed-off-by: Bryan Boreham <bryan@weave.works>
…imit Include metric name, label name, number of entries and limit in cardinality errors.
Updated table deletes to ignore empty prefixes
…el-entries Avoid duplicate label index writes by combining LabelEntryCacheKeys and LabelWriteEntries
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
Add documentation for how to configure Jaeger
The weaveworks/common already has the middleware on by default. See: https://github.com/weaveworks/common/blob/master/server/server.go#L162-L164 and weaveworks/common#126 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
While this is not super ideal, we will still catch 99% of the cases through this. Fixes: cortexproject#1450 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
…drawing New architecture drawing with alertmanager and ruler
Signed-off-by: Bryan Boreham <bryan@weave.works>
Remove redundant op name middleware.
Make sure we send a 400 for large responses.
We want the process to answer requests (including status and metrics) until it has finished shutting down. Every target depends on Server, so it will get shut down as a dependency. Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
…later Leave Server module running until end of shutdown
Signed-off-by: paliwalpriyank <paliwal.priyank2001@gmail.com>
Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
getting started: correcting remove docker network command
Return a NopIterator when bigchunk is empty
…ngester-startup Fix ingester startup with a normalised ring
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Bryan Boreham <bryan@weave.works>
…-writes Avoid writing duplicate chunks by checking the cache first
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
…roject#1471) Signed-off-by: mizeng <mizeng@ebaysf.com>
Add BenchmarkChunkQueryableFromTar
Signed-off-by: mizeng <mizeng@ebaysf.com>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.