Merged
Conversation
Add docker build
- update DJORNL parser to apply manifest file - add tests for manifest file validation - small refactor of parser to apply the same QC to every file - small formatting updates to DJORNL source files
Refactor spec files to use a definitions file Add tests for duplicated data
Add a couple more parser tests
…ar is not present and the tests require the full specs, they will be loaded.
Adding badges for LGTM and Github Actions Still need to add coverage stats.
Add manifests and refactor DJORNL parser
Add SPEC_TEST_READY env var
Add badges
Add a couple more tests for error cases. Add coverage calculation to test runs. Update readme with error structure details
Refactor test_djornl tests to put all results in the results.json file. Update djornl_fetch_* queries to ensure that empty arrays cannot be entered as query params
Standard errors
Add "additionalProperties" to stored queries
Ensure that DJORNL queries do not have additional properties
Add edge type filtering to DJORNL queries
Fix auth responses for invalid or non-admin tokens
add sample_spec_release dir and instructions for updating the test spec archive add "get_view" method to spec_loader.py and sample view to the test spec archive
Simplify code to reduce array of paths to a unique set
Patch security hole in spec_loader.py
Improve output of spec/validate.py to give more detail on errors
Improve readme for test/spec_release Add test description Improve formatting and info given by validate.py Add djornl collection schema test Add sample_spec_release dir with decompressed versions of the files in relation_engine_server/test/spec_release/spec.tar.gz Edit spec_loader.py to prevent access outside the spec dir Add tests to test_spec_loader.py to ensure correct functioning spec loader remove $schema line from stored query
Refactor json tests Remove some unneeded test files Add tests for the specific example of the default population failure Update DJORNL stored queries to a ref structure that will work when populating defaults Remove comments from file
Update deployment docs
Updating codeowners
recursive obj subsetting
query testing & split for sorting
don't restrict species search to ncbi
prep release and DATAUP-706-doc-startup
…stats Long query testing -- violin plots comparing old and new query performance
Special Chars for Fulltext Search
DEVOPS-755 Add Github Actions For Release
* Update requirements and dev requirements to fix markup
bio-boris
approved these changes
Apr 15, 2022
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For changes to the codebase: