Silence type-check import lints for release action

[leynos]

Summary

• adopt the repository typing alias in the release-to-pypi-uv script and helper to satisfy the ICN003 import convention
• update the associated tests to import typing as typ and adjust annotations accordingly
• annotate the release scripts' Path imports as runtime dependencies and move test-only Path usage under TYPE_CHECKING to silence TC003 lint

Testing

• uvx ruff check --select TCH,UP,FA

---

https://chatgpt.com/codex/tasks/task_e_68cfe1f27f5483228e741d5bf1a256cb

Summary by Sourcery

Silence type-check import lints by adopting the repository typing alias and refining type-only imports across release action scripts and tests

Enhancements:

• Adopt the typ alias for all typing imports in scripts and tests to satisfy import lint rules
• Annotate Path imports in release scripts as runtime dependencies and guard test-only Path usage under TYPE_CHECKING
• Update test fixtures and function signatures to import and use typ.Any consistently

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Summary by CodeRabbit

• New Features

  • No user-facing changes in this release.

• Chores

  • Aligned internal typing usage and annotations across release tooling scripts.
  • Added lint suppressions/comments to clarify runtime type usage.
  • Minor control-flow hardening to ensure only valid files are processed.

• Tests

  • Standardised type hints and imports across test suites.
  • Updated fixtures and helper annotations for consistency; no behavioural changes.

• Style

  • Minor formatting and import clean-ups to improve readability.

Walkthrough

Update type annotations across scripts and tests to use typing as typ, add noqa comments for Path imports, and modify _iter_files in validate_toml_versions.py to explicitly skip non-file paths before yielding.

Changes

Cohort / File(s)	Summary of changes
Release scripts: Path import lint notes .github/actions/release-to-pypi-uv/scripts/determine_release.py, .github/actions/release-to-pypi-uv/scripts/write_summary.py	Add inline noqa comments to Path imports indicating runtime use for Typer CLI types; no runtime changes.
Validate TOML versions: iterator filtering .github/actions/release-to-pypi-uv/scripts/validate_toml_versions.py	Import typing as typ; change _iter_files return annotation to typ.Iterable[Path]; update control flow to continue on non-files and yield only files.
Test helper: typing alias .github/actions/release-to-pypi-uv/tests/_helpers.py	Import typing as typ; update load_script_module return type to typ.Any.
Tests: adopt typing alias (Any → typ.Any) .github/actions/release-to-pypi-uv/tests/test_action_python_version.py, .github/actions/release-to-pypi-uv/tests/test_check_github_release.py, .github/actions/release-to-pypi-uv/tests/test_publish_release.py, .github/actions/release-to-pypi-uv/tests/test_validate_toml_versions.py, .github/actions/release-to-pypi-uv/tests/test_write_summary.py	Replace direct Any with typ.Any in imports and annotations; minor formatting tweaks; no behavioural changes. In test_check_github_release.py, adjust DummyResponse annotations and enter return type from string to concrete class.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant VT as validate_toml_versions._iter_files
  participant FS as Filesystem

  Caller->>VT: _iter_files(pattern)
  VT->>FS: glob(pattern)
  loop For each path
    alt Path is a file
      VT-->>Caller: yield Path
    else Path is not a file
      note right of VT: Skip non-file (continue)
    end
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

Typing’s cloak drapes over Any’s glow,
A typ-ed tide where clean hints flow.
Paths get notes, their purpose clear,
Files step forward, dirs disappear.
Tests nod twice, then swiftly pass—
A tidy sweep across the grass.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 2.27% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	Label the title as an accurate, focused summary of the primary change: silencing type-check import lints for the release action. Confirm that it aligns with the PR edits to adopt the repository typing alias and to annotate Path imports and related test updates. Keep the title concise and unchanged unless you want to explicitly call out the accompanying test modifications.
Description Check	✅ Passed	Treat the description as related and sufficient for this lenient check because it clearly states adopting the typing alias, guarding test-only Path imports under TYPE_CHECKING, updating tests, and includes the ruff check command used for validation. Keep the description as-is to inform reviewers of intent and verification steps. No additional detail is required for this check.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[leynos]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[sourcery-ai]

Reviewer's Guide

This PR adopts the repository typing alias and refactors type imports and annotations across the release action scripts and tests—migrating all typing references to typing as typ, updating annotations to use typ.Any/typ.Iterable, and wrapping type-only Path imports in TYPE_CHECKING guards to satisfy import lint rules.

File-Level Changes

Change	Details	Files
Unified typing alias usage and annotation updates	Replaced from typing import Any with import typing as typ Updated all function and fixture signatures to use typ.Any Changed collection annotations to typ.Iterable[Path] where applicable Refactored multiline test function definitions to group typ annotations	.github/actions/release-to-pypi-uv/tests/test_check_github_release.py .github/actions/release-to-pypi-uv/tests/test_validate_toml_versions.py .github/actions/release-to-pypi-uv/tests/test_publish_release.py .github/actions/release-to-pypi-uv/tests/test_write_summary.py .github/actions/release-to-pypi-uv/tests/_helpers.py .github/actions/release-to-pypi-uv/tests/test_action_python_version.py .github/actions/release-to-pypi-uv/scripts/validate_toml_versions.py
Isolated type-only Path imports under TYPE_CHECKING	Moved from pathlib import Path into a if typ.TYPE_CHECKING: block with no-cover pragma Ensured runtime imports only include dependencies used at execution time	.github/actions/release-to-pypi-uv/tests/test_validate_toml_versions.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and found some issues that need to be addressed.

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/actions/release-to-pypi-uv/scripts/validate_toml_versions.py:38` </location>
<code_context>


-def _iter_files(pattern: str) -> Iterable[Path]:
+def _iter_files(pattern: str) -> typ.Iterable[Path]:
     candidates = [Path(p) for p in glob.glob(pattern, recursive=True)]
     for path in candidates:
</code_context>

<issue_to_address>
**issue (review_instructions):** Import 'typ' is used without being defined or imported, which breaks DRY and readability.

You must import 'typ' or use the correct module (likely 'typing') for 'Iterable'. This is necessary for code readability and correctness.

<details>
<summary>Review instructions:</summary>

**Path patterns:** `**/*`

**Instructions:**
Keep code DRY, but readable. Use refactoring approaches best suited for the language in question. Context managers and generators for Python; RAII and macros for Rust.

</details>
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}