Fix rust host detection timeout and Windows bin path

[leynos]

Summary

• add a timeout to the rustc host triple probe and treat timeouts as falling back to the default host target
• build the llvm-mingw bin path with Join-Path to avoid embedded backslashes in the setup-windows-gnu action

Testing

• make lint

---

https://chatgpt.com/codex/tasks/task_e_68cc41dcc0b48322baaf86145d832bab

Summary by Sourcery

Improve reliability of host detection by timing out stalled rustc probes and enhance Windows setup by correctly building the llvm-mingw bin path

Bug Fixes:

• Add a 10-second timeout to the rustc host triple probe and treat timeouts as falling back to the default host target

Enhancements:

• Construct the llvm-mingw bin path using Join-Path to avoid embedded backslashes in the Windows setup action

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Implements a timeout for the Rust host triple probe (falling back to the default on timeout) and refactors the Windows setup action to use Join-Path for constructing the llvm-mingw bin path.

File-Level Changes

Change	Details	Files
Add timeout handling to rustc host triple detection	Include a 10-second timeout parameter in subprocess.run invocation Expand exception clause to catch subprocess.TimeoutExpired and return default target on timeout	.github/actions/rust-build-release/src/runtime.py
Refactor Windows llvm-mingw bin path construction	Define an intermediate $toolRoot path using Join-Path Generate $binPath by joining $toolRoot with "bin" to avoid embedded backslashes	.github/actions/setup-windows-gnu/action.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Warning

Rate limit exceeded

@leynos has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 348773b and 6b86737.

📒 Files selected for processing (2)

• .github/actions/rust-build-release/src/runtime.py (5 hunks)
• .github/actions/rust-build-release/tests/test_runtime.py (3 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Summary by CodeRabbit

• New Features
  • More robust host target detection with a bounded execution time to prevent hangs.
• Bug Fixes
  • Ensures a safe fallback to the default target when detection times out, improving reliability.
• Tests
  • Added unit tests covering timeout handling and default fallback behaviour.
• Chores
  • Minor improvement to Windows GNU setup path handling for clarity without changing behaviour.

Walkthrough

Add a 10-second timeout to rustc probing in detect_host_target, explicitly handle subprocess.TimeoutExpired, and maintain default fallback on failure. Add unit tests covering timeout behaviour and argument forwarding. Adjust a Windows action step to compute the llvm-mingw bin path via intermediate variables without changing behaviour.

Changes

Cohort / File(s)	Summary
Rust host target detection .github/actions/rust-build-release/src/runtime.py	Add timeout=10 to run_validated in detect_host_target; update exception handling to include subprocess.TimeoutExpired and remove FileNotFoundError; keep default fallback on exception.
Rust detection tests .github/actions/rust-build-release/tests/test_runtime.py	Add tests for default fallback on TimeoutExpired and for propagating timeout argument; mock environment, ensure executable allowance, and run_validated behaviour.
Windows GNU setup action .github/actions/setup-windows-gnu/action.yml	Refactor path assembly: introduce $toolRoot and derive $binPath via Join-Path; preserve effective bin path and subsequent logic.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor CI as CI Runner
  participant RT as detect_host_target
  participant RV as run_validated (rustc)
  
  CI->>RT: Invoke detect_host_target(default)
  RT->>RV: Execute rustc -vV with timeout=10
  alt Success
    RV-->>RT: stdout (host: <triple>)
    RT-->>CI: Return parsed host triple
  else subprocess.TimeoutExpired
    RV-->>RT: Raise TimeoutExpired
    RT-->>CI: Return default
  else CalledProcessError / OSError
    RV-->>RT: Raise error
    RT-->>CI: Return default
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A ten-count tick on rustc’s quest,
If time runs out, return the rest.
Tests stand guard with mock and spy,
Defaults step in when clocks run dry.
Paths on Windows walk more clean,
Same destination, tidier scene.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	State that the title succinctly summarises the two primary changes: adding a timeout to rust host detection and fixing the Windows llvm-mingw bin path construction; this directly matches the edits to .github/actions/rust-build-release/src/runtime.py and .github/actions/setup-windows-gnu/action.yml. Treat the title as concise, focused and appropriate for a reviewer scanning the project history.
Description Check	✅ Passed	State that the description clearly documents the main changes and the testing step, explicitly noting the rustc timeout and the Join-Path change for llvm-mingw and referencing lint as the test command. Treat this as directly related to the diff and therefore sufficient for the lenient description check.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey there - I've reviewed your changes and found some issues that need to be addressed.

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/actions/rust-build-release/src/runtime.py:105` </location>
<code_context>
             capture_output=True,
             text=True,
             check=True,
+            timeout=10,
         )
-    except (FileNotFoundError, subprocess.CalledProcessError, OSError):
</code_context>

<issue_to_address>
**issue (review_instructions):** Add behavioural and unit tests to cover the new timeout parameter in subprocess.run.

The addition of the timeout parameter changes the behaviour of the function. You must provide both behavioural and unit tests to verify that the timeout is handled correctly and that the appropriate exception is raised and caught.

<details>
<summary>Review instructions:</summary>

**Path patterns:** `**/*`

**Instructions:**
For any new feature or change to an existing feature, both behavioural *and* unit tests are required.

</details>
</issue_to_address>

### Comment 2
<location> `.github/actions/rust-build-release/src/runtime.py:110` </location>
<code_context>
+    except (
+        FileNotFoundError,
+        subprocess.CalledProcessError,
+        subprocess.TimeoutExpired,
+        OSError,
+    ):
</code_context>

<issue_to_address>
**issue (review_instructions):** Demonstrate handling of subprocess.TimeoutExpired with a test.

If this change is intended to fix a bug where timeouts were not previously handled, you must add a test that demonstrates the bug and verifies the fix.

<details>
<summary>Review instructions:</summary>

**Path patterns:** `**/*`

**Instructions:**
Bug fixes *must* be demonstrated by a test.

</details>
</issue_to_address>

### Comment 3
<location> `.github/actions/rust-build-release/src/runtime.py:107-112` </location>
<code_context>
def detect_host_target(
    *,
    default: str = DEFAULT_HOST_TARGET,
    rustc_path: str | Path | None = None,
) -> str:
    """Return the active Rust host triple, defaulting to *default* when unknown."""
    candidate = rustc_path or shutil.which("rustc")
    if candidate is None:
        return default
    try:
        exec_path = ensure_allowed_executable(candidate, ("rustc", "rustc.exe"))
    except UnexpectedExecutableError:
        return default
    try:
        result = run_validated(
            exec_path,
            ["-vV"],
            allowed_names=("rustc", "rustc.exe"),
            capture_output=True,
            text=True,
            check=True,
            timeout=10,
        )
    except (
        FileNotFoundError,
        subprocess.CalledProcessError,
        subprocess.TimeoutExpired,
        OSError,
    ):
        return default

    triple = next(
        (
            line.partition(":")[2].strip()
            for line in (result.stdout or "").splitlines()
            if line.startswith("host:")
        ),
        "",
    )
    return triple or default

</code_context>

<issue_to_address>
**suggestion (code-quality):** Remove redundant exceptions from an except clause ([`remove-redundant-exception`](https://docs.sourcery.ai/Reference/Default-Rules/refactorings/remove-redundant-exception/))

```suggestion
    except (subprocess.CalledProcessError, subprocess.TimeoutExpired, OSError):
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[leynos]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/actions/rust-build-release/tests/test_runtime.py (1)

222-251: Strengthen the timeout‑forwarding test with extra kwargs assertions.

Also assert capture flags and allowed_names to lock API contract.

Apply this diff within this hunk:

@@
-    call_kwargs: dict[str, object] = {}
+    call_kwargs: dict[str, object] = {}
@@
-    def fake_run(
+    def fake_run(
         executable: str,
         args: list[str],
         *,
         allowed_names: tuple[str, ...],
         **kwargs: object,
     ) -> subprocess.CompletedProcess[str]:
-        _ = (executable, args, allowed_names)
-        call_kwargs.update(kwargs)
+        _ = (executable, args)
+        call_kwargs.update(kwargs)
+        call_kwargs["allowed_names"] = allowed_names
         return subprocess.CompletedProcess(
             [executable, *args], 0, stdout="host: bounded\n"
         )
@@
-    assert runtime_module.detect_host_target() == "bounded"
-    assert call_kwargs.get("timeout") == 10
+    assert runtime_module.detect_host_target() == "bounded"
+    assert call_kwargs.get("timeout") == 10
+    assert call_kwargs.get("capture_output") is True
+    assert call_kwargs.get("text") is True
+    assert call_kwargs.get("check") is True
+    assert call_kwargs.get("allowed_names") == ("rustc", "rustc.exe")

♻️ Duplicate comments (1)

.github/actions/rust-build-release/tests/test_runtime.py (1)

194-220: Timeout path test: LGTM and addresses prior request.

Exercise TimeoutExpired → default fallback as previously requested by the bot.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7949bb and 348773b.

📒 Files selected for processing (3)

• .github/actions/rust-build-release/src/runtime.py (1 hunks)
• .github/actions/rust-build-release/tests/test_runtime.py (1 hunks)
• .github/actions/setup-windows-gnu/action.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 120000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Sourcery review

🔇 Additional comments (1)

.github/actions/setup-windows-gnu/action.yml (1)

57-58: Use Join-Path for bin path: LGTM.

Eliminate backslash escaping and path concatenation pitfalls. Behaviour unchanged.