Mark Windows smoke tests as xfail#94
Merged
leynos merged 2 commits intopython-lib-release-actionfrom Sep 20, 2025
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds an xfail marker to Windows smoke tests to treat known failures as expected on Windows runners and links to the tracking issue. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- You should also apply the WINDOWS_ONLY skip mark to the “-pc-windows-msvc” target so it doesn’t try to run on Linux (currently only gnu is skipped).
- Consider adding strict=True to the xfail marker so that if the Windows smoke tests ever start passing, CI will flag the unexpected pass.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You should also apply the WINDOWS_ONLY skip mark to the “-pc-windows-msvc” target so it doesn’t try to run on Linux (currently only gnu is skipped).
- Consider adding strict=True to the xfail marker so that if the Windows smoke tests ever start passing, CI will flag the unexpected pass.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
Author
|
@coderabbitai please create a new GitHub issue for the following, including any suspected root cause and potential fix: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@leynos I've created a GitHub issue for the MSYS2 setup failure. The problem is that the The root cause appears to be improper handling of comments in the package list construction. The fix would involve either removing comments from the command line arguments or restructuring how the package list is defined to avoid this shell quoting issue. 🏁 Script executed: Length of output: 44 🏁 Script executed: Length of output: 3131 🏁 Script executed: Length of output: 84 🏁 Script executed: Length of output: 0 🏁 Script executed: Length of output: 50 @leynos I've successfully created GitHub issue #95 for the MSYS2 setup failure. After examining the code, I found the exact root cause: in install: >-
mingw-w64-x86_64-toolchain
mingw-w64-x86_64-gcc-libs
# Optional: install cross linkers if you want GCC-based aarch64
# aarch64-w64-mingw32-gcc is not always present on msys2; prefer
# clang via llvm-mingw instead.The problem is that in YAML folded scalars, text starting with The fix is to move the comments outside the |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
Owner
Author
|
@coderabbitai please create a new GitHub issue for the following: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@leynos I've successfully created GitHub issue #96 for the Podman timeout failure. After examining the code, I found that the issue occurs when the The problem is that while Docker works fine on the GitHub Actions runner, Podman appears to be installed but non-functional. The current code doesn't handle this gracefully - any timeout causes the entire workflow to fail. The recommended solution is to modify the error handling in 🏁 Script executed: Length of output: 3314 🏁 Script executed: Length of output: 804 🏁 Script executed: Length of output: 50 @leynos I've successfully created GitHub issue #96 for the Podman timeout failure: #96 After examining the The fix is straightforward - modify the exception handling in try:
result = run_validated(
exec_path,
["info"],
allowed_names=(name, f"{name}.exe"),
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
timeout=10,
cwd=cwd,
)
except (OSError, subprocess.TimeoutExpired): # Add TimeoutExpired here
return FalseThis simple change will treat Podman timeouts as "runtime unavailable" rather than fatal errors, allowing the workflow to continue with Docker support. |
leynos
added a commit
that referenced
this pull request
Sep 21, 2025
* Mark Windows smoke tests as xfail * Tighten Windows smoke test expectations
leynos
added a commit
that referenced
this pull request
Sep 21, 2025
* Mark Windows smoke tests as xfail * Tighten Windows smoke test expectations
leynos
added a commit
that referenced
this pull request
Sep 22, 2025
* Mark Windows smoke tests as xfail * Tighten Windows smoke test expectations
leynos
added a commit
that referenced
this pull request
Sep 23, 2025
* Mark Windows smoke tests as xfail * Tighten Windows smoke test expectations
leynos
added a commit
that referenced
this pull request
Sep 24, 2025
* Mark Windows smoke tests as xfail * Tighten Windows smoke test expectations
leynos
added a commit
that referenced
this pull request
Sep 24, 2025
* Add release-to-pypi-uv composite action * Document trusted publishing permissions * Clarify GH_TOKEN handling in README * Fix local usage example * Improve GitHub release error handling * Fix cmd_utils discovery in publish script * Skip more build caches * Fail fast on TOML parse errors * Format release summary output * Add no-tag error test * Test TOML parse failures * Make uv python version configurable * Document concurrency guard in usage * Address review feedback with retries and tests * Improve TOML version validation and test strategy Extends boolean parsing to support more truthy values when validating dynamic version flags in TOML files. Refactors tests to run in-process with better coverage of various flag values and scenarios, replacing subprocess-based tests for efficiency and detail. Updates action to simplify Python version handling with uv and improves path detection for testing. These changes make validation logic more robust and enhance test reliability. * Add cmd-mox users guide * Use cmd-mox to stub rust build command tests (#92) * Use cmd-mox for rust build command tests * Guard cmd-mox integration on Windows * Refactor cmd-mox helpers into shared conftest * Apply cmd-mox fake which simplification * Mark Windows smoke tests as xfail (#94) * Mark Windows smoke tests as xfail * Tighten Windows smoke test expectations * Address reviewer feedback for release-to-pypi-uv action (#98) * Address review comments for release to PyPI action * Add tests and docs for python-version handling * Fix cmd_mox fixture usage and expose dev extra (#101) * Fix cmd_mox fixture usage and expose dev extras * Remove pyproject optional dev extra * Remove Pyright configuration * Add missing docstrings to release-to-pypi-uv modules (#103) * Silence type-check import lints for release action (#104) * Add toolchain-specific cargo cache key and clean shellstub imports (#88) * Address review feedback for shellstub imports * Fix MSYS2 install comments breaking pacman (#89) * Fix MSYS2 install comments breaking pacman * Fix Windows llvm-mingw metadata export * Handle runtime detection timeouts * Fix rust host detection timeout and Windows bin path (#91) * Fix rust host detection timeout and Windows bin path * Add timeout coverage for rust host detection * Unify runtime probe timeout configuration * test: capture rustc probe kwargs in timeout test * Remove inline comments from Windows GNU MSYS2 package list (#99) * Remove inline MSYS2 install comments * Skip nfpm steps on Windows builds * Handle nfpm packaging only for Linux * Fix Windows invocation of rust-build-release (#102) * Silence type-check import lints for release action * Adds ignore rule for Crush agent artifacts Ignores files generated by the Crush AI agent to prevent them from being tracked in version control. Adds a symlink to AGENTS.md for discovery by Crush * Format code after rebase validation to satisfy repo style checks. 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land> * fmt: extend fmt target to run ruff check --select D202,I001 --fix; apply resulting fixes 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land> --------- Co-authored-by: Payton McIntosh <pmcintosh@df12.net> Co-authored-by: Crush <crush@charm.land> * Narrow module fixtures to ModuleType (#105) * Add docstrings for release-to-pypi-uv tests and helpers (#106) * Add missing docstrings for release-to-pypi-uv tests * Simplify cmd-mox typing and streamline docstrings * Apply formatting * chore: remove unused imports across scripts and tests * style(_helpers): alphabetise __all__ tuple * tests: drop superfluous parentheses from @pytest.fixture usage --------- Co-authored-by: Payton McIntosh <pmcintosh@df12.net> * Scope type-checking imports (#111) * Scope type-checking imports * Fix lint warnings across release scripts * Clarify cargo stream capture error * ci: add lint and format checks * Install action-validator in CI lint workflow * Install bun validator packages in CI * Test full success message for matching versions (#113) * Address review comments (#116) * Address review feedback for release-to-pypi-uv actions (#112) * Address review feedback * Add CLI coverage for publish and validate scripts * Add deterministic validation tests and bunx validator checks * Update ci.yml remove unneeded step * Fix formatting * Fix Windows xfail marker removal for pytest 8 (#120) * Fix Windows xfail marker removal for pytest 8 * Tighten Windows xfail marker filtering * Handle runtime probe timeouts and expand release tests (#119) * Handle runtime probe timeouts and expand release tests * Add _probe_runtime coverage and assert timeout warnings * Expand TOML skip directories for release validation (#122) * Expand pyproject skip list handling * Strengthen TOML and runtime timeout tests * Assert cargo fallback logs podman failure * Parameterize skip-directory regression * Reinforce regression coverage for release tooling (#130) * Refine skip directory regression parameterization * Document skip directories and DRY timeout assertions * Parametrize publish index test * Refactor runtime timeout tests * Rebase onto origin/python-lib-release-action and resolve conflicts - Resolve merge in validate_toml_versions tests by standardizing module loading - Register dynamically loaded scripts in sys.modules to support reload semantics - Make toolchain triple test robust to host arch by selecting matching target - Run formatting, lint, typecheck, and tests to validate integration 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land> --------- Co-authored-by: Crush <crush@charm.land> * Harden release-to-pypi-uv workflow and regression coverage (#134) * Improve release validation jitter handling * Adjust runtime fallback host triples per platform * Make release validation deterministic and configurable * Rebase python-lib-release-action onto origin/main; resolve conflicts preserving branch intent; drop uv.lock in favor of main; fix tests and typing/lint issues; all tests pass and linters clean * Close cargo pipes when coverage stream missing (#137) * Close cargo pipes when missing * Ensure cargo pipes close on all paths * Ensure guard closes cargo pipes before exiting * Handle release script auth failure and multiline outputs (#136) * Handle release script auth failure and multiline outputs * Harden windows toolchain setup and extend runtime tests * Handle release auth errors and tweak toolchain retries * Fix cross install warning expectation (#139) * Fix cross install warning assertion * Harden cross install harness checks * Sanitize runtime probe timeout and guard actions * Refine runtime probe helpers and add timeout tests * Fix runtime probe lint findings * Share echo recorder fixture across runtime tests * Update fmt target description (#140) * Resolve rebase conflicts and align runtime tests with platform/timeouts from main while preserving branch improvements; ensure formatting passes and all tests/linters are green. 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land> --------- Co-authored-by: Payton McIntosh <pmcintosh@df12.net> Co-authored-by: Crush <crush@charm.land>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #93
Testing
https://chatgpt.com/codex/tasks/task_e_68ce8283db7c8322819f849b7008df6d
Summary by Sourcery
Mark smoke tests for Windows target triples as expected failures on Windows runners
Enhancements:
Tests: