Address review feedback for release-to-pypi-uv actions

[leynos]

Summary

• pin the release-to-pypi-uv scripts to the tested Typer minor release and decouple the publish CLI option from its programmatic API
• adjust the validate_toml_versions tests to accept optional CLI parameters when omitted
• tighten the cross install fallback test assertions to ensure the crates.io attempt happens before the git retry

Testing

• make test

---

https://chatgpt.com/codex/tasks/task_e_68d06afce5fc8322bac2a931856c9a28

Summary by Sourcery

Pin release-to-pypi-uv scripts to a fixed Typer minor version, refactor publish_release to decouple its CLI entrypoint from the core API, clean up path-extension logic, and improve related tests for cross-install fallback and TOML version validation

Enhancements:

• Pin Typer dependency to >=0.17,<0.18 across all release-to-pypi-uv scripts
• Separate CLI entrypoint from programmatic API in publish_release and add help text for the index option
• Remove redundant truthiness check in publish_release path-extension logic

Tests:

• Tighten cross-install fallback test to assert crates.io is invoked before the git retry
• Allow optional CLI parameters in validate_toml_versions tests by accepting None for missing flags

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/review-unresolved-comments-on-pr-#90

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Reviewer's Guide

Pins Typer dependencies across uv scripts, refactors the publish_release entrypoint to decouple CLI and programmatic APIs, updates tests to accept optional CLI parameters, and tightens cross-install fallback assertions.

File-Level Changes

Change	Details	Files
Pin Typer dependency to tested minor release across uv scripts	Update dependencies comment to 'typer>=0.17,<0.18' in all scripts	.github/actions/release-to-pypi-uv/scripts/publish_release.py .github/actions/release-to-pypi-uv/scripts/check_github_release.py .github/actions/release-to-pypi-uv/scripts/confirm_release.py .github/actions/release-to-pypi-uv/scripts/determine_release.py .github/actions/release-to-pypi-uv/scripts/validate_toml_versions.py .github/actions/release-to-pypi-uv/scripts/write_summary.py
Refactor publish_release to decouple CLI from programmatic API	Remove redundant candidate existence check Expand INDEX_OPTION with multi-line help definition Change main() signature to default index '' and strip whitespace Add cli() wrapper calling main() Update main block to run cli() instead of main()	.github/actions/release-to-pypi-uv/scripts/publish_release.py
Adjust validate_toml_versions tests to accept omitted CLI parameters	Change _invoke_main signature kwargs type from str to Any Update test to pass None for fail_on_dynamic instead of empty string	.github/actions/release-to-pypi-uv/tests/test_validate_toml_versions.py
Tighten cross-install fallback test assertions	Split harness.calls into first and second attempts Assert first attempt omits git/tag flags Assert second attempt includes --git, --tag, and the version tag	.github/actions/rust-build-release/tests/test_cross_install.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and found some issues that need to be addressed.

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/actions/release-to-pypi-uv/tests/test_validate_toml_versions.py:199` </location>
<code_context>
 """,
     )

-    _invoke_main(module, version="1.0.0", fail_on_dynamic="")
+    _invoke_main(module, version="1.0.0", fail_on_dynamic=None)

     captured = capsys.readouterr()
</code_context>

<issue_to_address>
**suggestion (testing):** Consider adding a test for when all optional CLI parameters are omitted.

Adding a test case with all optional CLI parameters omitted will help verify that default values are correctly applied and prevent unexpected errors.
</issue_to_address>

### Comment 2
<location> `.github/actions/release-to-pypi-uv/scripts/publish_release.py:52` </location>
<code_context>


-def main(index: str = INDEX_OPTION) -> None:
+def main(index: str = "") -> None:
     """Publish the built distributions with uv.

</code_context>

<issue_to_address>
**issue (review_instructions):** Add behavioural and unit tests for the refactored main function and CLI entrypoint.

You refactored the CLI entrypoint and changed the signature of main, but did not add or update behavioural and unit tests to cover these changes. Ensure that both types of tests are present and demonstrate the new behaviour.

<details>
<summary>Review instructions:</summary>

**Path patterns:** `**/*`

**Instructions:**
For any new feature or change to an existing feature, both behavioural *and* unit tests are required.

</details>
</issue_to_address>

### Comment 3
<location> `.github/actions/release-to-pypi-uv/scripts/publish_release.py:69` </location>
<code_context>
         run_cmd(["uv", "publish"])


+def cli(index: str = INDEX_OPTION) -> None:
+    """CLI entrypoint."""
+
</code_context>

<issue_to_address>
**issue (review_instructions):** Add behavioural and unit tests for the new cli function.

The new cli function is a feature addition and must be covered by both behavioural and unit tests. Please add tests that exercise this entrypoint and verify its behaviour.

<details>
<summary>Review instructions:</summary>

**Path patterns:** `**/*`

**Instructions:**
For any new feature or change to an existing feature, both behavioural *and* unit tests are required.

</details>
</issue_to_address>

### Comment 4
<location> `.github/actions/release-to-pypi-uv/scripts/publish_release.py:60-61` </location>
<code_context>
def main(index: str = "") -> None:
    """Publish the built distributions with uv.

    Parameters
    ----------
    index : str
        Optional package index name or URL to pass to ``uv publish``.
    """
    index = index.strip()
    if index:
        typer.echo(f"Publishing with uv to index '{index}'")
        run_cmd(["uv", "publish", "--index", index])
    else:
        typer.echo("Publishing with uv to default index (PyPI)")
        run_cmd(["uv", "publish"])

</code_context>

<issue_to_address>
**suggestion (code-quality):** Use named expression to simplify assignment and conditional ([`use-named-expression`](https://docs.sourcery.ai/Reference/Default-Rules/refactorings/use-named-expression/))

```suggestion
    if index := index.strip():
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}