Scope type-checking imports

[leynos]

Summary

• gate cmd-mox typing dependencies behind TYPE_CHECKING in conftest.py
• move the ModuleType annotations for release-to-pypi tests behind type-checking blocks to satisfy TC003

Testing

• uvx ruff check --select ICN003,TC003
• uv run --with typer --with packaging --with plumbum --with pyyaml pytest

---

https://chatgpt.com/codex/tasks/task_e_68d026396ed4832285ef8e693f20a6fd

Summary by Sourcery

Scope type-only imports behind TYPE_CHECKING, introduce a CmdMoxEnvironment protocol with a shared shim path helper for cmd-mox tests, and standardize exception raising by extracting message strings into variables across scripts and tests.

Enhancements:

• Gate type-only imports and annotations in conftest and test helpers behind TYPE_CHECKING blocks
• Add CmdMoxEnvironment protocol and a central _shim_path function to unify shim directory resolution
• Standardize exception raising by extracting error message strings into variables before raising errors in scripts and tests

[sourcery-ai]

Reviewer's Guide

This PR scopes type-only imports behind TYPE_CHECKING, refactors exception raising to extract message variables before raising, and reorganizes the cmd-mox fixture definitions by introducing a helper for shim path resolution and stronger Protocol types.

File-Level Changes

Change	Details	Files
Refactor exception raising to use a message variable	Replaced inline f-strings with a message variable before raising errors in release-to-pypi and coverage scripts Updated RuntimeError and GithubReleaseError raises in check_github_release.py, validate_toml_versions.py, run_rust.py Adjusted related tests in generate-coverage and release-to-pypi-uv to use the new message pattern	.github/actions/release-to-pypi-uv/scripts/check_github_release.py .github/actions/release-to-pypi-uv/scripts/validate_toml_versions.py .github/actions/generate-coverage/scripts/run_rust.py .github/actions/generate-coverage/tests/test_scripts.py .github/actions/release-to-pypi-uv/tests/test_check_github_release.py .github/actions/release-to-pypi-uv/tests/test_publish_release.py .github/actions/release-to-pypi-uv/tests/test_validate_toml_versions.py .github/actions/release-to-pypi-uv/tests/test_write_summary.py
Scope type-only imports behind TYPE_CHECKING	Wrapped imports of Path and ModuleType under if TYPE_CHECKING blocks Moved Protocol annotations into type-checking guards to satisfy TC003 Imported typing as t and guarded annotation-only code	conftest.py .github/actions/release-to-pypi-uv/tests/_helpers.py
Restructure cmd-mox fixture types and shim path handling	Introduced CmdMoxEnvironment Protocol and updated CmdMox to reference it Added _shim_path helper to resolve command shim paths safely Replaced direct shim_dir references in fixtures and tests with _shim_path	conftest.py .github/actions/rust-build-release/tests/test_utils.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/fix-exception-related-violations-in-tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/actions/generate-coverage/scripts/run_rust.py:163-165` </location>
<code_context>
     )
     if proc.stdout is None or proc.stderr is None:
-        raise RuntimeError("cargo output streams not captured")  # noqa: TRY003
+        message = "cargo output streams not captured"
+        raise RuntimeError(message)
     stdout_lines: list[str] = []

</code_context>

<issue_to_address>
**suggestion:** Consider including more context in the error message for cargo output streams.

Specify whether stdout or stderr is missing in the error message to make debugging easier, particularly in CI.

```suggestion
    if proc.stdout is None or proc.stderr is None:
        missing_streams = []
        if proc.stdout is None:
            missing_streams.append("stdout")
        if proc.stderr is None:
            missing_streams.append("stderr")
        message = f"cargo output streams not captured: missing {', '.join(missing_streams)}"
        raise RuntimeError(message)
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}