Expand TOML skip directories for release validation

[leynos]

Summary

• include additional transient directories in validate_toml_versions skip list
• extend the skip-directory test to cover the newly ignored paths

Testing

• make test

---

https://chatgpt.com/codex/tasks/task_e_68d197d7cdd08322be2fb4b87d6cdeab

Summary by Sourcery

Expand the TOML validation skip list to cover additional transient directories and update tests to verify the new exclusions

Enhancements:

• Extend the list of skipped directories in validate_toml_versions to include .pytest_cache, .cache, and htmlcov

Tests:

• Update skip-directory test to assert the new skip directories are ignored and covered in SKIP_PARTS

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR broadens the release validation skip list by adding additional transient directories to SKIP_PARTS and updates the corresponding tests to verify the new entries.

File-Level Changes

Change	Details	Files
Added new transient directories to the validation script’s skip list	Inserted ".pytest_cache", ".cache", and "htmlcov" into SKIP_PARTS	scripts/validate_toml_versions.py
Refactored tests to cover all ignored directories dynamically	Defined a skip_dirs set with the new entries Asserted skip_dirs is a subset of module.SKIP_PARTS Looped over each directory to write test pyproject files	tests/test_validate_toml_versions.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/action-unresolved-comments-on-pr-#90

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider parameterizing the skip-directory test so each directory case runs in isolation rather than looping in a single test invocation.
• Instead of redefining skip_dirs in the test, import SKIP_PARTS from the module directly to keep the skip-list definition DRY and avoid duplication.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider parameterizing the skip-directory test so each directory case runs in isolation rather than looping in a single test invocation.
- Instead of redefining skip_dirs in the test, import SKIP_PARTS from the module directly to keep the skip-list definition DRY and avoid duplication.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[leynos]

@coderabbitai have the following now been resolved?

• Consider parameterizing the skip-directory test so each directory case runs in isolation rather than looping in a single test invocation.
• Instead of redefining skip_dirs in the test, import SKIP_PARTS from the module directly to keep the skip-list definition DRY and avoid duplication.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find test files that might contain skip directory tests
fd -e py test

# Search for files containing SKIP_PARTS or skip-directory related tests
rg -n "SKIP_PARTS|skip.dir" --type py

# Look for test parameterization patterns
rg -n "pytest.mark.parametrize|@pytest.mark.parametrize" --type py

Length of output: 11

---

🏁 Script executed:

#!/bin/bash
# Look for test files more broadly
find . -name "*test*.py" -type f

# Search for skip-related content in all Python files
rg -n -C3 "skip.*dir|SKIP_PARTS" --type py

# Look for validate_toml_versions function and related code
rg -n -C5 "validate_toml_versions" --type py

# Check the main module structure
ls -la

# Look for any Python files that might contain the main logic
fd -e py . | head -10

Length of output: 2976

---

🏁 Script executed:

#!/bin/bash
# Check the validate_toml_versions test file specifically
cat ./.github/actions/release-to-pypi-uv/tests/test_validate_toml_versions.py

# Also look at the main validate_toml_versions module to understand SKIP_PARTS
fd -e py validate_toml_versions .github/actions/release-to-pypi-uv/

Length of output: 10540

---

🏁 Script executed:

#!/bin/bash
# Look at the main validate_toml_versions script to see SKIP_PARTS definition
cat .github/actions/release-to-pypi-uv/scripts/validate_toml_versions.py

Length of output: 4592

---

@leynos Looking at the current test implementation, neither of the suggestions have been fully resolved:

1. Test parameterization: The test_skips_files_in_ignored_directories test still uses a loop within a single test function rather than being parameterized. It currently does:

   for name in skip_dirs:
       _write_pyproject(project_root / name / "pkg", ...)

   To resolve this, the test would need to use @pytest.mark.parametrize to run each directory case in isolation.

2. DRY principle: While the test does reference module.SKIP_PARTS for validation (assert skip_dirs <= module.SKIP_PARTS), it still redefines a subset locally:

   skip_dirs = {".venv", ".mypy_cache", ".pytest_cache", ".cache", "htmlcov"}

   To resolve this, the test should use module.SKIP_PARTS directly instead of redefining the directories.

The test would need to be refactored to something like:

@pytest.mark.parametrize("skip_dir", list(module.SKIP_PARTS))
def test_skips_files_in_ignored_directories(
    project_root: Path, module: ModuleType, skip_dir: str, capsys: pytest.CaptureFixture[str]
) -> None:
    # Test each directory individually

Both suggestions remain open for implementation.