Translations update from Hosted Weblate#326
Conversation
Currently translated at 100.0% (173 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/fr/
WalkthroughThis update revises the French localization file with new and modified translation strings and introduces a Turkish localization file containing 175 keys with Turkish translations and some placeholders. The Russian localization file was also refined with updated translations and new keys. The changes focus exclusively on localization, adding support for new UI text labels and preparing the application for Turkish language support. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant LocaleManager
User->>UI: Selects language (French, Turkish, or Russian)
UI->>LocaleManager: Request localized strings
LocaleManager-->>UI: Returns strings from fr.json, tr.json, or ru.json
UI-->>User: Displays UI with selected language
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/locales/fr.json (1)
24-25: Remove obsolete locale keys for ‘upcoming_filter’ and ‘settings_hq_audio’Both
upcoming_filterandsettings_hq_audioremain in allsrc/locales/*.jsonfiles but aren’t referenced anywhere in the application—only the newupcoming_filter_lt10andsettings_audio_qualitykeys are used. Removing them will slim the bundle and prevent translators from updating dead strings.Please remove these entries across all locales:
• “upcoming_filter” at line 24 in each
src/locales/*.json
• “settings_hq_audio” at its locale-specific line (~100–110) in eachsrc/locales/*.jsonExample diff in
src/locales/fr.json:--- a/src/locales/fr.json @@ -24,7 +24,6 @@ - "upcoming_filter": "Filtrer < 10:00", "upcoming_enqueue_related": "Mettre en file d'attente les flux associés", @@ -105,7 +104,6 @@ - "settings_hq_audio": "Qualité Audio la plus grande",
🧹 Nitpick comments (1)
src/locales/fr.json (1)
68-73: French wording sounds unnatural – please double-check with a native speaker
"Basculer Supprimer"and"Démarrer la radio"read awkwardly in context.
Typical phrasing would be:- "list_remove": "Basculer Supprimer", + "list_remove": "Supprimer", - "list_radio": "Démarrer la radio", + "list_radio": "Lancer la radio",Minor, but polishing the UX text matters.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/locales/fr.json(3 hunks)src/locales/tr.json(1 hunks)
🔇 Additional comments (1)
src/locales/tr.json (1)
2-175: Confirm i18n fallback behavior for empty stringsI couldn’t find any
fallbackLocaleor similar setting in the codebase. If your i18n implementation doesn’t automatically fall back to the default (en) when a translation is an empty string, all of these entries insrc/locales/tr.jsonwill render as blank UI labels.Please:
- Verify that your runtime will fall back to the English strings on empty values
- Or, as a stop-gap, pre-fill
tr.jsonwith the English copiesFile needing review:
- src/locales/tr.json
Currently translated at 39.3% (68 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/tr/
Currently translated at 39.3% (68 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/tr/
Currently translated at 100.0% (173 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ru/
Translations update from Hosted Weblate for ytify/web.
Current translation status:
Summary by CodeRabbit