Translations update from Hosted Weblate#351
Conversation
Currently translated at 100.0% (174 of 174 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ru/
Currently translated at 95.9% (167 of 174 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/de/
WalkthroughUpdated multiple locale JSON files: added a new Dutch locale; revised German, Polish, and French translations (many list/action labels and several new keys); and applied minor whitespace/formatting fixes across several other locale files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (15)
💤 Files with no reviewable changes (10)
✅ Files skipped from review due to trivial changes (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/locales/de.json (1)
168-172: New entries look appropriate.The additions for import success feedback (line 169) and explicit sort-by options (lines 170-171) align with the PR's goal of making the UI more action-focused and descriptive. The time format clarification on line 168 ("< 10 Minuten" instead of "< 10:00") is also an improvement.
Minor stylistic note: Lines 170-171 use "anhand" (based on/by means of) which is grammatically correct but slightly less idiomatic than "nach" (by) for sorting context. Consider "Nach Titel sortieren" or "Nach Autor sortieren" if you revisit these later, though the current phrasing is acceptable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/locales/de.json(3 hunks)
🔇 Additional comments (1)
src/locales/de.json (1)
62-87: Approve collection-focused translation improvements.The changes make action descriptions more explicit and consistent, which improves UX clarity. Using "Sammlung" (collection) terminology across multiple keys and adding action verbs ("Alle abspielen" instead of "Abspielen") is a solid improvement.
One semantic change to be aware of: Line 86 shifts "Debug-Informationen" (technical debug info) to "Details einsehen" (view details), making it more user-friendly but potentially changing how power users perceive this menu item. Verify this aligns with the UI/feature intent.
Currently translated at 98.8% (172 of 174 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/pl/
Currently translated at 100.0% (174 of 174 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/de/
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/locales/de.json (1)
68-68: Minor: Slightly awkward phrasing in list_remove translation. The phrase "Umschalten Entfernen" (toggle + remove) doesn't flow as naturally in German as it could. Consider whether "Zum Entfernen aktivieren" or "Entfernung umschalten" might be more idiomatic, though this may be intentional based on context.Please verify that "Umschalten Entfernen" correctly conveys the intended UI action in the application context.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/locales/de.json(5 hunks)src/locales/nl.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/locales/nl.json
🔇 Additional comments (4)
src/locales/de.json (4)
1-178: JSON structure and syntax are valid. The translation file is well-formed with proper key-value pairs, correct comma placement, and valid JSON structure. No parsing issues detected.
62-73: Consistent terminology improvements across list actions. The list-related action labels have been reworded consistently (e.g., "Wiedergabelisten" for playlists, "Sammlung" for collections), which improves semantic clarity in the UI.
36-36: Consistent localization of "Wiedergabelisten" across filter/library contexts. Multiple keys now use the standardized term "Wiedergabelisten" for playlists, improving terminology consistency throughout the application.Also applies to: 41-41, 51-51
169-177: New translation keys added successfully. Eight new keys have been added (library_imported, list_sort_title, list_sort_author, settings_audio_quality, settings_pwa_watch, settings_prefetch, settings_enforce_piped, settings_jiosaavn, settings_reload) with appropriate German translations.Confirm that these new keys are being referenced in the codebase and that no import statements or locale loading logic needs updating to include them.
Currently translated at 100.0% (174 of 174 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/nl/
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
src/locales/de.json (2)
68-73: Several DE action labels read unidiomatic / potentially confusing (toggle/remove, sorting)
- Line 68
"Umschalten Entfernen"is hard to parse; consider"Entfernen umschalten"or just"Entfernen".- Lines 67-68 sort labels: more idiomatic would be “Nach Titel sortieren (A↔Z)” / “Nach Autor sortieren (A↔Z)”.
- "list_remove": "Umschalten Entfernen", + "list_remove": "Entfernen umschalten", - "list_sort_title": "Sortiere anhand Titel (A↔Z)", - "list_sort_author": "Sortiere anhand Autor (A↔Z)", + "list_sort_title": "Nach Titel sortieren (A↔Z)", + "list_sort_author": "Nach Autor sortieren (A↔Z)",
171-174: New DE settings labels: tone/terminology consistency
- Line 171 “Warteschlangen-Vorausholung” reads awkward; consider “Warteschlange vorladen” / “Vorausladen der Warteschlange”.
- Line 173 “Bevorzugen Sie …” shifts to formal-address phrasing; consider a neutral label like “JioSaavn für Musik bevorzugen”.
src/locales/pl.json (1)
168-169: Minor consistency: consider parentheses for sort direction
For readability/consistency with other locales, consider “Sortuj według tytułu (A↔Z)” / “Sortuj według autora (A↔Z)”.- "list_sort_title": "Sortuj według tytułu A↔Z", - "list_sort_author": "Sortuj według autora A↔Z", + "list_sort_title": "Sortuj według tytułu (A↔Z)", + "list_sort_author": "Sortuj według autora (A↔Z)",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/locales/de.json(5 hunks)src/locales/nl.json(1 hunks)src/locales/pl.json(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/locales/nl.json
| "search_filter_music_playlists": "Wiedergabelisten", | ||
| "search_filter_sort_by": "Sortieren nach", | ||
| "search_filter_date": "Datum", | ||
| "search_filter_date": "Zeit", |
There was a problem hiding this comment.
search_filter_date German meaning likely off (“Zeit” vs “Datum”)
If this filter is “Date / upload date”, “Datum” is clearer than “Zeit” (which reads like “time/duration”).
🤖 Prompt for AI Agents
In src/locales/de.json around line 43 the translation for "search_filter_date"
uses "Zeit" which conveys "time" rather than "date"; change the value to "Datum"
(or "Upload-Datum" if context requires explicitly upload date) to accurately
reflect a date filter and update any related translation keys/comments for
consistency.
| "settings_watchmode": "Videomodus", | ||
| "upcoming_filter_ytm": "YTM filtern", | ||
| "upcoming_filter_lt10": "Filter < 10 Minuten" | ||
| "upcoming_filter_lt10": "Filter < 10 Minuten", |
There was a problem hiding this comment.
upcoming_filter_lt10 format/wording inconsistent with existing filter
You already have upcoming_filter: "Filtern < 10:00" (Line 24); Filter < 10 Minuten mixes wording and format. Consider aligning to “Filtern < 10:00” or “Filtern < 10 Minuten” consistently across both keys.
🤖 Prompt for AI Agents
In src/locales/de.json around line 165, the value for "upcoming_filter_lt10"
("Filter < 10 Minuten") is inconsistent with the existing "upcoming_filter"
("Filtern < 10:00"); update "upcoming_filter_lt10" so wording and format match
the existing key — either change it to "Filtern < 10:00" to match the time
format or to "Filtern < 10 Minuten" to match the verb/wording, and apply the
chosen style consistently across both keys.
| "search_filter_music_playlists": "Playlisty", | ||
| "search_filter_sort_by": "Sortuj według", | ||
| "search_filter_date": "Data", | ||
| "search_filter_date": "Czas", |
There was a problem hiding this comment.
search_filter_date changed to “Czas” may be semantically incorrect
If this is a “Date / upload date” sort/filter, Polish “Data” is more accurate than “Czas”. If it truly means “Time”, then “Czas” is fine—worth confirming with UI context.
🤖 Prompt for AI Agents
In src/locales/pl.json around line 42, the translation "search_filter_date":
"Czas" is likely semantically wrong for a Date/upload date filter; if the UI
intends "Date" or "Upload date" change the value to "Data" (or "Data przesłania"
for upload date) instead of "Czas"; if the UI truly refers to time-of-day
confirm with designer/PO and keep "Czas". Ensure the updated key maps to the
intended UI label and run a quick UI check to verify spacing and casing.
Currently translated at 94.7% (162 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ja/
Currently translated at 60.2% (103 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ro/
Currently translated at 86.5% (148 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/pl/
Currently translated at 36.2% (62 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/tr/
Currently translated at 77.7% (133 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/bn/
Currently translated at 77.7% (133 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/hi/
Currently translated at 77.7% (133 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ur/
Currently translated at 81.8% (140 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/es/
Currently translated at 87.7% (150 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ru/
Currently translated at 77.7% (133 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ar/
Currently translated at 87.7% (150 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/de/
Currently translated at 77.7% (133 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/zh_Hans/
Currently translated at 77.7% (133 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/pt/
Currently translated at 77.7% (133 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/id/
Currently translated at 97.6% (167 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/fr/
Currently translated at 97.6% (167 of 171 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/fr/
Translations update from Hosted Weblate for ytify/web.
Current translation status:
Summary by CodeRabbit
Localization
UI
✏️ Tip: You can customize this high-level summary in your review settings.