Skip to content

Conversation

@doctoryes
Copy link
Contributor

@doctoryes doctoryes commented Jan 3, 2020

https://openedx.atlassian.net/browse/DE-1826

This stage does the following:

  • Includes a data migration to copy the values from old to new field.
  • Changes business logic to switch to using new field.
  • Deletes all code references of the old field.

Stage 1: #22692
Stage 2: this PR.
Stage 3: #22753

Testing plan detailed in https://openedx.atlassian.net/wiki/spaces/DE/pages/1065681172/Patterns+For+Renaming+Django+Model+Fields#PatternsForRenamingDjangoModelFields-RolloutPlanForCreditRequirement.orderIntheLMS

@doctoryes doctoryes requested review from a team January 3, 2020 21:23
@doctoryes doctoryes requested a review from a team as a code owner January 3, 2020 21:23
@doctoryes doctoryes requested a review from a team January 3, 2020 21:23
@doctoryes doctoryes force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_2 branch 3 times, most recently from 08282f2 to 01bfcf5 Compare January 6, 2020 22:58
@doctoryes doctoryes changed the title Rename values in SiteConfiguration (2/3) Rename values in SiteConfiguration/History (2/3) Jan 6, 2020
@doctoryes doctoryes force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_1 branch 2 times, most recently from 84ca5af to 05f2e39 Compare January 14, 2020 15:10
@doctoryes doctoryes force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_2 branch from 01bfcf5 to 659cea7 Compare January 14, 2020 15:59
@doctoryes doctoryes requested a review from a team January 14, 2020 15:59
cpennington and others added 14 commits January 28, 2020 13:18
Add ADR for relative courseware dates
BOM-897: add newrelic metrics and trace details
[TNL-7043] If vertical block content is in an iframe in the learning microfrontend app, add a base tag in the head (of the iframe document) to force links to navigate the parent window.
PROD-1184 fixed pdf loading issue in textbook
…e_to_configuration

Move devstack lms.yml and studio.yml to configuration repo
Add API to support courseware MFE
- make the font size of the description in the date widget the
  same as the title.
Do not return certificates if there is no active certificate
configuration.

PROD-1200
This patch adds compilejs
management command to be executed
on pull translations enabling
availability of js/jsx translations
for  lms/cms code.

PROD-960
inventhouse and others added 23 commits February 20, 2020 10:49
…rname instead of experiment name is easier to recognize (#23043)
Adds a simple nullable field to the UserProfile model. The only
validation done it to make sure any character saved in that field is a
digit and not a letter. We do not distiguish on a model level if the
phone number is international or not.
Improve Vertical Performance
…l Message update. We want to update the message so we can support our course team better
This was previously disabled because changing another user's password is
both not usually recommended and bypasses password policy. Here, we add
a feature flag (`ENABLE_CHANGE_USER_PASSWORD_ADMIN`) to allow
re-enabling this password change form. This allows continued use of this
functionality by clients that require it.
SE-1496 conditionally re-enable user change password form in admin
* WIP: add third-party-auth scope and usage

BOM-1264


* Fix tests now that we do permissions in a more standard way.

Rather than manually setting the permission class we previously
explicitly raised a PermissionDenied exception.  The way DRF
permissoning logic works, if we use the WWW-Authenticate header in the
highest priority auth class, it will return a 401 instead of a 403.


* Added test to make sure having permissions gives access to user mapping api

* Test new filters logic.

Ensure that the filters we add to the application access model make it
into the JWT correctly.

* quality fix

* quality fix

* disable pylint warning

* quality fix

* fix indent prob

Co-authored-by: Feanil Patel <feanil@edx.org>
Co-authored-by: Manjinder Singh <49171515+jinder1s@users.noreply.github.com>
Add button to switch to courseware MFE
The function will create a unique event id using a user and assignment
…n_siteconfiguration_values_1.1

Rename values in SiteConfiguration/History (1/3) (retry)
…-AA-33

AA-33: Function to uniquely create calendar event id for user and assignment
This stage does the following:

- Includes a data migration to copy the values from old to new field.
- Changes business logic to switch to using new field.
- Deletes all code references of the old field.
@pwnage101 pwnage101 force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_2 branch from 659cea7 to 3e65873 Compare February 21, 2020 22:01
@doctoryes doctoryes requested review from a team February 21, 2020 22:01
@doctoryes doctoryes requested a review from a team as a code owner February 21, 2020 22:01
@doctoryes doctoryes requested a review from a team February 21, 2020 22:01
@pwnage101 pwnage101 closed this Feb 21, 2020
@edx-status-bot
Copy link

Your PR has finished running tests. The following contexts failed:

  • jenkins/a11y
  • jenkins/bokchoy
  • jenkins/quality
  • jenkins/python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.