Disable oz xdai by nicosampler · Pull Request #1466 · 5afe/safe-react

nicosampler · 2020-10-12T23:30:07Z

No description provided.

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>

* Filter apps by network * add missing network

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Agustin Pane <agustin.pane@gmail.com>

* Add staging xDai deployment to travis * Add safe apps production url for xdai * Add travis rule to build xDai on master or integration branch

* fix min-height app containter and margin to info text at bottom * change css unit from % to vh Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>

github-actions · 2020-10-12T23:30:21Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-10-12T23:34:53Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	34	0
Ignored	12	N/A

Result: ✅ success
Annotations: 34 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 69 - Argument 'props' should be typed.
src/logic/cookies/utils/index.ts Line 7 - Missing return type on function.
src/logic/cookies/utils/index.ts Line 7 - Argument 'key' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Missing return type on function.
src/logic/cookies/utils/index.ts Line 21 - Argument 'key' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Argument 'value' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Argument 'expirationDays' should be typed.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Argument 'safeAddress' should be typed.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Missing return type on function.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Argument 'dispatch' should be typed.
src/logic/tokens/api/fetchTokenBalanceList.ts Line 5 - Missing return type on function.
src/logic/tokens/api/fetchTokenBalanceList.ts Line 5 - Argument 'safeAddress' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Missing return type on function.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'dispatch' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'provider' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 51 - Argument 'values' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Object pattern argument should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Argument 'network' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Argument 'controls' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Object pattern argument should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'controls' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'props' should be typed.
src/routes/open/container/Open.tsx Line 56 - Missing return type on function.
src/routes/open/container/Open.tsx Line 56 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 56 - Argument 'userAccount' should be typed.
src/routes/opening/components/Footer.tsx Line 16 - Missing return type on function.
src/routes/opening/components/Footer.tsx Line 42 - Missing return type on function.
src/routes/opening/components/Footer.tsx Line 60 - Missing return type on function.
src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Missing return type on function.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Object pattern argument should be typed.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Missing return type on function.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Object pattern argument should be typed.
src/utils/intercom.ts Line 4 - Missing return type on function.

^{Report generated by eslint-plus-action}

ghost · 2020-10-12T23:45:53Z

Travis automatic deployment:
https://pr1466--safereact.review.gnosisdev.com/app

fernandomg · 2020-10-13T13:34:02Z

@nicosampler, I don't understand the reason for this PR. Shall we keep the #1465 and close this one?

nicosampler · 2020-10-13T13:36:45Z

mmm definitely. I don't know what is this, yesterday something weird happened to me with github, seems like this PR was the outcome of that. sorry.

josipbagaric and others added 22 commits September 29, 2020 11:23

feat: Support for Volta and EWC

4d699b7

chore: Store network ID in the ETHEREUM_NETWORK enum itself

dbf0b96

chore: forward tx and address to non-etherscan explorers

a2491fe

fixes after rebase

cbd4e77

Merge branch 'development' into feature/#1353-xDai-compatibility

a211dcf

fix test, avoid assingning enum to const

580c7e9

fix typing errors

cfe727e

(Feature) [xDai] - Create network-based configurations (#1420)

6a4e353

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>

(Feature) [xDai] Use generic config (#1422)

ab2d1cf

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>

Merge branch 'development' into feature/#1353-xDai-compatibility

76fe441

fix function name after merge development

c86a0ea

(Feature) [xDai] - Contract interaction abi lookup (#1429)

5278527

Filter Apps by network (#1433)

74cb6cf

* Filter apps by network * add missing network

(Feature) [xDai] - Parametrize ethscan values (#1424)

8c16bce

(Feature) [xDai] - Use parametrized network values (#1437)

7d28efd

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Feature) [xDai] - Use tx service for loading token info (#1435)

8f85a2f

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Feature) [xDai] - Visually differentiate networks (#1431)

dc77aeb

Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Agustin Pane <agustin.pane@gmail.com>

Merge branch 'development' into feature/#1353-xDai-compatibility

7d85c5f

(Feature) [xDai] - Cosmetic fixes (#1449)

e941f1f

Add staging configuration for deployment using xDai (#1459)

8fe31d3

* Add staging xDai deployment to travis * Add safe apps production url for xdai * Add travis rule to build xDai on master or integration branch

(Bugfix) Set min height to ListContentLayout wrapper #1447 (#1451)

4d1cecf

* fix min-height app containter and margin to info text at bottom * change css unit from % to vh Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>

disable OpenZepplin in xDai

720c185

nicosampler closed this Oct 13, 2020

github-actions bot locked and limited conversation to collaborators Oct 13, 2020

nicosampler deleted the disable-oz-xdai branch October 13, 2020 13:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable oz xdai#1466

Disable oz xdai#1466
nicosampler wants to merge 22 commits intodevelopmentfrom
disable-oz-xdai

nicosampler commented Oct 12, 2020

Uh oh!

github-actions bot commented Oct 12, 2020

Uh oh!

github-actions bot commented Oct 12, 2020

Uh oh!

ghost commented Oct 12, 2020

Uh oh!

fernandomg commented Oct 13, 2020

Uh oh!

nicosampler commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nicosampler commented Oct 12, 2020

Uh oh!

github-actions bot commented Oct 12, 2020

Uh oh!

github-actions bot commented Oct 12, 2020

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Oct 12, 2020

Uh oh!

fernandomg commented Oct 13, 2020

Uh oh!

nicosampler commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants