Release v2.18.0 by dasanra · Pull Request #1771 · 5afe/safe-react

dasanra · 2021-01-13T12:52:27Z

…opment

Fix safe-react-components

…opment

* Adds shouldSafeBeUpdated to avoid updating unnecessary the safe * Fix css typing * Moves equalArrays to utils function Improves how updateSafe is dispatched within checkAndUpdateSafe to avoid unnecessary re renders * Revert some default cases fixes * Adds equalArrays tests * Add test to arrays.test.ts * Improves shouldSafeStoreBeUpdated order and renames it * Adds shouldSafeStoreBeUpdated.test.ts * Uses shouldSafeStoreBeUpdated within safe reducer * Replaces equalArrays with isEqual from lodash * Simplify shouldSafeStoreBeUpdated using isEqual from lodash * Remove lodash to compare Immutable objects correctly Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Backmerge release v2.17.0

…odal-close

…opment

Fix - Send Again modal close on its own

… into fix/balance-table-sort

Fix - Value column not sortable in Assets list

Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/mikaelbr/node-notifier/releases) - [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md) - [Commits](mikaelbr/node-notifier@v8.0.0...v8.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Bumps [axios](https://github.com/axios/axios) from 0.21.0 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.21.0...v0.21.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

ghost · 2021-01-15T15:51:47Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-15T16:07:06Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-15T16:20:27Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/volta/app

ghost · 2021-01-15T16:50:10Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-15T17:06:08Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-15T17:20:48Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/volta/app

ghost · 2021-01-15T19:46:17Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-15T20:00:15Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-15T20:13:46Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/volta/app

francovenica · 2021-01-18T15:14:11Z

@tschubotz An update regarding the relsease.

You marked the Trezor - Error trying to execute a tx #1782 (trezor failing when executing a tx) as a Major Issue, so we are trying to fix it today
The Trezor signature always show the warning that the tx will fail #1783 (Trezor always showing the warning message) should be fixed, but hasn't being merged into this release branch yet, I'll test it as soon as Dani merges it
The WallectConnect - Tx failure warning always shows when you try to sign #1784 (WC always showing the warning message) probably cannot be solved, because it seems WC won't give any information regarding the gas estimation, so we cannot calculate it like we do with other wallets, So we decided to disable the warning completely if the user is connected with WC. Not the best outcome, but the best we can do given the situation.
Also we found that the warning message is not being shown in the Tx builder modal if the tx will fail. The system is in place, is just the message not being displayed, so we have to show it. It should be a quick fix.

tschubotz · 2021-01-18T15:20:42Z

@francovenica thanks a lot for the update!

Regarding #1782, I think it's also fine to fix this for the next release. I'd let you decide whether to include it in the current one or not.

* Improves the way we parse the error message on getDataFromNodeErrorMessage for supporting trezor response * Fix trezor execution not working properly * Add parameter to processTransaction in ApproveTxModal Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

github-actions · 2021-01-18T17:08:37Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	4	0
Ignored	7	N/A

Result: ✅ success
Annotations: 4 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/forms/Field/index.tsx Line 5 - Missing return type on function.
src/components/forms/Field/index.tsx Line 5 - Object pattern argument should be typed with a non-any type.
src/logic/wallets/ethTransactions.ts Line 9 - Missing return type on function.
src/logic/wallets/ethTransactions.ts Line 9 - Argument 'hash' should be typed.

^{Report generated by eslint-plus-action}

ghost · 2021-01-18T17:17:36Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-18T17:32:52Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-18T17:46:14Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/volta/app

* Make calculateGasOf receive object param * Disable estimation of gas feature for walletConnect * Add FIXME to walletConnect estimation check Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

ghost · 2021-01-18T18:58:04Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-18T19:11:32Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-18T19:26:05Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/volta/app

francovenica

The latest issues found were fixed
The ticket listed in the description were checked
A regression was run in rinkeby
A smoke test was run in xdai and volta

Looks good for release

ghost · 2021-01-19T08:28:20Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-19T08:42:32Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-19T08:56:09Z

Travis automatic deployment:
https://pr1771--safereact.review.gnosisdev.com/volta/app

matextrem and others added 30 commits August 31, 2020 18:07

Bump new onboard.js version

deb0ad8

Merge with dev

5d7369d

Merge branch 'development' of github.com:gnosis/safe-react into devel…

3a5a2d0

…opment

Merge branch 'development' of github.com:gnosis/safe-react into devel…

f99a18c

…opment

Merge branch 'development' of github.com:gnosis/safe-react into devel…

f335b89

…opment

Merge branch 'development' of github.com:gnosis/safe-react into devel…

b1c53f8

…opment

Merge branch 'development' of github.com:gnosis/safe-react into devel…

97f3e52

…opment

Merge branch 'development' of github.com:gnosis/safe-react into devel…

79bf102

…opment

Merge branch 'development' of github.com:gnosis/safe-react into devel…

433fe9b

…opment

Collectibles utils

878c32c

Merge branch 'development' of github.com:gnosis/safe-react into devel…

89a80bd

…opment

Merge pull request #1720 from gnosis/release/v2.17.0

71bdd43

Fix safe-react-components

Fix wrong status on txs

71375f9

Merge branch 'development' of github.com:gnosis/safe-react into devel…

0814eb5

…opment

Merge branch 'development' into release/v2.17.0

94d9ee4

Merge pull request #1733 from gnosis/release/v2.17.0

f475808

Backmerge release v2.17.0

Fix typo in ADD_OR_UPDATE_SAFE reducer (#1735)

f143721

Prevent modal from closing on its own

62232e6

Merge branch 'development' of github.com:gnosis/safe-react into fix/m…

8946ebc

…odal-close

Update index.tsx

2af0fb0

Merge branch 'development' of github.com:gnosis/safe-react into devel…

283e62e

…opment

Allow sort for value column

6ffb736

Merge pull request #1738 from gnosis/fix/modal-close

5008ee4

Fix - Send Again modal close on its own

Merge branch 'development' into fix/balance-table-sort

d1cbc1a

Fix token price function to be more generic

a00539e

Merge branch 'fix/balance-table-sort' of github.com:gnosis/safe-react…

6369d87

… into fix/balance-table-sort

Merge pull request #1745 from gnosis/fix/balance-table-sort

b7fb603

Fix - Value column not sortable in Assets list

Cleanup erc20 amount calcs

cdbe4df

Fix asset value column alignment (#1778)

0fb1824

Agupane and others added 2 commits January 18, 2021 15:25

Adds TransactionFees modal to confirm safe app tx modal (#1789)

0d0acac

(Feature) Disable gas estimation for WalletConnect (#1790)

f79f377

* Make calculateGasOf receive object param * Disable estimation of gas feature for walletConnect * Add FIXME to walletConnect estimation check Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

francovenica approved these changes Jan 18, 2021

View reviewed changes

Set v2.18.0

0e1efc6

dasanra merged commit 42d438f into master Jan 19, 2021

github-actions bot locked and limited conversation to collaborators Jan 19, 2021

Conversation

dasanra commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added

Fixed

Chore

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

ghost commented Jan 15, 2021

Uh oh!

francovenica commented Jan 18, 2021

Uh oh!

tschubotz commented Jan 18, 2021

Uh oh!

github-actions bot commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Jan 18, 2021

Uh oh!

ghost commented Jan 18, 2021

Uh oh!

ghost commented Jan 18, 2021

Uh oh!

ghost commented Jan 18, 2021

Uh oh!

ghost commented Jan 18, 2021

Uh oh!

ghost commented Jan 18, 2021

Uh oh!

francovenica left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jan 19, 2021

Uh oh!

ghost commented Jan 19, 2021

Uh oh!

ghost commented Jan 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dasanra commented Jan 13, 2021 •

edited

Loading

github-actions bot commented Jan 18, 2021 •

edited

Loading