fix: Allow custom fields on messages to be updated even if msg prop is not updated (via API)#32791
Merged
kodiakhq[bot] merged 8 commits intodevelopfrom Aug 7, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 53c93c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32791 +/- ##
========================================
Coverage 54.98% 54.98%
========================================
Files 2596 2596
Lines 55971 55971
Branches 11585 11585
========================================
Hits 30775 30775
Misses 22553 22553
Partials 2643 2643
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
commented
Jul 15, 2024
matheusbsilva137
suggested changes
Jul 15, 2024
MarcosSpessatto
suggested changes
Jul 18, 2024
MarcosSpessatto
suggested changes
Jul 18, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we have a PR description?
MarcosSpessatto
previously approved these changes
Jul 18, 2024
MarcosSpessatto
approved these changes
Jul 30, 2024
KevLehman
changed the title
msg prop is not updated (via API)text prop is not updated (via API)
KevLehman
changed the title
text prop is not updated (via API)msg prop is not updated (via API)
matheusbsilva137
approved these changes
Jul 31, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2024
…Chat into improve/threadMetrics * 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat: ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930) fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791) test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967) ci: only rebuild docker if event is pull request and is from outside (#32997) ci: remove tmp files (#32996) test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995) chore: `FilterByText` component sanitization (#32957) chore: Renders back button through prop in admin settings (#32987) feat: add `sidepanel` to teams api (#32868) chore: don't mark room as read after sending message (#32941) chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed a behavior when updating messages that prevented the
customFieldsprop from being updated if there were no changes to themsgproperty. Now,customFieldswill be always updated on message update even ifmsgdoesn't changeIssue(s)
SUP-621
Steps to test or reproduce
Further comments