chore: FilterByText component sanitization#32957
Merged
kodiakhq[bot] merged 6 commits intodevelopfrom Aug 6, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32957 +/- ##
===========================================
- Coverage 54.97% 54.96% -0.02%
===========================================
Files 2595 2595
Lines 55964 55942 -22
Branches 11578 11575 -3
===========================================
- Hits 30766 30747 -19
+ Misses 22555 22552 -3
Partials 2643 2643
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
requested changes
Aug 1, 2024
dougfabris
force-pushed
the
chore/sanitize-filter-by-text
branch
from
e9f5409 to
e57bf2d
Compare
dougfabris
changed the title
FilterByText button propsFilterByText component sanitization
ggazzo
approved these changes
Aug 6, 2024
KevLehman
approved these changes
Aug 6, 2024
gabriellsh
approved these changes
Aug 6, 2024
gabriellsh
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2024
…Chat into improve/threadMetrics * 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat: ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930) fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791) test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967) ci: only rebuild docker if event is pull request and is from outside (#32997) ci: remove tmp files (#32996) test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995) chore: `FilterByText` component sanitization (#32957) chore: Renders back button through prop in admin settings (#32987) feat: add `sidepanel` to teams api (#32868) chore: don't mark room as read after sending message (#32941) chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
FilterByTextFilterByTextand visual details to compensate in necessary componentsuseEffectcausing infinity loop on non-memoized function callsIssue(s)
Steps to test or reproduce
Further comments
SCI-62