feat: add sidepanel to teams api#32868
Merged
kodiakhq[bot] merged 15 commits intodevelopfrom Aug 6, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c5a2af3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32868 +/- ##
===========================================
- Coverage 55.00% 54.93% -0.07%
===========================================
Files 2596 2598 +2
Lines 56005 56071 +66
Branches 11589 11598 +9
===========================================
+ Hits 30803 30804 +1
- Misses 22559 22637 +78
+ Partials 2643 2630 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
suggested changes
Jul 23, 2024
Contributor
matheusbsilva137
left a comment
matheusbsilva137
left a comment
There was a problem hiding this comment.
Also, can you please add more context in the PR description about how this change should work?
matheusbsilva137
suggested changes
Jul 25, 2024
juliajforesti
changed the title
sidepanel to teams createsidepanel to teams api
matheusbsilva137
suggested changes
Jul 26, 2024
apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts
Outdated
Show resolved
Hide resolved
matheusbsilva137
suggested changes
Jul 29, 2024
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
matheusbsilva137
approved these changes
Jul 29, 2024
ggazzo
approved these changes
Aug 5, 2024
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
juliajforesti
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2024
…Chat into improve/threadMetrics * 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat: ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930) fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791) test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967) ci: only rebuild docker if event is pull request and is from outside (#32997) ci: remove tmp files (#32996) test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995) chore: `FilterByText` component sanitization (#32957) chore: Renders back button through prop in admin settings (#32987) feat: add `sidepanel` to teams api (#32868) chore: don't mark room as read after sending message (#32941) chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIDE-134
Proposed changes (including videos or screenshots)
The
new navigationfeature adds the possibility of opening a sidepanel when opening a Team.The sidepanel can list the team's channels and/or discussions.
This will be a configuration for each team when creating or editing.
This PR prepares the api structure for the upcoming UI.
teams.createrooms.saveRoomSettingsIssue(s)
Steps to test or reproduce
Further comments