ci: Bump @actions/download-artifact and @actions/upload-artifact

[tassoevan]

Proposed changes (including videos or screenshots)

It upgrades GitHub workflows to @actions/downlad-artifact@v4 and @actions/upload-artifact@v4.

Issue(s)

Steps to test or reproduce

Further comments

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4e33299

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (45f0bc7) to head (4e33299).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32930      +/-   ##
===========================================
+ Coverage    54.98%   55.01%   +0.02%     
===========================================
  Files         2596     2596              
  Lines        55970    55945      -25     
  Branches     11584    11570      -14     
===========================================
+ Hits         30775    30776       +1     
+ Misses       22553    22531      -22     
+ Partials      2642     2638       -4     

Flag	Coverage Δ
unit	73.05% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sampaiodiego]

any real benefit on "merging" the artifacts before upload? I thought it would be actually good to have them separate.

if we want to indeed merge them I'd ask to provide a name to this job since "merge" is too vague IMO

[tassoevan]

I agree, but I didn't know how arbitrary the artifact names were so I went with keeping the old behavior. But wonder if using the shard indices would be useful e.g. playwright-trace-ce-6.0-3 is kinda random.