Skip to content

test: Mock dns.lookup on checkUrlForSsrf tests#32995

Merged
kodiakhq[bot] merged 2 commits intodevelopfrom
test/mock-dns-call-ssrf-tests
Aug 7, 2024
Merged

test: Mock dns.lookup on checkUrlForSsrf tests#32995
kodiakhq[bot] merged 2 commits intodevelopfrom
test/mock-dns-call-ssrf-tests

Conversation

@KevLehman
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Aug 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 6, 2024

⚠️ No Changeset found

Latest commit: eeb6d31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Aug 6, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (2c72a26) to head (eeb6d31).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32995   +/-   ##
========================================
  Coverage    54.98%   54.98%           
========================================
  Files         2596     2596           
  Lines        55970    55970           
  Branches     11584    11584           
========================================
  Hits         30775    30775           
  Misses       22553    22553           
  Partials      2642     2642           
Flag Coverage Δ
unit 73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review August 6, 2024 22:14
@KevLehman KevLehman requested a review from a team as a code owner August 6, 2024 22:14
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Aug 6, 2024
@KevLehman KevLehman added this to the 6.12 milestone Aug 6, 2024
@kodiakhq kodiakhq bot merged commit 3db7f57 into develop Aug 7, 2024
@kodiakhq kodiakhq bot deleted the test/mock-dns-call-ssrf-tests branch August 7, 2024 00:16
gabriellsh added a commit that referenced this pull request Aug 8, 2024
…Chat into improve/threadMetrics

* 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat:
  ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930)
  fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791)
  test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967)
  ci: only rebuild docker if event is pull request and is from outside (#32997)
  ci: remove tmp files (#32996)
  test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995)
  chore: `FilterByText` component sanitization (#32957)
  chore: Renders back button through prop in admin settings (#32987)
  feat: add `sidepanel` to teams api (#32868)
  chore: don't mark room as read after sending message (#32941)
  chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants