Skip to content

chore: Renders back button through prop in admin settings#32987

Merged
kodiakhq[bot] merged 4 commits intodevelopfrom
chore/settings-back-button
Aug 6, 2024
Merged

chore: Renders back button through prop in admin settings#32987
kodiakhq[bot] merged 4 commits intodevelopfrom
chore/settings-back-button

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Aug 5, 2024 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

This PR proposes to render the back button in GroupPage through onClickBack prop. It will allow to use this page outside the route without displaying the button that move back to the settings page

Issue(s)

Steps to test or reproduce

Further comments

SCI-63

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Aug 5, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1cf33bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris mentioned this pull request Aug 5, 2024
Merged
1 task
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (e28be46) to head (1cf33bc).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32987      +/-   ##
===========================================
- Coverage    55.00%   54.99%   -0.01%     
===========================================
  Files         2596     2596              
  Lines        56004    55992      -12     
  Branches     11588    11587       -1     
===========================================
- Hits         30803    30794       -9     
+ Misses       22559    22556       -3     
  Partials      2642     2642
Flag Coverage Δ
unit 73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review August 6, 2024 00:35
@dougfabris dougfabris requested a review from a team as a code owner August 6, 2024 00:35
@dougfabris dougfabris added this to the 6.12 milestone Aug 6, 2024
@dougfabris dougfabris changed the title chore: Renders back button only in admin settings route chore: Renders back button through prop in admin settings Aug 6, 2024
gabriellsh
gabriellsh approved these changes Aug 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I painstakingly opened each group and tested the back button. Manually.

@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Aug 6, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 6, 2024
@dougfabris
Copy link
Copy Markdown
Member Author

dougfabris commented Aug 6, 2024

@gabriellsh me too

@kodiakhq kodiakhq bot merged commit 5660be2 into develop Aug 6, 2024
@kodiakhq kodiakhq bot deleted the chore/settings-back-button branch August 6, 2024 19:32
gabriellsh added a commit that referenced this pull request Aug 8, 2024
@gabriellsh
Merge branch 'improve/threadMetrics' of github.com:RocketChat/Rocket.…
a7f92ae 
…Chat into improve/threadMetrics

* 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat:
  ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930)
  fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791)
  test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967)
  ci: only rebuild docker if event is pull request and is from outside (#32997)
  ci: remove tmp files (#32996)
  test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995)
  chore: `FilterByText` component sanitization (#32957)
  chore: Renders back button through prop in admin settings (#32987)
  feat: add `sidepanel` to teams api (#32868)
  chore: don't mark room as read after sending message (#32941)
  chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

6.12

Development

Successfully merging this pull request may close these issues.

2 participants

@dougfabris @gabriellsh