Skip to content

chore: don't mark room as read after sending message#32941

Merged
ggazzo merged 4 commits intodevelopfrom
dont-mark-as-read-after-message
Aug 6, 2024
Merged

chore: don't mark room as read after sending message#32941
ggazzo merged 4 commits intodevelopfrom
dont-mark-as-read-after-message

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented Jul 30, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

Apparently we don't need to call "read messages" after sending a message, the backend is smart enough to not mark our own subscription as unread.

Issue(s)

Steps to test or reproduce

  • Open a channel
  • Send a message
  • The room item in the sidebar should keep as read

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a21060a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 30, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (cf778f1) to head (a21060a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32941      +/-   ##
===========================================
- Coverage    55.00%   55.00%   -0.01%     
===========================================
  Files         2596     2596              
  Lines        56006    56005       -1     
  Branches     11589    11589              
===========================================
- Hits         30804    30803       -1     
  Misses       22559    22559              
  Partials      2643     2643
Flag Coverage Δ
unit 73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego force-pushed the dont-mark-as-read-after-message branch from 46c42ed to a65e105 Compare August 1, 2024 18:51
@sampaiodiego sampaiodiego changed the title chore: don't mark room as read after msg is sent chore: don't mark room as read after sending message Aug 1, 2024
@sampaiodiego sampaiodiego marked this pull request as ready for review August 1, 2024 18:52
@sampaiodiego sampaiodiego requested review from a team as code owners August 1, 2024 18:52
@ggazzo ggazzo added this to the 6.12 milestone Aug 1, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 1, 2024
@ggazzo ggazzo merged commit 9939508 into develop Aug 6, 2024
@ggazzo ggazzo deleted the dont-mark-as-read-after-message branch August 6, 2024 15:07
gabriellsh added a commit that referenced this pull request Aug 8, 2024
@gabriellsh
Merge branch 'improve/threadMetrics' of github.com:RocketChat/Rocket.…
a7f92ae 
…Chat into improve/threadMetrics

* 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat:
  ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930)
  fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791)
  test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967)
  ci: only rebuild docker if event is pull request and is from outside (#32997)
  ci: remove tmp files (#32996)
  test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995)
  chore: `FilterByText` component sanitization (#32957)
  chore: Renders back button through prop in admin settings (#32987)
  feat: add `sidepanel` to teams api (#32868)
  chore: don't mark room as read after sending message (#32941)
  chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@ricardogarim ricardogarim ricardogarim approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

6.12

Development

Successfully merging this pull request may close these issues.

3 participants

@sampaiodiego @ggazzo @ricardogarim