rebase #3
Merged
rebase #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added initial implementation * Add backrequested listener * Add handlers for other back actions Also remove debug code * Change files * Remove TODO * Responding to PR comments * Copied in Android BackHandler code from upstream * Changed the base file for the BackHandler override * Fixed weak ptr check * Removed unnecessary validation after casting XamlView to UIElement * Call JS with legacyPointer * More PR feedback * Use weak pointers to this in event handlers * Fix safety issue in query_cast * Revoke handlers on Uninit * Remove added binary file * use weak ptr for BackRequested too * Fix override hash verification
* fix include paths * Change files * fix include paths
* remove 4122 guard rail * re-enable dmanip test
Bumps [io-ts](https://github.com/gcanti/io-ts) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/gcanti/io-ts/releases) - [Changelog](https://github.com/gcanti/io-ts/blob/master/CHANGELOG.md) - [Commits](gcanti/io-ts@2.2.0...2.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.149 to 4.14.150. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* Make default template build non-dev bundle when not using debug configuration * Change files * review feedback * ReactNativeWindows location shouldn't be hard coded in template project, since RNW could be hoisted * Align bundle props with gradle build options * Fix playground app * minor change * Change how we find the packageroot
* Implemented C++ TurboModule compile time spec validation * Change files
Bumps [beachball](https://github.com/microsoft/beachball) from 1.29.1 to 1.30.2. - [Release notes](https://github.com/microsoft/beachball/releases) - [Changelog](https://github.com/microsoft/beachball/blob/master/azure-pipelines.release.yml) - [Commits](microsoft/beachball@beachball_v1.29.1...beachball_v1.30.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* Fix devtools connection to match RN0.62 * Change files * review feedback
* Publish fix * Creating new Microsoft.ReactNative.sln (#4535) * Created new Microsoft.ReactNative.sln * Update PR to build vnext/Microsoft.ReactNative.sln * Add params to disable ReactUWP nuget pack during PR * applying package updates ***NO_CI*** * Move playground app to use Microsoft.ReactNative (#4534) * Move playground app to use Microsoft.ReactNative * formatting * Bunch of code review feedback * Change files * formatting * Delete unneeded gitignore * Minor removal of diff * Minor changes to try to avoid having to update cert all the time * Fix bundle command * No need to build rntester seperately, the release build of playground will do it from msbuild * Remove test property * Bump beachball from 1.28.0 to 1.28.1 (#4539) * applying package updates ***NO_CI*** * applying package updates ***NO_CI*** * Enabling managed unit tests in CI loop (#4532) * Disable .net native for managed unit tests * Change files * Enable managed unit tests in ci loop * re-merge unit test tasks, can't run arm anyway * Remove prefer 32bit from 64bit flavors * Update mstest dependencies * Managed tests are separate again * Add comment * Add test adapter path * x86 debug again * Update test adapter folder * Try again * remove frameworkuap10 * Switch to appxrecipie * Try to switch to installed version of vstest * Remove installer task * applying package updates ***NO_CI*** * Remove 'Delete Android SDK' from E2ETest (#4554) * Enable WebSocketModule unit tests (#4538) * Prototype mockable MessageQueueThread and JSExecutor * Declare MockJSExecutor::CallFunctionFunctor * Add missing using std::unique_ptr * Use WebSocketModule::MethodId * clang format * Make WebSocketModule methods override instead of virtual. * Allow WebSocketModule to use custom resource factory * Rename *Impl to *Mock * Move Instance mocks into separate source files * Move Instance mocks into separate source files * Change files * clang format * Define WebSocketModule::SetResourceFactory * applying package updates ***NO_CI*** * Improve inner loop and error reporting (local CLI) (#4536) -Surface msbuild errors (shows as undefined right now) -downloading nuget with Invoke-WebRequest will usually take a long time because of the PS progress bar (which sadly gets updated for every byte), so I'm disabling the progress bar (it only takes a second to download when the progress bar is turned off) retry once if nuget failed since if you cancel at just the right time, you could end up with a truncated nuget.exe and are wedged unless you know which file to delete. Learned that the hard way. -factor out calling onto powershell functions -we were not exposing whether the function failed or not * applying package updates ***NO_CI*** * Don't set readyState on connection error (#4562) * Don't set readyState on connection error * Change files * applying package updates ***NO_CI*** * Bump @babel/core from 7.8.4 to 7.9.0 (#4565) * Simplified C++ macros and improved their comments (#4568) * Simplified C++ macros and improved their comments * Change files * applying package updates ***NO_CI*** * Handle syntax errors in RedBox * Change files * format * clean up Co-authored-by: Andrew Coates (REDMOND) <acoates@microsoft.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Julio César Rocha <JunielKatarn@users.noreply.github.com> Co-authored-by: Vladimir Morozov <vmoroz@users.noreply.github.com>
* Hook up to packager websocket to allow 'r' to reload instance * Change files * minor fix
* Publish ship and debug bits in the nuget * Change files * minor change
…les (#4677) * Start project to codegen NM2 from spec files * Basic codegen working. * formatting * formatting * Get basic codegen sample working. * minor change * minor change * minor changes * Change files
* Implement String ViewManager Command IDs In 0.61 Facebook added the ability to dispatch view manager commands using a string directly instead of the current indirection of getting a command ID from the view manager. This is leveraged in 0.62 in a couple places, including for Switches. UIManager overloads for string commands are added. This change impacts the C++ Microsoft.ReactNative ViewManager APIs C# and upstream view managers abstract away command IDs where they are currently left explicit in our C++ ViewManagers. Given our desire to implement built-in controls, we will need to support string commands here as well. This is made trickier with Facebook still publicly documenting grabbing command IDs from the VIewManager. Providing parallel explicit DispatchCommand functions to Microsoft.ReactNative ViewManagers would be too confusing to our users. Instead of adding parallel paths to the C++ ViewManager for commands without IDs, we remove the ID indirection entirely. Instead of internal ID mapping like we previously did with the C# ViewManagers, we now map constants to literal strings of themselves. This allows ViewManagers to accept the new form of literal string commands dispatched from JS without breaking the documented workflow of getting command IDs from the ViewManager. Eventually we should be able to remove integer only command IDs, as they are internally deprecated. Validated C# and C++ commands still work through the sample app. Validated switch behavior using the RNTester page. Fixes #4596 * Change files
* add devmode in template
* fix RTL * lint * Change files * fix clang formatting * fix github issue number
asklar
pushed a commit
that referenced
this pull request
Jul 24, 2020
* fix smoke test * comment * so far so good, try #3
asklar
pushed a commit
that referenced
this pull request
Aug 19, 2020
* re-enable * comment out PlatformColor test, this was the failing test in the past as well * trying again, this time commenting out PanResponder Sample, which comes just before the failing test * trying to wait for home page to load before continuing * another take on waiting for item in FlatList to be loaded first * trying new approach, enter test name in edit box to filter first * made some progress, now timing out on edit control, add polling for that control * finally! success. Try #2 * try #3, fingers crossed! * try #4 * split test into groups * bumping up timeout * try #2 with longer timeout * go back to one testspec * try #4 with longer timeout * try #5 with longer timeout. really folks I think I got it this time :) * convert all the tests to use same mechanism * Change files * remove smoke test * stability pass after removing smoke test, try #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.