This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Main into String Delimiters #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initialize Bond serializers and deserializers asynchronously. * Change lock entered verification implementation.
* Remove NonNullable * Temporarily skip execution tests * Fix sln * Fix sln again :( * Remove reference to Example.csproj * Bump minor version to 13 * Bump DocumentationGenerator version * Re-enable execution tests * Skip execution tests again * Remove example project from solution * Re-enable execution tests * Update versions in Sdk.props * Update minor version to 14 Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>
…rce name (#741) * Create a new DotnetCoreDll property that always provides the name of the resource currently used by the compiler to attach the syntax tree to a DLL. * Fix typo.
…ond code generation during build (#752) * Include generated c-sharp file in source control instead of generating it when the solution is built. * Add message about code generation on the Bond schema. * Prevent Bond files from doing code generation.
…lable (#759) * updated to SDK 0.14.2011120240 * addressed the removal of NonNullable
* Fix ClassicallyControlled Rewrite bugs This change includes 3 fixes/updates to the ClassicallyControlled rewrite step: 1. It adds handling for ExpressionKind.NOT so that those conditions get properly restructured and processed for lifting (fixes #763) 2. If a conditional statement has an empty scope, it gets replaced with a call to `NoOp` instead of being lifted into an empty callable. * Refactor use of QsNullable in ProcessNOT * Remove attempted fix for IsValidScope propagation * Adding test cases for NOT
* Only initialize Bond protocols when needed. * Have separate APIs for initializing serializers and deserializers. * Make Bond initialization APIs safe to call anytime. * Fix logical error.
* Reference loading performance accounting breakdown. (#590) (#630) * Refactor code a bit to be able to make performance tracking more widely available. * Better perfomance tracking methods. * It works, clean-up pending. * Clean-up before publishing PR. * Apply suggestions from code review Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Log error when somwthing goes wrong while tracking performance. * Made two source files nullable enabled. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Added performance tracking for specific rewrite steps based off the name field of the step. * Use a separate Task enum value for specific rewrite steps. * Made description more consistent. * Moved start of rewrite steps task. Removed whitespace from details. * Make sure a suffix can only be added to leaf tasks. * PR comments * Fixed build issues that arised from merging 'main' into 'feature/performance-tracking-improvements'. * Add performance tracking tests (#713) * Expanded compilation tracker interface. * Added performance tracking tests. * Fixed project file. * Created CompilationTrackerTests.fs source file. * Added a few more test cases in F#. * Added more test cases to validate time accounting. * Added expcetion-based test cases. * Removed Tests.PerformanceTracking C# project. * Use built-in Assert.Throws. * Apply suggestions from code review Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Format type annotations. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Remove pragma directive that is no longer needed. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Scott Carda <sccarda@microsoft.com> Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com>
Response Files Format Update
* Adds ConcreteIntrinsicGenProperty as an assembly constant and Q# project property.
Restored pathing to proj argument. Removed pathing from assembly name.
…ugh a Task (#777) * Add remarks to constructors and methods that must not be invoked through a Task. * Use 'invoked' instead of 'called'. * Update src/QsCompiler/BondSchemas/Protocols.cs Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Use Sarah's suggestion on remarks phrasing. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Updated condition for incremental build to handle multiple lines in response files.
* Update build trigger Add a trigger to build on `main` for component governance detection. * delay build on main until midnight PST * move scheduled build to Saturdays
* Update npm packages with npm audit * Remove placeholder tests * Fix language server URLs
* Update specialization names in monomorphization. * KeepAllIntrinsics option for monomorphization. * Add all specializations for a referenced callable to the concrete call graph.
* Set inilineNested to false at deserializer initialization. * Add comment explaining the change. * Addressed feedback from Sarah. * Improved comment around deserializer initialization using Sarah's suggestion.
* Basic multi-thread implementation (no publishing yet). * Implement multi-thread perf publishing. * Change task name per thread format.
…equired capability (#771)
* Optimize acquisition of BondSharedDataStructuresLock. * Added comments on ideas about the parallelization of reference loading. * Basic parallel reference loading is working. * Re-enable perf tracking that can happen in parallel. * Added documentation to new public method. * Remove TODOs.
* Initial attempt to detect .NET SDK 3.1 and display a message if not found (cherry picked from commit 59681e9) * Show a dialog with option to open .NET 3.1 download page (cherry picked from commit b538b3d) * Better error message (cherry picked from commit 28e79dd) * Update src/QsCompiler/LanguageServer/Utils.cs Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit f2cd93b) * Update src/QsCompiler/LanguageServer/Utils.cs Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit de463e0) * Update src/QsCompiler/LanguageServer/LanguageServer.cs Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit 7911bd5) * Update src/QsCompiler/LanguageServer/LanguageServer.cs Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit c19177d) * Addressing minor PR review comments (cherry picked from commit 283cecd) * Add global.json and set working directory (cherry picked from commit 833af12) * Continue to start the server even if there were issues with the MSBuildLocator (cherry picked from commit 64d7d11) * Add comments to MsBuildLocator exception handling (cherry picked from commit dc99a4b) * Use .NET 5.0 SDK and build the Language Server to target the 5.0 runtime * Revert "Use .NET 5.0 SDK and build the Language Server to target the 5.0 runtime" This reverts commit e11e158. * Fix warnings * Rename global.json * Preserve log of exception * Check null from Process.Start Co-authored-by: Victor XField <vxfield@outlook.com>
* Deprecate parentheses in statements and block headers * Add tests for parentheses in statements * Update FunctorGeneration tests * Update GlobalVerification tests * Fix deprecatedTupleBrackets * Update LocalVerification tests * Fix doc comment for deprecatedTupleBrackets * Add tests for using without block * Allow using/borrowing to be followed by semicolon * Add more tests * Build implicit scopes for using and borrowing * Add more tests * Add use and borrow keywords * Update syntax highlighting * Update tests * Update code completion * Update VS Code snippet * Consistent phrasing in deprecated keyword warning Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com> * Update use/borrow keyword in tests * Add more specific warning message for using/borrowing * Hide using/borrowing in code completion * Formatting Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
ScottCarda-MS
requested review from
DmitryVasilevsky,
bamarsha,
bettinaheim and
cesarzc
bamarsha
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged in from main branch